Message-ID: <795b6ac2-9745-7992-566e-950037e622e4@linaro.org>
Date:   Fri, 27 Jan 2023 12:03:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v4 0/5] remoteproc: qcom_q6v5_pas: add support for SM8550
 adsp, cdsp & mpss
Content-Language: en-US
To:     Bjorn Andersson <andersson@kernel.org>, agross@kernel.org,
        robh+dt@kernel.org, neil.armstrong@linaro.org, mani@kernel.org,
        srinivas.kandagatla@linaro.org, krzysztof.kozlowski+dt@linaro.org,
        amahesh@qti.qualcomm.com, mathieu.poirier@linaro.org,
        konrad.dybcio@somainline.org
Cc:     linux-arm-msm@vger.kernel.org, elder@linaro.org,
        abel.vesa@linaro.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org
References: <20221114-narmstrong-sm8550-upstream-remoteproc-v4-0-54154c08c0b7@linaro.org>
 <167406406337.2924867.12230424280288709048.b4-ty@kernel.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <167406406337.2924867.12230424280288709048.b4-ty@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/01/2023 18:47, Bjorn Andersson wrote:
> On Wed, 18 Jan 2023 17:22:39 +0100, Neil Armstrong wrote:
>> This patchsets adds support for the aDSP, cDSP and MPSS found in the
>> SM8550 SoC.
>>
>> The aDSP, cDSP and MPSS boot process on SM8550 now requires a secondary
>> "Devicetree" firmware to be passed along the main Firmware, and the cDSP
>> a new power domain named "NSP".
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/5] dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common
>       commit: cee616c6884616aea3be72a9debafd0614332682
> [2/5] dt-bindings: remoteproc: qcom: adsp: document sm8550 adsp, cdsp & mpss compatible
>       commit: 084258d607128a7486311daf5e67ca414ee07cc9
> [3/5] remoteproc: qcom_q6v5_pas: add support for dtb co-firmware loading
>       commit: 29814986b82e820ae9d3eb7474cdcf66605bd114
> [4/5] remoteproc: qcom_q6v5_pas: add support for assigning memory to firmware
>       commit: c63c0a7cab91b930a6ee78c28b481b84bfa98b7f
> [5/5] remoteproc: qcom_q6v5_pas: add sm8550 adsp, cdsp & mpss c


The bindings were not tested against their own DTS:

sm8550-mtp.dtb: remoteproc@32300000: power-domain-names: ['cx', 'mxc',
'nsp'] is too long

so now it throws fresh warnings... I don't know what is wrong here -
either DTS or the bindings - but they probably were never used together.


Best regards,
Krzysztof