Message-ID: <9d0a15ee-c5d0-7d3c-7aa8-58383211f637@amd.com>
Date:   Fri, 27 Jan 2023 16:47:45 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v6 7/7] cdx: add device attributes
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org,
        rafael@kernel.org, eric.auger@redhat.com,
        alex.williamson@redhat.com, cohuck@redhat.com,
        song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org,
        maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com,
        saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org,
        yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com,
        robin.murphy@arm.com, will@kernel.org, joro@8bytes.org,
        masahiroy@kernel.org, ndesaulniers@google.com,
        linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc:     okaya@kernel.org, harpreet.anand@amd.com, nikhil.agarwal@amd.com,
        michal.simek@amd.com, git@amd.com
References: <20230126104630.15493-1-nipun.gupta@amd.com>
 <20230126104630.15493-8-nipun.gupta@amd.com>
 <97a939cd-3898-3d54-e496-a8f33a62856a@infradead.org>
From:   Nipun Gupta <nipun.gupta@amd.com>
In-Reply-To: <97a939cd-3898-3d54-e496-a8f33a62856a@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmNlOGtXdDd5dCtJSUxPMG9NQjJiODAvRHM2V1Q0MjRaOWQrd2gzN2hkLzdJ?=
 =?utf-8?B?NzB2eE50SlZqUWpreGJDempjaEhuRmZSZndxbVBCWTJ0bTg4bko4TytUWmU1?=
 =?utf-8?B?QjBmZ0NDY2hSYVQvaVhUMkdxenJZd3UzV0VGdzlpdVNzRW9TaTYxRS9pbFhl?=
 =?utf-8?B?SndwNjl3TTQyS2c5dXdRRmRLK0ZMZ1g1V2xUL0E5ZzQrcnZudVRXYkd3ajdy?=
 =?utf-8?B?L3Fud2pyS2djaGJmei9BSTRhTy9RT0pxVUUyTkJRSzRZY0gyYzdRdmZ1TnF1?=
 =?utf-8?B?TkdJSmRFN1dVSlE1NDcwdFdxcStDK1pEd1V0MldVREZkdkdPQzNvRHIrR1FK?=
 =?utf-8?B?UUlwTlYyM2NVczhWRnhURDJDTXZ5ZUt2YnVkc1hvbGhjWENUSG9FcDFUSC9p?=
 =?utf-8?B?WGQwQVpaSk50UWM2L3lLbEEzTkhFRzdnbUdlRGVvQ1ZWN2ZEUGZ0YXZBbmtT?=
 =?utf-8?B?ZHdtSEZDRXNtS3ptT1JvNUttR2tKUDlGSmhnUmVkckV5YTI0TFhYM0RKYWl1?=
 =?utf-8?B?Z1c4TU9jcGFGMGRaejhzclp4RFZ1cHRUT0tDME1GQTY5Z2pqaEhZK294NGpj?=
 =?utf-8?B?TFN4WHg1MGJ2OUVzTG0wWVlacFMwLzUxTmhKNC84RWdZUHNqUW5adDVySE5Y?=
 =?utf-8?B?cHUwakNpRHRyRE1IRVJSSEVXR2VLMTcwVTZGZnNyTmtWMnB0Qyt2dUp1clZN?=
 =?utf-8?B?dzhsSWgrRjJMMEYvUHJJQTlNTzJrUDhUeTNMYkNxTTNDTWw0Qk9ieEtTNFRS?=
 =?utf-8?B?TUdteGtqTGZjRThSOHFKR2pzWEJwSHNJZWRPN2NhSlh2RlN1QVRBT1V4SnlG?=
 =?utf-8?B?TlpXS3dnN1FmanVYdEFJS1B6MzF0cEVta09DeTU0WEdQZkhtYTFHYlJOMmtB?=
 =?utf-8?B?UUM3SURiMmw2bVZWVk5CMVZlaUVUNkpDVmMzV21BdFNobkhSYXF5a2tQOWp1?=
 =?utf-8?B?dy9NaitPMDAyZXpVWjB0RDd2U1EyeTZZMVJScjQwdmdtYmdiSTJqSUxjbW1G?=
 =?utf-8?B?dTFKSlBxcjhMUFVhdWh5VUtaYlEvUUNJcUxlYU9nYmw1c0pPUTl0U2VKaUpU?=
 =?utf-8?B?SkI1SW5nQVh1QXpUUXNUYVpZbVdXNHNZdFRJeXRFcHJydGcwb3VuSmZzWlE4?=
 =?utf-8?B?VTdBbE1TaERobFJHWnd2Z3dndUVIZHdNd0V1VGQ0aFo0THRobnh0bW9aeE5m?=
 =?utf-8?B?Lzdsc2s2eTJuZmVtczRVcjlMVGtvbG5QWEZxUDM1RlNmQWFYakI0eVo2cXEy?=
 =?utf-8?B?R3FSaWlBcjBUcWtEV3NsMldnQTMwZzlaTXJLQkNodU1zUW9hKzJBb0pYcmRp?=
 =?utf-8?B?V0ZDTXIwNWF2c1BVemVSSHhTbzdkRHpZVUpHd1I4bEM3TWEwRUpuMHRrYWNn?=
 =?utf-8?B?dGR4ZmZSU3c5elIxa002MWJZdzFZdUZLNXdBT2p0UkpHSHE5WnNQSy9WQ202?=
 =?utf-8?B?QlZRMGxyalRwcE9PVnkrRVlVc2crQnA1VmMwd2htbFp4NjRUbDNaOUVJdm5w?=
 =?utf-8?B?NFVhdEhpbUZSK3R1bEVIL1dmeFZwZVhHeCtoNG5FRlVheGtuVC9UdHE3eUgz?=
 =?utf-8?B?SkUwTmprckdvdWp0Um40RXcwMEVXeWZROWVTRlptK2RqbEFtQ0JBVGxxSW5y?=
 =?utf-8?B?YllZWEczcHIyb3ZuSHV5MG84RHo1dDJWMTEwQXhUdVNpMXBRWWxyT09qdkR4?=
 =?utf-8?B?OEhmaHdTakZBTVh2c0R2V3pvdWwvOEE3T1NBMjFMYk84TWhSVmZKYW9TV3c5?=
 =?utf-8?B?V0hBYzZkUldSS2dwbWM1UEZIeTMrMVc4MGQ1ek91TU5pYlFwbGdoWFNXc1hL?=
 =?utf-8?B?R3JFeXgvTUJhZVpLd0xNSFdELzJlZGZ4NDdTZ0VmUEF1VVd3aU9jM2JBeHQ4?=
 =?utf-8?B?YjBSeG54NnIzMmhEV1R0RHZWTEtZcWtYUWhvSVNQTWkvY2JEVGl5cUZJQ2FH?=
 =?utf-8?B?bG9yUjFRcG0vSS85bmV4VEFrdnVxR3ZvZjhRM1h0SUJDZ1RiY2k5Smd2TUhi?=
 =?utf-8?B?M3lPK2NiVEVoRFptWjMzN1dqL1BnN0o3VmxJeDV4ZjM4a2Yyc2xzZjVMVnNB?=
 =?utf-8?B?eERvdUQ3MGxOQk52T3h1YkpsT2ZlMVdPSGYrMmdwMXpRVEVCMWQzUS9PYUpa?=
 =?utf-8?Q?i3Lq+xVE+xTOEelZgF8Edeg8C?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0512481-b94f-402e-f1bd-08db00582877
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3087.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 11:18:04.4440
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HZOn/yaph/CyeVT4n3NO1DxmMvW7RzgzCuegCXHeIJ8kKUIO2GD2HRfPAsu4EHj+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8408
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/26/2023 10:25 PM, Randy Dunlap wrote:
> Hi--
> 
> On 1/26/23 02:46, Nipun Gupta wrote:
>> diff --git a/Documentation/ABI/testing/sysfs-bus-cdx b/Documentation/ABI/testing/sysfs-bus-cdx
>> index 8c2425fdb6d9..69bdbc891743 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-cdx
>> +++ b/Documentation/ABI/testing/sysfs-bus-cdx
>> @@ -10,3 +10,47 @@ Description:
>>                   For example::
>>
>>                  # echo 1 > /sys/bus/cdx/rescan
>> +
>> +What:                /sys/bus/cdx/devices/.../vendor
>> +Date:                January 2023
>> +Contact:     nipun.gupta@amd.com
>> +Description:
>> +             Vendor ID for this CDX device. Vendor ID is 16 bit
>> +             identifier which is specific to the device manufacturer.
>> +             Combination of Vendor ID and Device ID identifies a device.
>> +
>> +What:                /sys/bus/cdx/devices/.../device
>> +Date:                January 2023
>> +Contact:     nipun.gupta@amd.com
>> +Description:
>> +             Device ID for this CDX device. Device ID is a 16 bit
>> +             identifier to identify a device type within the range
>> +             of a device manufacturer.
>> +             Combination of Vendor ID and Device ID identifies a device.
>> +
>> +What:                /sys/bus/cdx/devices/.../reset
>> +Date:                January 2023
>> +Contact:     nipun.gupta@amd.com
>> +Description:
> 
> Reads better without "would":
> 
>> +             Writing a non-zero value to this file would reset the CDX> +            device. On resetting the device, the corresponding driver
>> +             would be notified twice, once before the device is being
>> +             reset, and again after the reset has been complete.
> 
> 
>                  Writing a non-zero value to this file resets the CDX
>                  device. On resetting the device, the corresponding driver
>                  is notified twice, once before the device is being
>                  reset, and again after the reset has been complete.
> 
>> +
>> +                For example::
>> +
>> +               # echo 1 > /sys/bus/cdx/.../reset
>> +
>> +What:                /sys/bus/cdx/devices/.../remove
>> +Date:                January 2023
>> +Contact:     tarak.reddy@amd.com
>> +Description:
>> +             Writing a non-zero value to this file would remove the
>> +             corrosponding device from the CDX bus. If the device is
>> +             to be reconfigured in the Hardware, the device can be
>> +             removed, so that the device driver does not access the
>> +             device while it is being reconfigured.
> 
> and: (also fix typo of corresponding)

Thanks for the review. Will fix and update these.

Regards
Nipun

> 
>                  Writing a non-zero value to this file removes the
>                  corresponding device from the CDX bus. If the device is
>                  to be reconfigured in the Hardware, the device can be
>                  removed, so that the device driver does not access the
>                  device while it is being reconfigured.
> 
>> +
>> +             For example::
>> +
>> +               # echo 1 > /sys/bus/cdx/devices/.../remove
> 
> --
> ~Randy