Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From:   Joey Gouly <joey.gouly@arm.com>
To:     Andrew Jones <andrew.jones@linux.dev>, <kvmarm@lists.linux.dev>,
        <kvm@vger.kernel.org>
CC:     <joey.gouly@arm.com>, Alexandru Elisei <alexandru.elisei@arm.com>,
        Christoffer Dall <christoffer.dall@arm.com>,
        Fuad Tabba <tabba@google.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Joey Gouly <Joey.Gouly@arm.com>, Marc Zyngier <maz@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Oliver Upton <oliver.upton@linux.dev>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Quentin Perret <qperret@google.com>,
        Steven Price <steven.price@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        "Thomas Huth" <thuth@redhat.com>, Will Deacon <will@kernel.org>,
        Zenghui Yu <yuzenghui@huawei.com>,
        <linux-coco@lists.linux.dev>, <kvmarm@lists.cs.columbia.edu>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: [RFC kvm-unit-tests 18/27] arm: gic-v3-its: Use shared pages wherever needed
Date:   Fri, 27 Jan 2023 11:40:59 +0000
Message-ID: <20230127114108.10025-19-joey.gouly@arm.com>
In-Reply-To: <20230127114108.10025-1-joey.gouly@arm.com>
References: <20230127112248.136810-1-suzuki.poulose@arm.com>
 <20230127114108.10025-1-joey.gouly@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
NoDisclaimer: true
X-Microsoft-Antispam-Message-Info-Original: Y6Na1gYNSfIFPFmAAsVTq4EsI/YhfrpjuUunJU4DpofTTnlFerHTlwpDNDwbw4jekRyCVkGX+En2c5OxxhiNeMtRCcqdguZeW5MP6LkUCprTRs3J/8JxAzOZZrq8EfNkx5oeI772L/Nba9tDaiZfQ/op+3jeuZ1plOqAS+k/xP6cQqDfnNb97EgsKtzRIfm3Hxjx4FlcFOr+jqB+Rybr9lizg/X5NwzAOf9LSmIIN7K+5KhN1fmcdcXvGX/9AdOiz/o69lYSOTNx98wk+8aTtOUwKJzBaWR+iKZRWaqQYWA7rRyT8guFDrynSXCv0CPJfS/hjaVCJl0CdS3C27zpBHMCJCUnz1iTdJ7fq8zWqQ6x2m7SgfeGNVVvSb+CFQXX5qsQmwGepr6nIyvIm70LpJ4zIT4Dj3eS5b/kyc8p8cQPxXm+kcAuzebk+sccGWcZXQVoJDt2biGOlhAVLlJ3RMy01Vrj0zJo/PLPokNC1a/jYStb9yxH/2Uv1TOzmgRpxFqqkdggUyQvKNn06UTwhG26I3YKimZOGBvh6v2P8keeQk5oAcc4FWbUW+Iw7aF23PNtJmWwVX3KOblnWEHI4YCl21Z42ynwNMs/Lef3bygERH4ic6XhO+9F3VG3RMw0s0p7p/fkOjbicFKJMqdb2szAp3TxPoZM4a4UAtRANjzLmUZS0e4lMxyFSKg8FePBTVvnQsEDPrXNI2wRT0AHw8Dzl5XDpiMahQOJTvOU0QZIEoml92UQj0oVe9JlPTNs
X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(39860400002)(346002)(376002)(451199018)(40470700004)(36840700001)(46966006)(41300700001)(70206006)(26005)(186003)(356005)(70586007)(8936002)(8676002)(83380400001)(5660300002)(44832011)(1076003)(7416002)(81166007)(478600001)(36756003)(2616005)(36860700001)(47076005)(426003)(54906003)(110136005)(7696005)(86362001)(336012)(82310400005)(40480700001)(4326008)(40460700003)(2906002)(316002)(82740400003)(2101003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8160
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 5d224b18-d083-4de9-1107-08db005ba39f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7mw6ePfL8uOc6q85baaJUa094Yzef1YRB0QWVr4dPPS4rMksT6SK8dxqG5aMJvaTqm/noFiLxeAkQm5yujb4ZHHKAWuccfX8fQokxlW2v5eG5osJGiD5ylRekUIqmsSaHYNHaLYKs+/4JrDNikp6pfRXkBa1Xpn/jsCZOsJ8Z0UTHxLmr1YIu0So+yru8YSXChalblS7Sy90ec9lp2liLW2VYOnVFHsQoqXW76jimmYovcY/Jte5vm70R9V2w2D+Y8lKm6wYYXZQWO3+hgbyNy2sd5gbQb3kt0F7IXOIQyR+FB6T/msG8UrPMdeGM5iTmmp+l58aAf1cPSJSATvhnGdo9pv/q1G7E1nN9+gH5BPNHHC5FOZ41Ggbq1cCNzgV3u4s4Fv7C+3ofNS7Q7x+Ns8VFA/WOhUOcbVVOy+P/naELnu77zSnI9f+7O0joRHCb0F/+kQl/NaYEu8lkEMHTYCxtL4EZ1OpVWa8/lPkSoZgqsKx3ji3Dy32aaKDlcWmxw73Y2r24d+QKkcyXGs9pVLoS9gqnDDSdqp4uTTrCzcVr85+49ZOC9y50htesuQv8qWM1Hmea7b1mscxEmEw2PhS//UHmmLDadiO1Q72KxbUBpSTz/vbTLNK1+JQDUA5YTtCWItwaJwGhRUtVclgfipeAWw94nOjqBmWRRLBAyESGI/wJIMfg/hkJXGQ1k1Wt2hpiHzZegkknXYydvsS9tFCSTrDGbqZshnZOAjN/wc=
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(396003)(376002)(39860400002)(451199018)(40470700004)(36840700001)(46966006)(7696005)(110136005)(1076003)(2616005)(336012)(478600001)(426003)(316002)(47076005)(54906003)(26005)(186003)(450100002)(70206006)(70586007)(4326008)(83380400001)(8676002)(41300700001)(5660300002)(8936002)(81166007)(44832011)(36860700001)(2906002)(82740400003)(36756003)(40480700001)(82310400005)(40460700003)(86362001)(2101003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 11:43:10.2259
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b6b33f75-0292-446a-3b97-08db005baa54
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8466
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Suzuki K Poulose <suzuki.poulose@arm.com>

GICv3-ITS is emulated by the host and thus we should allocate shared pages for
access by the host. Make sure the allocations are shared.

Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Joey Gouly <joey.gouly@arm.com>
---
 lib/arm/gic-v3.c       | 6 ++++--
 lib/arm64/gic-v3-its.c | 6 +++---
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/lib/arm/gic-v3.c b/lib/arm/gic-v3.c
index 2f7870ab..813cd5a6 100644
--- a/lib/arm/gic-v3.c
+++ b/lib/arm/gic-v3.c
@@ -171,7 +171,9 @@ void gicv3_lpi_alloc_tables(void)
 	u64 prop_val;
 	int cpu;
 
-	gicv3_data.lpi_prop = alloc_pages(order);
+	assert(gicv3_redist_base());
+
+	gicv3_data.lpi_prop = alloc_pages_shared(order);
 
 	/* ID bits = 13, ie. up to 14b LPI INTID */
 	prop_val = (u64)(virt_to_phys(gicv3_data.lpi_prop)) | 13;
@@ -186,7 +188,7 @@ void gicv3_lpi_alloc_tables(void)
 
 		writeq(prop_val, ptr + GICR_PROPBASER);
 
-		gicv3_data.lpi_pend[cpu] = alloc_pages(order);
+		gicv3_data.lpi_pend[cpu] = alloc_pages_shared(order);
 		pend_val = (u64)(virt_to_phys(gicv3_data.lpi_pend[cpu]));
 		writeq(pend_val, ptr + GICR_PENDBASER);
 	}
diff --git a/lib/arm64/gic-v3-its.c b/lib/arm64/gic-v3-its.c
index 2c69cfda..07dbeb81 100644
--- a/lib/arm64/gic-v3-its.c
+++ b/lib/arm64/gic-v3-its.c
@@ -54,7 +54,7 @@ static void its_baser_alloc_table(struct its_baser *baser, size_t size)
 	void *reg_addr = gicv3_its_base() + GITS_BASER + baser->index * 8;
 	u64 val = readq(reg_addr);
 
-	baser->table_addr = alloc_pages(order);
+	baser->table_addr = alloc_pages_shared(order);
 
 	val |= virt_to_phys(baser->table_addr) | GITS_BASER_VALID;
 
@@ -70,7 +70,7 @@ static void its_cmd_queue_init(void)
 	unsigned long order = get_order(SZ_64K >> PAGE_SHIFT);
 	u64 cbaser;
 
-	its_data.cmd_base = alloc_pages(order);
+	its_data.cmd_base = alloc_pages_shared(order);
 
 	cbaser = virt_to_phys(its_data.cmd_base) | (SZ_64K / SZ_4K - 1) | GITS_CBASER_VALID;
 
@@ -123,7 +123,7 @@ struct its_device *its_create_device(u32 device_id, int nr_ites)
 	new->nr_ites = nr_ites;
 
 	n = (its_data.typer.ite_size * nr_ites) >> PAGE_SHIFT;
-	new->itt = alloc_pages(get_order(n));
+	new->itt = alloc_pages_shared(get_order(n));
 
 	its_data.nr_devices++;
 	return new;
-- 
2.17.1