Message-ID: <b7880f0b-a592-cf2d-03b9-1ccfd83f8223@amd.com>
Date:   Fri, 27 Jan 2023 22:56:26 +1100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [Question PATCH kernel] x86/amd/sev/nmi+vc: Fix stack handling
 (why is this happening?)
Content-Language: en-US
To:     Joerg Roedel <joro@8bytes.org>,
        Peter Zijlstra <peterz@infradead.org>
Cc:     kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Sean Christopherson <seanjc@google.com>,
        Jiri Kosina <jkosina@suse.cz>, Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Tom Lendacky <thomas.lendacky@amd.com>
References: <20230127035616.508966-1-aik@amd.com>
 <Y9OUfofjxDtTmwyV@hirez.programming.kicks-ass.net>
 <Y9OpcoSacyOkPkvl@8bytes.org>
From:   Alexey Kardashevskiy <aik@amd.com>
In-Reply-To: <Y9OpcoSacyOkPkvl@8bytes.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXo4aFR2NHdZNDhxWHEzdys0MkdFdjFpaVFWRW91SlQwd3dzbXArdElPeW5s?=
 =?utf-8?B?MzdxS3hrd21QcjR5a1RLZkkzOTVsSi9tSjMxMlU1Y2p2NzYxVm1pQTd1YVU2?=
 =?utf-8?B?aGdUVW42UEExU1djaGdXTndlUGZuckgwYWFIQ2dqRnU2UGVIUU1aYjlJK0pF?=
 =?utf-8?B?clZjTnlMRHVSaDQ3UnZjMGNmSnpsbkliWjlwbUIzSTN5ZWkrVk1qbEFka3k0?=
 =?utf-8?B?TE8xR1J2UDNENUdNaGNJM1UweVVZZDJzTUd1Y21iUElDcDQ3OGc2NURLZWVO?=
 =?utf-8?B?SHpBTE5aaUxxaTdKbXNZQUNGOHpOVThDUjFSNUxYR0xYVUJMcXBIcXlNYldr?=
 =?utf-8?B?QzZVMHlWSkhLVEppNEZLRjNVbXpMVFR6Y0w3d3NOd0xIU1l5d0xsTEs3Y2pU?=
 =?utf-8?B?dkFsNVU4eW5ZNEJhQnFFNGxoL3NicW00SlM1RUp4TkZOZENycEFEMXREZTls?=
 =?utf-8?B?eWl1MG9XRkVtQjhITitRNHFkTjJqZzNMYzhtd25sZEp1WUwxM0N5WDNZa3dt?=
 =?utf-8?B?aExHWnl1UjBTUEpvLzM3aGVwZUdwRkg0SWU3NURjcWNKL2w2aUZPRjN6Wnh3?=
 =?utf-8?B?bzYvazNoM0NpM0JWbkhBN2srM1k0aFRvVm1pcWMyMVRwZzVENGoyZVBlYm14?=
 =?utf-8?B?V25mQkZJYXU3VS9HSThJQzBmVlFwVWttRHozWFhEczRwSlZHUjM0ZTlFWjlK?=
 =?utf-8?B?ZnRQK0kyaUdxK0RrVWNhMS9hZVUrUUF4ejNzaGRwUWlWeTdnc3JKK0k0MzdR?=
 =?utf-8?B?OWdYeTlHYlRteENYUWpNUXFVckdVM1ZGNGc1eGF6Z3VMZHk0YmFEd21SSWlU?=
 =?utf-8?B?U1RqaVNaTFJwUGlzcnYyaHoxVVJSWWFsWGJJeGhadTVuU2VrdFR4emlUeVM3?=
 =?utf-8?B?OXZpbGdUMnF4VGJiSms4Slg4eDNFMFFXc3Y0WCtEYnN1Qld1NmloRldaOUFq?=
 =?utf-8?B?L016Y0ZDcngrVjFZNEhSY0hkQjIyRVd5REdYUm5uRHBIUExFbDJ3V1lTQ2pV?=
 =?utf-8?B?V0c5VW05SHlnNjZRODc3VnEranpMU0JUY2hqWDhVb0xZVlN3WUQ3NTIzMUtE?=
 =?utf-8?B?ZFBPRVdBYUdQc2NrMEREZVBENmxMN000K3lUbUR2L3Q5ZGRoSlVPTlJETENH?=
 =?utf-8?B?SUt5WWJUU3ltRGErN05iMGpyMEZDajNWRmdHcXJOenF2eVUydldlWEtJdFRX?=
 =?utf-8?B?dGFLajNPc2dUWUtWVXZsWTlOMFBZdmdmVUpwank4S1R0UDdCcUJpUnR2VEFB?=
 =?utf-8?B?a25yRmx5ZksvRyt6b1JHd0ttTGtOYWR2MzAxTHJHMmZ0UXBzK3haOXAzYTZL?=
 =?utf-8?B?Q2tmcFdPdWQ3MFNaMVZQMkZqS3pPb0xLY2poYkUrNklzYW9tdExleFBPWUFQ?=
 =?utf-8?B?ZW15SzBHRXBIa3Z1R2RnbEEzelc0NkppNFZMKzZwbDQ3U1FmN3lOSnhWcUF5?=
 =?utf-8?B?bVRQalkzaHlRWlRaa09FaEtiWGJzOURpTTMrZmN2WE9MMUdmMjdRa0l0ZDBv?=
 =?utf-8?B?UENuY3RnMWJjNFo4enRwV3BoZ0QwRlNGVXVTWnRjRkFwMkhJc2o2Y0NpL1Nt?=
 =?utf-8?B?ME95b2U2MEtWbkVpcGVBWTMrb3pSRmNQckI2NWY3RkJxYS8xRnF1Ty9iQXFu?=
 =?utf-8?B?dG9VbFdCZTMyaTNmMkpsdG9qUG1nNWVmSUF6YzcxZTlvbVJhblZ3UjZqY1BZ?=
 =?utf-8?B?UU5mSnp4ZlpnbU9kckJiWHRyREszZmZ5bCtsTEJuNWxsSmMxUHVhK2dwUjJr?=
 =?utf-8?B?VW9lSzdRVmdXc0xaUS9iU3ZBWGc4Tkxxb1lZeFZqclAyUjBSNXVLUWUrS216?=
 =?utf-8?B?bmZwZTJ1N0NMNm0vZzg4c3VOdTJuNjMya1h5ZXdaVWJYbWhVZXpoVGVnRGpy?=
 =?utf-8?B?ZWxwWGRqdXJJMXlUUlRzcGl4NWxGNFlVaEhBWjR2bXo2VnRDY0FaYlRtTVY2?=
 =?utf-8?B?NHExc1NsVjRWK2RmUFMrT2JaaVcrTEtiUWw3NDkyTG9DRGpHR05vdmlxaGlI?=
 =?utf-8?B?c0NjcmJ6L3lzMXljbVQzVmZPZTI1TmNmM2xmNVU5ZmZIcnY3TC9yQUYzak4y?=
 =?utf-8?B?WUpHTDR1R0dRRlNMTEVaVXhlWWFZOGx3aEV4eU5PTk1URFhvU3FQMVZ6N0tG?=
 =?utf-8?Q?4JY2aXDZSi5P/g8AkvjkWbiZ4?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 760afbeb-84c4-4efa-e672-08db005d9011
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2843.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 11:56:45.5545
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h9pK8eyIIBQetGNsiJQMqNzi/icYqq5Sg07r1rFGcUffaFCjMvL0NUpC2OqYQhcUtP76bJA2BA/YkJk/rwv+4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6712
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 27/1/23 21:37, Joerg Roedel wrote:
> On Fri, Jan 27, 2023 at 10:08:14AM +0100, Peter Zijlstra wrote:
>> Welcome to the wonderful shit show that is x86 exceptions :/
>>
>> I thought sev_es_*() is supposed to fix this. Joerg, any clue?
> 
> Hmm, no, not yet, the stack-trace doesn't make much sense to me. The
> sev_es_* function calls in the NMI path are for re-enabling NMI and
> adjusting the #VC IST stack to allow nested VCs.
> 
> Alexey, can you try to get a more stable backtrace? For example by
> building the kernel with frame pointers?

Do you mean these guys (below)?

aik@aik-Standard-PC-i440FX-PIIX-1996:~$ grep FRAME_POINTER 
/boot/config-$(uname -r)
CONFIG_SCHED_OMIT_FRAME_POINTER=y 

CONFIG_FRAME_POINTER=y 

CONFIG_UNWINDER_FRAME_POINTER=y


Here is the complete output of that VM (200k so not in the email):

https://github.com/aik/linux/commit/d0d6bbb58fcd927ddd1f8e9d42ab121920c7eafc

Note that the original long backtrace appears more than once, I just did 
not copy all of that in the first email.

-- 
Alexey