Date:   Fri, 27 Jan 2023 12:19:50 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Astrid Rost <astrid.rost@axis.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, kernel@axis.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] ASoC: simple-card-utils: create jack inputs for
 aux_devs
Message-ID: <Y9PBZjkW7Nrsg4j9@sirena.org.uk>
References: <20230123135913.2720991-1-astrid.rost@axis.com>
 <20230123135913.2720991-3-astrid.rost@axis.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fuFuiNw5hNV4x0Gr"
Content-Disposition: inline
In-Reply-To: <20230123135913.2720991-3-astrid.rost@axis.com>
Precedence: bulk


--fuFuiNw5hNV4x0Gr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 23, 2023 at 02:59:12PM +0100, Astrid Rost wrote:
> Add a generic way to create jack inputs for auxiliary jack detection
> drivers (e.g. via i2c, spi), which are not part of any real codec.
> The simple-card can be used as combining card driver to add the jacks,
> no new one is required.
>=20
> Create a jack (for input-events) for jack devices in the auxiliary
> device list (aux_devs). A device which returns a valid value on
> get_jack_type counts as jack device; set_jack is required
> to add the jack to the device.
>=20
> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
> ---
>  include/sound/simple_card_utils.h     |  3 ++
>  sound/soc/generic/simple-card-utils.c | 49 +++++++++++++++++++++++++++
>  sound/soc/generic/simple-card.c       |  4 +++
>  3 files changed, 56 insertions(+)

Given that everyone is really supposed to be using the
audio-graph cards for new systems this should be hooked up there
too.

--fuFuiNw5hNV4x0Gr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPTwWUACgkQJNaLcl1U
h9D7mwf+Igj87QjF+3lzDf5KS/kImXkgHpOujb/L88hKqV2wmVR20+aOYXJ3l16/
o88NNDzo9WM7DCHi3x/RrJT5ezFuMsxufIO5zd+dwlnAailGOLBObwM6Mc1O7xPU
TWf+dfkS07QDZ4vs3+UWhRvQ4dcn1QskWFnjmnqNg7sDzmID3thA8ekDSsHtpSlF
OUgBaJpaRB8d7C/iT4cHmmJ9F0lhdivdk51D50PFwFD9JLfsphSygZA8eD3nA5BH
DaskyGe9RJM2bWvNk99dNjIf/QUKmtWChBaCZ5D8+6o1Iwr/ocQqeajo61vfO18d
1e3oqNMZ8X1w70OurF3732GlTToDHQ==
=2ZBv
-----END PGP SIGNATURE-----

--fuFuiNw5hNV4x0Gr--