Message-ID: <468aef98-2bd7-03d5-0f83-dc58bc4738e9@linaro.org>
Date:   Fri, 27 Jan 2023 14:01:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 4/4] arm64: dts: meson: add support for BananaPi M2-Pro
Content-Language: en-US
To:     Christian Hewitt <christianshewitt@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic <linux-amlogic@lists.infradead.org>,
        linux-kernel@vger.kernel.org
References: <20230127100236.3385154-1-christianshewitt@gmail.com>
 <20230127100236.3385154-5-christianshewitt@gmail.com>
 <a35f7f09-eb19-6cfc-2053-c6b340f10cbd@linaro.org>
 <356B9EBF-B9C4-4CB0-9F83-9E7A62F93F65@gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <356B9EBF-B9C4-4CB0-9F83-9E7A62F93F65@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 27/01/2023 11:19, Christian Hewitt wrote:
>> It's by default. Did any DTSI disable the sound node?
> 
> No. I’m simply transcribing from the original M5 dts (with edits to omit
> the audio jack bits) and the sound nodes of other Amlogic dts which have
> long included the same. 
> 
> Q. Do I need to remove it here? (sounds like a yes)

Yes

> Q. Do we need to exorcise/cleanup the same from all other meson dts?

Yes, please.

Best regards,
Krzysztof