Message-ID: <0fe85fad-f9a3-3295-865a-7d8872276bcb@oracle.com>
Date:   Fri, 27 Jan 2023 13:18:32 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v5 12/15] perf pmu-events: Fix testing with
 JEVENTS_ARCH=all
Content-Language: en-US
To:     Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>,
        James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Florian Fischer <florian.fischer@muhq.space>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Xing Zhengjun <zhengjun.xing@linux.intel.com>,
        Rob Herring <robh@kernel.org>,
        Kang Minchul <tegongkang@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sandipan Das <sandipan.das@amd.com>,
        Jing Zhang <renyu.zj@linux.alibaba.com>,
        linuxppc-dev@lists.ozlabs.org, Kajol Jain <kjain@linux.ibm.com>
Cc:     Stephane Eranian <eranian@google.com>,
        Perry Taylor <perry.taylor@intel.com>,
        Caleb Biggers <caleb.biggers@intel.com>
References: <20230126233645.200509-1-irogers@google.com>
 <20230126233645.200509-13-irogers@google.com>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230126233645.200509-13-irogers@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUtEbzdYNk9WdmdlQ05LczZnYVo2ckx5bDJEME5HeU92NDJKWjViRmN4a1p4?=
 =?utf-8?B?dEw5a1JvTkYxc2ZzMUVQQkY2R0w4WDMwNEFNTTVjSTNSVzhnaElNZGs0MElR?=
 =?utf-8?B?SnE2ZkhEdkg3VmhlMG5lbGp1SDM0RVFvTVdxTC81LzdZYkk4U1pIK3hIZFlk?=
 =?utf-8?B?TWkyUWVRejI1Q1JyRDZKRlFiUGRRVTlSeVMzaUdtTGkyaU9EaGJVZll6Uy9P?=
 =?utf-8?B?SXo2UVk2dWlpY29ybTA5WEI5dlhxVGIyR1RQU0pyVGM5SUIyNVpJV0lBN1c0?=
 =?utf-8?B?aStBMm8vVWRqUktzbDM5dkt6THNjdm1rQ0R4MGJHZWRGWTlDODZPSytKUE9o?=
 =?utf-8?B?Rkl0b3NHcTdXZkU1N01ZaVZWaGR4emhUREJ5ZWtvcW0rTExiQjk5dEcrcGN0?=
 =?utf-8?B?MmQ2RkVEQUZjcnV0ZUEzeUVicE00QkNueEF1Nmk5Ym9UYmVGMGkraHQzYkRP?=
 =?utf-8?B?M3FiZi9hSmdrMmlzTWZvSmRhWndiZ0FrUXBsYVhJMGY4TEl5M3ZSNHJVUDNW?=
 =?utf-8?B?K0Y0QXJPL1dVb011NUxsQzZSNzhxbndSa2crTVd3OWIrb1pPVUxxbndxQ2xk?=
 =?utf-8?B?ZUJPTEJ2bzc1WGNrNVF6bEduV1RzS1ZMZzYxek4zeTRMV0ZTYk4rTk1EdlRK?=
 =?utf-8?B?bjJIY09zS3pGNGZNVUVNekgwTE9vNzZJVkZaT0wzNDZoZEZMc1htNkpMZU90?=
 =?utf-8?B?a0tCeW8rZ3BlcUhPTmJPUGkwb2VCejJVdTI1M05uTVhRUVV0MGY5ZUNwc01G?=
 =?utf-8?B?V2NqTGw4cnFHbFRVTlhiNXZzOXB1SVhMMG9JQ0NYd1dmeWhFY05kNmhkSEox?=
 =?utf-8?B?c3Nybng2QjEyNVhuOEFYRWFOeDFGWG9WMnJPNWJwVTgzVmg4TmtUNnhSQmMw?=
 =?utf-8?B?bzVHZ0p6YVdSc0pqUGlwZklPM3B2TzYzZWpSY3pVY2JIK2pvVVJOYnVTQVlR?=
 =?utf-8?B?KzFkbnRQN1cvQWRiZ01DbUJKQzRTdDZMaEVUWk05UmY1RUQ3dStOcUduUm1s?=
 =?utf-8?B?QUVSMi8xUEd4bHprOEtKbGZ6Yng0cGhtUU5xSFB3Z3kzZDJncUpqbkw3TnlN?=
 =?utf-8?B?Qk41OGtpMEhhcEhVaFRMUWVITVBYMXRrY1NiaVo2V1l2YXdYWE9kVHdaZVBS?=
 =?utf-8?B?WWkvd1dEejRGZmMxb1RlVkRkcVB6ZTBoSlBoZ0FVK1B5R2RmOEJhQVRGd1dy?=
 =?utf-8?B?WE9BbDVTZGkwUHQrLzFodjFnN2VtcGsrdTdsem1XWHExaitHS05jTEhPNDBu?=
 =?utf-8?B?NCtKV0NQUkoxTU9pZUVKTWJQcTcrcmJnWk5UamZ4blVYdUlHNE9OVTB6b25M?=
 =?utf-8?B?MDgrbGNsRm5RbTkya3VQRGxKckZVdXcxSFdGYkp1VU1SQ1VvSUROcnQ4MU1Y?=
 =?utf-8?B?by80TFZlV0d5c1lra21MOVFjY3lKRUo2R3RMQWNpTGpOaWJKR251aU5PbnhJ?=
 =?utf-8?B?UE03bk0rNEtOdTVEN3ZobDZSdEhocTU4WWRCa2c4THUwTXRSV0pGblFlanlv?=
 =?utf-8?B?ZFM5Q0MzTzcvc2RtUVNpNEdPVU9sNEJSMFpkNzMxUi9iOFpObU5RY0lvNnM1?=
 =?utf-8?B?OU43d21DcldnVE9mRzNaZnZPMitiaE9JR051a1B1YStLbGhwdnYvMEw1STFC?=
 =?utf-8?B?TkZMSjZCU0t1djVDQnYrSU1RckRNSFp5VTZUcmZUTkpGNnQ5RU5JcVNkZ0kw?=
 =?utf-8?B?aHBWa3ZkSU8rQVFyRzRpZzBYUzYrZ2MzTGV5RnJpNjd1Vjk1QmhUM1JDL1dB?=
 =?utf-8?B?c1VwZEtSQ3h1OFNaV1pwYnZ4NUljY1l3citOeTEwRGZQa1pjS21wVmtsTTlY?=
 =?utf-8?B?K3F3NXYwamJ1bklVMVNVNE41N2ZScTBVNWRzOXIrUmUyUHE2dlErb0FZLzd4?=
 =?utf-8?B?N3dsMjlLdzg3a28xYVRDcjR4QzQ3ZTdQTWxTaHdBSnB2S3FQVzJwYlVuMFNO?=
 =?utf-8?B?b3hMLzBjaWt5TzhVNHhEWDhpZEdpTE5HYksrWjJGZUMvTFZTd0gyWjRYYVBv?=
 =?utf-8?B?R0lUNnRCV0FhQ2locW1CVFkwdnVIRDNhN0FaNmlqTUIwRHNXN2JzWm1BaWli?=
 =?utf-8?B?L3h0L1QvRDVkV0J6Qno0bjEvdzZFVXF5cGMzYXZmVjh0YUVYM2JtRkVKSkJC?=
 =?utf-8?B?Ti9POFBtbUk0Uzd6Zkt4MjA4Qm1nL3VsMXNJUzlBZ1hCYTNiQ1RaTkxGZW1T?=
 =?utf-8?B?N0E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?WGtndzFjbGxQdDhwYjF1Q2k5WjFWL2kxSUFpcWNhVVlrN0g0VDcwb0hhblJz?=
 =?utf-8?B?MUphVUpnVGprZ2o3UmJsTlVsa1EvSU1yS0VsM2VaNi9NbmZSSFZqd09GWEkz?=
 =?utf-8?B?V0VXL09Ncm9sNGRrNlNSWHhFbXJGUU5uU3NJNHY5eWtDSVhXZHNMQ2s3aHlu?=
 =?utf-8?B?bU5USWM0cDVzc3ZXRnllUXJMMm11Rk1DL3pkWEtvSHc3emlxdTdTeXN0U29K?=
 =?utf-8?B?OS9CZEZKWHNzS0g2Y3hxSHAraS9aWFNQR0NNTG9lNHZQSkVjb2ppVmZWR3hO?=
 =?utf-8?B?bVl1ZHZ2dFVKZmNGMWlDNXIwdnVScVpOQjBuU296U0lseFk2eFJMY2kyWmNP?=
 =?utf-8?B?Z1dDUXBET2NrOGNZUTBJWjlJSllMb3BCN09BQlVreXRNYVMxL3gwek9Uc3BR?=
 =?utf-8?B?WnVFWVpCQWY1aWhVRDNRZm1lZjBBVkloWnNINTFmYzU5bno3eUtWdFBmeURL?=
 =?utf-8?B?M3JwUDh6VVBKUWJqS3hTT0pwMW5HTXcyQVc2ZnJxVnlMU1NDVjR6Z3JvV0Jo?=
 =?utf-8?B?UUFGeHdETDdhcTc0WHhJQTdVRXRKRkZmK2M4NXlzdFUzbDBRTkxVRVRyQUxt?=
 =?utf-8?B?MVVxRnUwT2pkQ05OeTFaWi9HaU5ZUjZQYTB5bG94RTI1K2FhazViK0NETmpQ?=
 =?utf-8?B?Mm9rOVVGNDNPcjRVV3NHaVgvQnN3eFF4Yzdjd0ZuTktYUXBydW9GN0dFOHd4?=
 =?utf-8?B?TDRCY3pZY2lrTkRXOEhienJUeTVDWm5mNGZWQ0dLbVU5dER2Wk1WeVNQc1p4?=
 =?utf-8?B?S1pUdUYrN2IwdTNCSVlhM2NDek05WDlWUU4ydTEzYnhqYkhYcWZXV1lOQmlX?=
 =?utf-8?B?eGxFaVN5MlJJRHpiMjRDeDJFWlRwRmg4N3ZaSlV2TjdLb0pwUkRlV3dlR2pD?=
 =?utf-8?B?NXd4aGdpTHcxZzIyMFo3K0JyUnd3WTh1dFNSeGxJMTdxUWFGemw4RkRJVEpP?=
 =?utf-8?B?Yzd3V1lDOFJPZjJkSnB6QXRUeUdGajEwKzNYeHJvNVE4eWdEWU50QVI4Zi9I?=
 =?utf-8?B?eFM4RXVtRHFaVW5UcThVOHoweXVSWFdRR0xhNjRuV0FqNktZZklKRHVQd29W?=
 =?utf-8?B?VGRaUEdiT0wxcXBRSDFWSnIrZmdXeFduVWJnQTB5L3haUjNiV0syZUJjcmJV?=
 =?utf-8?B?VEh0RWxETTJDSjBEM29aZzdLaGlWaHVkUVFsS1dvOFdIQVkrZFlUeXRlYkRj?=
 =?utf-8?B?eEYyNDVBb21TeC9wNXJSYUUzUzNmOHVaRUxoc00xSEpqcUg0T1k3T2g5S1hU?=
 =?utf-8?B?SzVWSThmVXpHWkxZWUFZeHRQWUNpYzBUV3NaZVVVNjFGYzdoY0JBcmJwWTA3?=
 =?utf-8?B?UlZYWHpLN2lzZWk3aEwrNW02Q01tM2JCckNHeUFCMmpwSkFJT0hqNkJDUCsz?=
 =?utf-8?B?YjZtL0FxZGd6MEFVK1M1NHVpaGs5d3NjV05HUDIzanpGamhMS2JiUG5FbnJu?=
 =?utf-8?B?blpaUWRXUE1XMXlUU0t4VDRPR3gyeG15V2JBWnhDa2dXb29QR1B2VWZjVnhr?=
 =?utf-8?B?ZzFDd2diMWpRNkxHMVY5S21meUxiMUY0eTFHTXNDbnRTc2R5elF5N2xGZlRs?=
 =?utf-8?B?SVhDK1ZNL3doUHJPMko1Z0VRNkxSRm1vbitWTFZzblZmTTkyZ1J1YkpCRjd6?=
 =?utf-8?B?OEVaeE5kVEdra05Iam1MdnZ0Q2RzMWEvNExnVEREWTlyY0hWa1VWODhtYUF6?=
 =?utf-8?Q?vyjtVclS5jEXzk8T8uYc?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bddacd53-9f2a-459b-31cb-08db00690797
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 13:18:50.4940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EKz6CloGCCeJcC5BBLLuKxqRJh64+gpcAoBU5DXa6/m3BnehSbuVNnAU7KGE1wzMtBlpEYA8443CcEcqeJQ3gQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5724
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-27_08,2023-01-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 mlxscore=0 suspectscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301270126
X-Proofpoint-GUID: ntsqyddLpT0wVAwg6RGpulDW8oYf2jd1
X-Proofpoint-ORIG-GUID: ntsqyddLpT0wVAwg6RGpulDW8oYf2jd1
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 26/01/2023 23:36, Ian Rogers wrote:
> The #slots literal will return NAN when not on ARM64 which causes a
> perf test failure when not on an ARM64 for a JEVENTS_ARCH=all build:
> ..
>   10.4: Parsing of PMU event table metrics with fake PMUs             : FAILED!
> ..
> Add an is_test boolean so that the failure can be avoided when running
> as a test.
> 
> Fixes: acef233b7ca7 ("perf pmu: Add #slots literal support for arm64")
> ---

Again, no SoB here.

For me, though:

Reviewed-by: John Garry <john.g.garry@oracle.com>