Date:   Fri, 27 Jan 2023 07:25:40 -0600
From:   Tom Saeger <tom.saeger@oracle.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Naresh Kamboju <naresh.kamboju@linaro.org>,
        John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        Rich Felker <dalias@libc.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Ard Biesheuvel <ardb@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Dennis Gilmore <dennis@ausil.us>,
        Palmer Dabbelt <palmer@rivosinc.com>,
        Arnd Bergmann <arnd@arndb.de>, stable@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 5.4 fix build id for arm64 6/6] sh: define
 RUNTIME_DISCARD_EXIT
Message-ID: <20230127132540.agmyuzg64wlcwglo@oracle.com>
References: <cover.1674588616.git.tom.saeger@oracle.com>
 <7301d95edaf5bd0926bc93a67cb0cc1256549c95.1674588616.git.tom.saeger@oracle.com>
 <Y9N9Ux4asZRE25zC@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Y9N9Ux4asZRE25zC@kroah.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SE9mWHpFc2RDWFV3OGlMRHRjeUkzUk9mRTJ2OXZrL3BNanUrM2FkZlZLYmc3?=
 =?utf-8?B?eW8ySVZvdjhKQVFaVkVUd1JENjdRVWJCZGp5THo4UnR3T3BlWXMvdWVwTXB6?=
 =?utf-8?B?OWpEdnBrOENMdUFYQldkSXh1YW01cEJlUWlBUlVlN3VyMkZDWGpoT3BsQXJv?=
 =?utf-8?B?b1dYK2pXdWd4ZSt0Z21iUkhYTGV2czFzaTJYbE96TzJmMmhFV2psYXNockt1?=
 =?utf-8?B?OVN3WXEyOU5pa2ZrQXRieUkxY29LZjZPRXVoN0xVb2ljaDhTaHB1MXFtWTFv?=
 =?utf-8?B?ODNxTEVjOVFUQnNHSzhROU0zbmtnaVcxc3QxZ0FPUTV4OEhDNmZzUlpDU0ts?=
 =?utf-8?B?MXZOSzhaZ2REWkJKcnRtVXNmYU9KbUNDd0hnWlNMeDJjbVdJM0V2Sk9uZUg1?=
 =?utf-8?B?VE5UWWZzb2NGWmJ2K2VaL0J5QTNDcnVMajR4L1FFT3NTNDJvWGRkK3BwUGVU?=
 =?utf-8?B?NkpHWitUbkJoZE9xa25RdWY5YXBhZlU5VkdkQmRHQTlVeGp2YzIvamJ1eGdE?=
 =?utf-8?B?UUZ5cGs5QjRveHdPc1J4Wm9SMG93OHEvMmlSNENaQjlqSTQ1QklYNXNHcFIr?=
 =?utf-8?B?cC8yb3JMWjVYdUlrNXQwdmJaWjZGVEh4SzdmbytxNG0vem9Cemt1dWJIMTZS?=
 =?utf-8?B?Q2o2WUd6UkllcTlqNWd0MEJjU1IvZHFVRDlnNEZwMkNEY202UlhpUFVRWnE5?=
 =?utf-8?B?WncvMjJpbXQrbDM0c2ZQQVlXR2F0VGxQVThTUC9qSnBnb2thTG5BdFFEYWEy?=
 =?utf-8?B?V0RRVEZNREVNVkdZR1pTLy9EeTFaZDdqREJibExEU20xVHp0dERsaEdMZ0h5?=
 =?utf-8?B?ejdwL2xKRmpUWWQzd2N5TlltbnRWR1NXK2RBazJVaThKdGcwaWt5SWMyQjB1?=
 =?utf-8?B?VWZlajI1WHYycXZkd3I0d0FuYktRRHBadENjTHFuaENsWXdZUy9qY042ZmJG?=
 =?utf-8?B?QTlYUGtmNkNCQXdiUnVJbGlCaElRckZkV0pHMXdjWitwS09XcytoaFNIdTFV?=
 =?utf-8?B?RENSdkNDa2t2QzJGQjlLSjNndjBES1pBQ21hZnhNb0J1SFZ0M1M4NUptb2la?=
 =?utf-8?B?TUtzejR4QjBWUk9MTTNZa29HMUFtRTQ5b25hY1hQNUtoUHhKUU52REV0Tndy?=
 =?utf-8?B?anFNUis1L2dsZlYyRlZWSzhWZDJSMHhpTHFPMkE4TjJkTDJKZXR3Y3JIVHNt?=
 =?utf-8?B?VWREdEJwZ1hrNVpUZDZ3aHdMQjVGdlFCNWxyZ3czMHAxRlhvSHdyMGQzMzF2?=
 =?utf-8?B?YkVwR3hUNlNNWm82SWxESHpqZzEyUis5elhkckh5QnRWUEtmendJalUrVzk3?=
 =?utf-8?B?WnBoR0V3MmtobHdmM2c0SDdSNlRYNCs0YTd5S2xXSDlUdFZPaEkxM0NreVNN?=
 =?utf-8?B?Qi8zSXVCMmJZMVBacEVEY1NXd3JSeVk3NDFHZWZRVVg0TExzMmFERThqSDBr?=
 =?utf-8?B?Zis2RkptMGI1RFdmUEpzYWovS3BGY0d4TVdjUTZHa3h3SUNVMUVwcWUzMzB1?=
 =?utf-8?B?dHM0VWt0L3daV3RyMk5jL1NmWlZXQkpGUHQ0QThaTytTVlBwaVJLbFlRRHdQ?=
 =?utf-8?B?elg1V3FCMUc3MWZBNFRPcEMwcXA5MzhVbmd4ZEdNTVZOWDFySkZLSDdYWmtu?=
 =?utf-8?B?cFVhc0hKTlpCN1ZzNWJ6dGRIYzk2MDlGa2haMlBRd0c0dE9uenBYc0FpVFdv?=
 =?utf-8?B?LzRoS1pjSjNGWjhtZmMzUE9BS2xOTjVzL2RpN2tlSjc3czZDTEI2TzREM3py?=
 =?utf-8?B?L1JIT29tODVHSmU3VnpJaFJCZUIrRmFscDk1WlB5MkhQQWgxaDB1Q0hWd04r?=
 =?utf-8?B?ZDZobWZkdE04MWFWWk41OEFYSUo3SzhYWnlKZUlDRXNtSTdMV3RWanRueHRm?=
 =?utf-8?B?dUlKSHdCakF1dXpsWmdoaEUreUp0Tzg3TlNEZ0FTcVdXdDBqd2ZBNXVJdGta?=
 =?utf-8?B?QmhjR3F5VFd2dFVtOTNPWjF0SlVEdHhRZDVaKy9TT2RnYnM3OXNJUm9QVktQ?=
 =?utf-8?B?VXZ3elBHaEMzUjd5a1R3ZlFSSVNEcWlQaFBZVS9WZzVuOHVtbHpkUllsUExF?=
 =?utf-8?B?RDB3VHpHR1B4MG80N2MvanhSSlovYnIzSmFzQkxKVUF0NS9BZEhuSWQyd2JO?=
 =?utf-8?Q?MPqhSlr3a5j4g5wObKGpPnGli?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?OWVBN1pvY1JISlpZRzdWWGtseWl6STltZVpyRkJtVlpUTG1ITWs0b1h2TExu?=
 =?utf-8?B?TXF1bFVzbEoxWXJuTVJoM3hzNTJmMkdjdVliY2xLTVpzUVVIaE5nZnhQbkVD?=
 =?utf-8?B?ME1ZdUNJT0h0QW1BRHd5aUt2ZllQejVoeDh0L3JDbEFHOUZVT0tBc2ZnQXow?=
 =?utf-8?B?NDdVRjVWQTMrdDkwc25pK3hNRCtUbzV6OHRFNnE5WE1VcWdBd2lHV1VSeFQ4?=
 =?utf-8?B?dVhXekpqVTd2R1duTnM4MGlxQ1RBU1l6ZnFsMzZuRjZnNHl3SGFjdXpZQnEx?=
 =?utf-8?B?OWpCMUc3c0FVU0NsaUY2RWRRVGE2Mk8xVkdiaUM5Sm00eXFVcXhQTDRoT29W?=
 =?utf-8?B?R2h4RkpiL24xSmtxdWFkUkl6TnNWMWVIMlA3d1JHUkNKSkxGRHRXMEVNQnha?=
 =?utf-8?B?NU9Nc0FwQmhEQzVHZ1FXY2htM2pvb2RybnIrcVZKODZJTUZzcXBVK0VkMk9X?=
 =?utf-8?B?eWdsQXVlUi9oWmQycnpMRXJFeU1TUlp0RkNlQ21ha3l4Tk9YYm8zdnVaQkVO?=
 =?utf-8?B?NW9yOUIweVVFd0lhRVJvMFVzL0Q5RVlxQWNCdmRNSTdiMlVCbzd1eUNuaTRy?=
 =?utf-8?B?SUZoK1ZNMzJpbXFoaHprTnRkK1hER3NURGk5RlFCRXpsZXAwTXdpMWdiYkRF?=
 =?utf-8?B?d1Z3VFk3ajE0UFFuUVRzVnE2VFFWdjN3emMxYUdwVUFESUxjRnorbWJaMmZ2?=
 =?utf-8?B?WnliYjdxNWF6ejJuanBDUmc1aW1GYVVyT0Z1RDJwcTY2VnU3eVk3U1h0R3Bo?=
 =?utf-8?B?WnFlalZwQW5aeHRyYi95Q2ZvQysydnZDY2ZFb2pQSzNvL0RTMnBxVXQzNW5Z?=
 =?utf-8?B?ZnA2U29Yc08rd0tOUjd2eTJYS1VGL0crUmxzeExta3RoQ2dncDg1cEVWUUc4?=
 =?utf-8?B?cDFMUDFJQUNSeVNhaW5GOWQrbUlQWG55YmRja1ZxeEVFQVo3bVEyTWt0dkx5?=
 =?utf-8?B?eG9BNHJ6cTd2TGFML2F4RTFPMEFsUmd1Y2h2WnJsbEk1YnorZDhIa0lzcndH?=
 =?utf-8?B?TUhOdFV3OGxVN2F3d2RYV1pJQ1BweERsTWtUQ0VZeStDajQzc0Q4Mmk5ZGEx?=
 =?utf-8?B?NlU0dEpaV01CLzM0ckR5VkR0TmJHcEkzd0tUZkc5cnpSeS9zWTEwK2d6N0tE?=
 =?utf-8?B?V2ZlNFNkdUJWaFFacC9mWjl6a0VvV0tDNHo0YmRjVlB5ZUduYkhuQVgvclJt?=
 =?utf-8?B?VER3SFpWVzRqNThNVXB6V0pZTHpZUlRoVXltQlVZbkZqQVRWYS95cW5RTGlZ?=
 =?utf-8?B?VFc3T2J2bmF3MFpBdHJIYjBNTHpsSFVyUlMzMkpMK0R0ZzJwM2xOSXJZZmdT?=
 =?utf-8?B?dXU4Rm9vTU9YaSsvcjFnT2w4cWM4K2o0QnlROTdoeHkxa3ZNOGxpMWQ0WmpS?=
 =?utf-8?B?Y0JLenpIbE9QUmc9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a15c603-d730-4cae-fb74-08db0069feec
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3794.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 13:25:45.5629
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rdzz0LJ7l95rLqXoG7HocvYObxCeH6tU/jDVgRy4EyQGRq6x+AjrKknn9Lu44HSFK+zYOD7UySpX8RQnhV9nIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4899
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-27_08,2023-01-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 mlxscore=0 suspectscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301270127
X-Proofpoint-GUID: 3ZcRfph89oF0y6eu7E40SyctBzlV47ai
X-Proofpoint-ORIG-GUID: 3ZcRfph89oF0y6eu7E40SyctBzlV47ai
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 27, 2023 at 08:29:23AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 24, 2023 at 02:14:23PM -0700, Tom Saeger wrote:
> > sh vmlinux fails to link with GNU ld < 2.40 (likely < 2.36) since
> > commit 99cb0d917ffa ("arch: fix broken BuildID for arm64 and riscv").
> > 
> > This is similar to fixes for powerpc and s390:
> > commit 4b9880dbf3bd ("powerpc/vmlinux.lds: Define RUNTIME_DISCARD_EXIT").
> > commit a494398bde27 ("s390: define RUNTIME_DISCARD_EXIT to fix link error
> > with GNU ld < 2.36").
> > 
> >   $ sh4-linux-gnu-ld --version | head -n1
> >   GNU ld (GNU Binutils for Debian) 2.35.2
> > 
> >   $ make ARCH=sh CROSS_COMPILE=sh4-linux-gnu- microdev_defconfig
> >   $ make ARCH=sh CROSS_COMPILE=sh4-linux-gnu-
> > 
> >   `.exit.text' referenced in section `__bug_table' of crypto/algboss.o:
> >   defined in discarded section `.exit.text' of crypto/algboss.o
> >   `.exit.text' referenced in section `__bug_table' of
> >   drivers/char/hw_random/core.o: defined in discarded section
> >   `.exit.text' of drivers/char/hw_random/core.o
> >   make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1
> >   make[1]: *** [Makefile:1252: vmlinux] Error 2
> > 
> > arch/sh/kernel/vmlinux.lds.S keeps EXIT_TEXT:
> > 
> > 	/*
> > 	 * .exit.text is discarded at runtime, not link time, to deal with
> > 	 * references from __bug_table
> > 	 */
> > 	.exit.text : AT(ADDR(.exit.text)) { EXIT_TEXT }
> > 
> > However, EXIT_TEXT is thrown away by
> > DISCARD(include/asm-generic/vmlinux.lds.h) because
> > sh does not define RUNTIME_DISCARD_EXIT.
> > 
> > GNU ld 2.40 does not have this issue and builds fine.
> > This corresponds with Masahiro's comments in a494398bde27:
> > "Nathan [Chancellor] also found that binutils
> > commit 21401fc7bf67 ("Duplicate output sections in scripts") cured this
> > issue, so we cannot reproduce it with binutils 2.36+, but it is better
> > to not rely on it."
> > 
> > Fixes: 99cb0d917ffa ("arch: fix broken BuildID for arm64 and riscv")
> > Link: https://lore.kernel.org/all/Y7Jal56f6UBh1abE@dev-arch.thelio-3990X/
> > Link: https://lore.kernel.org/all/20230123194218.47ssfzhrpnv3xfez@oracle.com/
> > Signed-off-by: Tom Saeger <tom.saeger@oracle.com>
> > ---
> >  arch/sh/kernel/vmlinux.lds.S | 1 +
> >  1 file changed, 1 insertion(+)
> 
> No upstream git id?
> 
> :(

No, not yet.  I'll try resending.

--Tom