From:   Jens Axboe <axboe@kernel.dk>
To:     Pavel Begunkov <asml.silence@gmail.com>,
        Dylan Yudaken <dylany@meta.com>
Cc:     io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@fb.com, stable@vger.kernel.org
In-Reply-To: <20230127105911.2420061-1-dylany@meta.com>
References: <20230127105911.2420061-1-dylany@meta.com>
Subject: Re: [PATCH] io_uring: always prep_async for drain requests
Message-Id: <167482716231.273660.4883362917562226118.b4-ty@kernel.dk>
Date:   Fri, 27 Jan 2023 06:46:02 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Fri, 27 Jan 2023 02:59:11 -0800, Dylan Yudaken wrote:
> Drain requests all go through io_drain_req, which has a quick exit in case
> there is nothing pending (ie the drain is not useful). In that case it can
> run the issue the request immediately.
> 
> However for safety it queues it through task work.
> The problem is that in this case the request is run asynchronously, but
> the async work has not been prepared through io_req_prep_async.
> 
> [...]

Applied, thanks!

[1/1] io_uring: always prep_async for drain requests
      commit: ef5c600adb1d985513d2b612cc90403a148ff287

Best regards,
-- 
Jens Axboe