Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0
Mime-Version: 1.0
Message-Id: <44479469-3079-4654-a08b-aeb0e45cb1b4@app.fastmail.com>
In-Reply-To: <CACRpkdZDm2enFM=0AoDre=GmF+NHv+ZX9=9LdZ_KAcUJ5ta64A@mail.gmail.com>
References: <20230127101149.3475929-1-arnd@kernel.org>
 <20230127101149.3475929-7-arnd@kernel.org>
 <CACRpkdZDm2enFM=0AoDre=GmF+NHv+ZX9=9LdZ_KAcUJ5ta64A@mail.gmail.com>
Date:   Fri, 27 Jan 2023 15:07:04 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Linus Walleij" <linus.walleij@linaro.org>,
        "Arnd Bergmann" <arnd@kernel.org>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>,
        "Christophe Leroy" <christophe.leroy@csgroup.eu>,
        "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/7] gpiolib: split linux/gpio/driver.h out of linux/gpio.h
Content-Type: text/plain
Precedence: bulk

On Fri, Jan 27, 2023, at 14:39, Linus Walleij wrote:
> On Fri, Jan 27, 2023 at 11:12 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Almost all gpio drivers include linux/gpio/driver.h, and other
>> files should not rely on includes from this header.
>>
>> Remove the indirect include from here and include the correct
>> headers directly from where they are used.
>>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> As mentioned on v1 you will need two additional patches to
> avoid build errors from the bots, perhaps Bartosz can cherry-pick
> them?

Yes, that would be ideal.

> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/commit/?h=gpiochip-no-driver-h&id=73ca8058a7b2075c993040bdc92b6a82f57d4316
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/commit/?h=gpiochip-no-driver-h&id=89f4f9cc70c686303679e57bdc3ac86507979fe3
>
> (Maybe the Viper cf adapter is deleted in the PXA boardfile removal so
> it's not an issue. The HTE file needs patching through.)
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thanks!

Indeed, the viper support is gone in linux-next, which is why that
change was gone from my series after rebasing. I have the same
HTE file change in my tree that you have, but misclassified it
as an existing bug rather than one caused by my patch. The maintainer
said they would apply my patch directly, but it has not shown
up in linux-next yet.

I agree that for both patches the best way is if Bartosz
applies your version before my series.

    Arnd

[1] https://lore.kernel.org/all/38f2d681-80a8-dc97-e5ed-4886e5e3bf7c@nvidia.com/