Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH 4/4] arm64: dts: meson: add support for BananaPi M2-Pro
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <468aef98-2bd7-03d5-0f83-dc58bc4738e9@linaro.org>
Date:   Fri, 27 Jan 2023 18:26:12 +0400
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic <linux-amlogic@lists.infradead.org>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <A5EFDCC3-AB2F-464A-B5B6-1B1482D7D9A4@gmail.com>
References: <20230127100236.3385154-1-christianshewitt@gmail.com>
 <20230127100236.3385154-5-christianshewitt@gmail.com>
 <a35f7f09-eb19-6cfc-2053-c6b340f10cbd@linaro.org>
 <356B9EBF-B9C4-4CB0-9F83-9E7A62F93F65@gmail.com>
 <468aef98-2bd7-03d5-0f83-dc58bc4738e9@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Precedence: bulk


> On 27 Jan 2023, at 5:01 pm, Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org> wrote:
>=20
> On 27/01/2023 11:19, Christian Hewitt wrote:
>>> It's by default. Did any DTSI disable the sound node?
>>=20
>> No. I=E2=80=99m simply transcribing from the original M5 dts (with =
edits to omit
>> the audio jack bits) and the sound nodes of other Amlogic dts which =
have
>> long included the same.=20
>>=20
>> Q. Do I need to remove it here? (sounds like a yes)
>=20
> Yes

I=E2=80=99ve removed for both dts and sent v2

>> Q. Do we need to exorcise/cleanup the same from all other meson dts?
>=20
> Yes, please.

I=E2=80=99ll put on my to-do list :)

Christian=