Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0FF7C61DA3 for ; Fri, 27 Jan 2023 15:01:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233689AbjA0PBM (ORCPT ); Fri, 27 Jan 2023 10:01:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233427AbjA0PBJ (ORCPT ); Fri, 27 Jan 2023 10:01:09 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6BA77ECA; Fri, 27 Jan 2023 07:01:08 -0800 (PST) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30REi24Q031361; Fri, 27 Jan 2023 15:00:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=VXS2X5drfdkQujhXGlbWe/JnBB0qmbiddFlUZ+R2+KU=; b=DAQUjsihEAH3oYvxEXAK+kG3KIunWFSl0GCAHJZ09jeHkMY4N0wviKMTCjKpT5rJgdW3 xWeiSMeoeQ1U/h85Tf+AMtUCGEcp1PwBzyTNd4gchwlKmkzBzTjWq4+Lav9TtyozZPU4 wk6SAaWrM5MnS640uzX7cf6pKQi3RSClXTyk/QgCXUHygareEqn+Isc88j7ykf0sy1xF a0uVPARYKTmrnpjuHMZjIcAwEX2prheMGhE1iJctXdqR39K3M6rppij9ZXsd8YTbTcAL oqvrdnUeuRJy3WkHjYCIm/dYPBzr7oXzRq/xzD7XtOtNfRn3pDPJFb2vnrUf3KSEHTF2 4g== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nbp1varhj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Jan 2023 15:00:49 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30RF0mIu015203 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Jan 2023 15:00:48 GMT Received: from [10.216.31.125] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 27 Jan 2023 07:00:40 -0800 Message-ID: <659c81b0-b75e-9a6f-bd26-878bb9868397@quicinc.com> Date: Fri, 27 Jan 2023 20:30:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/5] firmware: scm: Modify only the DLOAD bit in TCSR register for download mode Content-Language: en-US To: Guru Das Srinagesh CC: , , , , , , , , , , , , , , , , , , , , , , , , , References: <20230113160012.14893-1-quic_poovendh@quicinc.com> <20230113160012.14893-4-quic_poovendh@quicinc.com> <20230114011606.GA24659@quicinc.com> From: POOVENDHAN SELVARAJ In-Reply-To: <20230114011606.GA24659@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: t3eg6psULoo0zN33VBxDls_iuoXEBlzU X-Proofpoint-GUID: t3eg6psULoo0zN33VBxDls_iuoXEBlzU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-27_09,2023-01-27_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxlogscore=776 mlxscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301270142 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/14/2023 6:46 AM, Guru Das Srinagesh wrote: > On Jan 13 2023 21:30, Poovendhan Selvaraj wrote: >> Add support to read-modify-write TCSR register to modify only DLOAD bit. > Could you please add more details on what problem this patch is fixing, and why > this patch is needed? > > CrashDump collection is based on the DLOAD bit of TCSR register. To retain other bits, we read the register and modify only the DLOAD bit as the other bits have their own significance. > > Thank you. > > Guru Das. > > Regards, > Poovendhan S