Date: Thu, 30 Aug 2007 13:50:59 +0200
To: Matthew Wilcox <matthew@wil.cx>
Cc: andre@finow14.de, kernel-janitors@vger.kernel.org,
       linux-kernel@vger.kernel.org, rmk@arm.linux.org.uk
Subject: Re: [KJ][patch 3/3] VIDC20: use abs() from kernel.h instead of own definition
Message-ID: <20070830115059.GA17168@ahaupt-debian-vm.localdomain>
References: <20070830102551.131398783@finow14.de> <20070830104038.GD14925@ahaupt-debian-vm.localdomain> <20070830111746.GS14130@parisc-linux.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070830111746.GS14130@parisc-linux.org>
User-Agent: Mutt/1.5.13 (2006-08-11)
From: Andre Haupt <andre@finow14.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 711
Lines: 23

On Thu, Aug 30, 2007 at 05:17:47AM -0600, Matthew Wilcox wrote:
> On Thu, Aug 30, 2007 at 12:40:38PM +0200, andre@finow14.de wrote:
> > -		diff_int = my_abs(rate_ext-rate);
> > -		diff_ext = my_abs(rate_int-rate);
> > +		diff_int = abs(rate_ext-rate);
> > +		diff_ext = abs(rate_int-rate);
> 
> Nothing to do with the patch, but is this really correct?  Surely it
> should be diff_ext = abs(rate_ext-rate) ?

hmmh, not sure about this ...

Russell?


regards,

Andre
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/