From:   "Devale, Sindhu" <sindhu.devale@intel.com>
To:     Nikita Zhandarovich <n.zhandarovich@fintech.ru>,
        "Ismail, Mustafa" <mustafa.ismail@intel.com>
CC:     "Saleem, Shiraz" <shiraz.saleem@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: RE: [PATCH] RDMA/irdma: Fix potential NULL-ptr-dereference
Thread-Topic: [PATCH] RDMA/irdma: Fix potential NULL-ptr-dereference
Thread-Index: AQHZMbdt9s3VMA6xBk2Hs2PupjDdx66yZUBg
Date:   Fri, 27 Jan 2023 15:38:58 +0000
Message-ID: <SA2PR11MB49535D7458DA7CADEAFEA24DF3CC9@SA2PR11MB4953.namprd11.prod.outlook.com>
References: <20230126185230.62464-1-n.zhandarovich@fintech.ru>
In-Reply-To: <20230126185230.62464-1-n.zhandarovich@fintech.ru>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b8U75mIu8N/uNt7sUE/FgB/+Pj9xdu/GPnIfLcASx/KwHv3OA3xiHBJee3az?=
 =?us-ascii?Q?5p55odYCrVr3TiCrZv2dAOrNtl4gLWJfLFjVUe5lvwWjZg+VToQy2T3TioV/?=
 =?us-ascii?Q?iVhCdOw7UR4I7A6dEa0bc95SA7kp3KPmYtLpDEOJyXE9bCSVJ4xw8FXofXMQ?=
 =?us-ascii?Q?1HJXzKtu/RlThnawsquYwffhPiHgZTZJivVoV6OISImPJlj6MCGyHTlUnlUh?=
 =?us-ascii?Q?/loQds0helcfaI9UTPYladNKKblQHQO00bc88G5OKP6K67oZZoWcUyi4X2y8?=
 =?us-ascii?Q?dAjxtXOWj4bxiTI7+z5Ey8chtrzflxN6mWWCzrg1t5X6rac/jkL4dff+u6dn?=
 =?us-ascii?Q?bGz9BdtzAFfQSXc9JeYImHFO2kBSpuiUW1jBbHBjwB2UYx0Tn5VrhPto5gIJ?=
 =?us-ascii?Q?5NKBfvyVKISiUgmO/c6Ovdns2INh2pSl0yV25u/YmYxHOdhVsorfIhaqHCio?=
 =?us-ascii?Q?vOdav46HPsv9tGOcm//KnyOeBdLxDG9hEU8ZXiJMdQmDkbn38NJhR5+D/F7G?=
 =?us-ascii?Q?sbjzEfIt+8ay1wCQaxhGME/4V9XsicttC3qF7iF4fezVYZv3d3SSk3mdgeQJ?=
 =?us-ascii?Q?ywPW7bV8MkRgLZ21+k+hzkUlGKvT+K+jp28Dty82jBZ2MUoQQ2zNtnF8aiXd?=
 =?us-ascii?Q?q2HIruDuDVH6DlG0bF+GeIOlKkVroeDFCzSAxVWsJlbqT6gcd/V+n9z4qpp8?=
 =?us-ascii?Q?OkfXcpU+SEPkfCDWnrjZEjnCUFY6hlFPpsp2RT0rvu/J7zuaZZeS8saX9ZTo?=
 =?us-ascii?Q?S5oBL2YlTKMaLCN4IIDrartYEk9UQ65+sPUc/SdcCkteKl6dnoxOKfXZVRAe?=
 =?us-ascii?Q?C3e+1f8WDjcJpY/kil6amX2aaPAbx+st9cFGDK2sMUbNs6bJNIgG8j3CCELq?=
 =?us-ascii?Q?YmKeCBHcHdkEY27cHUPjh9TQ4qHD6VRoluBFb8QOVTJcK5FSoOD3fNKe5apD?=
 =?us-ascii?Q?fGQx3Zvj338zB/zvX9jhRaF7e4L0QHzz+HEo1u3aEAKCgrEjIEtmA+V6/UWB?=
 =?us-ascii?Q?MX+3Y+7CWa69DBLbOP1crXXNLrXLl7IGCGTrVf4bBTPimMmqX/vYLCEMNIQ0?=
 =?us-ascii?Q?VY7GkLvQbWn9PRfwgfwR/Gr6J4ph8Zl8NF2GVA4hjDBsdIbG6uMeKa88/OeA?=
 =?us-ascii?Q?otU76+Qy/stbCxDlnSHasLm3goWRflDGJ1lrmcfmOYe4cgtvehKbPqP/4GoF?=
 =?us-ascii?Q?eNa+pGFwpDtW+DjSbgFr5Vr92idFsItF4cKnhnfaV1l1MlNx72jtbSheUhzf?=
 =?us-ascii?Q?SfHdPeCB64uvTnwyGc2y5aIqg+znwudGmBNKxRZx9DZYO8+v+EnnhmsOy6mB?=
 =?us-ascii?Q?CaVg78O9aHCqXREZNSnS4ybFqIMXDrDEoNtb511c6O/RrIZ42egnlPK5Nf2R?=
 =?us-ascii?Q?cQmhqVjK0ybHzk5km2G4BJTB7/chljS6JzY3sgAryE3TiQJ3/y+txPYJj54P?=
 =?us-ascii?Q?QO6seIbw4gSWzR+Fk4vc5w4Yh443U3xDwt+uY0IveKxvolxzvP58Ck0eABBa?=
 =?us-ascii?Q?372BBbjfWTg2mm/GYoRldelshDXsmaqzQcAT+AtQwXxUOZD9mW6bmA/T+lr6?=
 =?us-ascii?Q?YIv+3uBSkQdjxi2Q0yVz/0gmjhHMDRmNjo3dM8WD?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4953.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9af9c6c1-19c9-4273-1fd8-08db007c9b51
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2023 15:38:58.4474
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zJFcg0KQwDrcC/Jw6nSBxABhG+eRd0JfciwKS0v4zvV3H2sQPaUAsNmwawCkeF4rXyMFjBF8MPPA6gbMxUJ4yg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7106
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
> Sent: Thursday, January 26, 2023 12:53 PM
> To: Ismail, Mustafa <mustafa.ismail@intel.com>
> Cc: Nikita Zhandarovich <n.zhandarovich@fintech.ru>; Saleem, Shiraz
> <shiraz.saleem@intel.com>; Jason Gunthorpe <jgg@ziepe.ca>; Leon
> Romanovsky <leon@kernel.org>; linux-rdma@vger.kernel.org; linux-
> kernel@vger.kernel.org; lvc-project@linuxtesting.org
> Subject: [PATCH] RDMA/irdma: Fix potential NULL-ptr-dereference
>=20
> in_dev_get() can return NULL which will cause a failure once idev is
> dereferenced in in_dev_for_each_ifa_rtnl(). This patch adds a check for
> NULL value in idev beforehand.
>=20
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>=20
> Fixes: 146b9756f14c ("RDMA/irdma: Add connection manager")
> Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
>=20
>  drivers/infiniband/hw/irdma/cm.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/infiniband/hw/irdma/cm.c
> b/drivers/infiniband/hw/irdma/cm.c
> index 7b086fe63a24..195aa9ea18b6 100644
> --- a/drivers/infiniband/hw/irdma/cm.c
> +++ b/drivers/infiniband/hw/irdma/cm.c
> @@ -1722,6 +1722,9 @@ static int irdma_add_mqh_4(struct irdma_device
> *iwdev,
>  			continue;
>=20
>  		idev =3D in_dev_get(ip_dev);
> +		if (!idev)
> +			continue;
> +
>  		in_dev_for_each_ifa_rtnl(ifa, idev) {
>  			ibdev_dbg(&iwdev->ibdev,
>  				  "CM: Allocating child CM Listener
> forIP=3D%pI4, vlan_id=3D%d, MAC=3D%pM\n",

Change looks good. Thanks!

Reviewed-by: Sindhu Devale <sindhu.devale@intel.com>