Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758824AbXH3MdW (ORCPT ); Thu, 30 Aug 2007 08:33:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755906AbXH3MdO (ORCPT ); Thu, 30 Aug 2007 08:33:14 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:34218 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755858AbXH3MdN (ORCPT ); Thu, 30 Aug 2007 08:33:13 -0400 Date: Thu, 30 Aug 2007 13:22:37 +0100 From: Russell King To: Andre Haupt Cc: Matthew Wilcox , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [KJ][patch 3/3] VIDC20: use abs() from kernel.h instead of own definition Message-ID: <20070830122237.GE10088@flint.arm.linux.org.uk> References: <20070830102551.131398783@finow14.de> <20070830104038.GD14925@ahaupt-debian-vm.localdomain> <20070830111746.GS14130@parisc-linux.org> <20070830115059.GA17168@ahaupt-debian-vm.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070830115059.GA17168@ahaupt-debian-vm.localdomain> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1095 Lines: 28 On Thu, Aug 30, 2007 at 01:50:59PM +0200, Andre Haupt wrote: > On Thu, Aug 30, 2007 at 05:17:47AM -0600, Matthew Wilcox wrote: > > On Thu, Aug 30, 2007 at 12:40:38PM +0200, andre@finow14.de wrote: > > > - diff_int = my_abs(rate_ext-rate); > > > - diff_ext = my_abs(rate_int-rate); > > > + diff_int = abs(rate_ext-rate); > > > + diff_ext = abs(rate_int-rate); > > > > Nothing to do with the patch, but is this really correct? Surely it > > should be diff_ext = abs(rate_ext-rate) ? > > hmmh, not sure about this ... No idea. The support for external clocking came from someone else (I was never able to work it out myself). I can only assume that the code as it stands does work. So let's remain bug-compatible until there's a proven problem. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/