Message-ID: <fd8f34fa-77d1-98c4-64f3-cc5ffeb7bd0e@quicinc.com>
Date:   Fri, 27 Jan 2023 21:15:02 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 5/6] dt-bindings: mailbox: Add compatible for IPQ9574
Content-Language: en-US
To:     Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
        <andersson@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <mturquette@baylibre.com>,
        <sboyd@kernel.org>, <jassisinghbrar@gmail.com>,
        <catalin.marinas@arm.com>, <will@kernel.org>,
        <shawnguo@kernel.org>, <arnd@arndb.de>,
        <marcel.ziswiler@toradex.com>, <dmitry.baryshkov@linaro.org>,
        <nfraprado@collabora.com>, <broonie@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
CC:     <quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
        <quic_sjaganat@quicinc.com>, <quic_kathirav@quicinc.com>,
        <quic_arajkuma@quicinc.com>, <quic_anusha@quicinc.com>,
        <quic_poovendh@quicinc.com>
References: <20230113143647.14961-1-quic_devipriy@quicinc.com>
 <20230113143647.14961-6-quic_devipriy@quicinc.com>
 <83718846-1c51-d102-d11a-a14860be8454@linaro.org>
From:   Devi Priya <quic_devipriy@quicinc.com>
In-Reply-To: <83718846-1c51-d102-d11a-a14860be8454@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/13/2023 8:43 PM, Konrad Dybcio wrote:
> 
> 
> On 13.01.2023 15:36, devi priya wrote:
>> Add the mailbox compatible string for IPQ9574 SoC
>>
>> Co-developed-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>> Signed-off-by: devi priya <quic_devipriy@quicinc.com>
>> ---
> Binding changes should come before driver changes, so that
> you're not introducing an "illegal" compatible and only
> "legalize" it later - please reorder the patch.
> 
> Konrad
Understood, will reorder the patches in V2
>>   .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml     | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> index 943f9472ae10..9e076758a58a 100644
>> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> @@ -20,6 +20,7 @@ properties:
>>             - enum:
>>                 - qcom,ipq6018-apcs-apps-global
>>                 - qcom,ipq8074-apcs-apps-global
>> +              - qcom,ipq9574-apcs-apps-global
>>                 - qcom,msm8976-apcs-kpss-global
>>                 - qcom,msm8996-apcs-hmss-global
>>                 - qcom,msm8998-apcs-hmss-global
>> @@ -113,6 +114,7 @@ allOf:
>>             enum:
>>               - qcom,ipq6018-apcs-apps-global
>>               - qcom,ipq8074-apcs-apps-global
>> +            - qcom,ipq9574-apcs-apps-global
>>       then:
>>         properties:
>>           clocks:
>> @@ -129,6 +131,7 @@ allOf:
>>             enum:
>>               - qcom,ipq6018-apcs-apps-global
>>               - qcom,ipq8074-apcs-apps-global
>> +            - qcom,ipq9574-apcs-apps-global
>>       then:
>>         properties:
>>           '#clock-cells':
Best Regards,
Devi Priya