Date:   Fri, 27 Jan 2023 11:16:49 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Alison Schofield <alison.schofield@intel.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     Ira Weiny <ira.weiny@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re:
Message-ID: <63d423218e854_3a36e5294fd@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.1674070170.git.alison.schofield@intel.com>
 <63d32fe783ee2_ea2222949f@dwillia2-xfh.jf.intel.com.notmuch>
 <Y9P3ipL28W7N1bLm@aschofie-mobl2>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y9P3ipL28W7N1bLm@aschofie-mobl2>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?B3ibo1qVYS79091GjyFex0R8DhjxCair9DETpKNMTZXkgdmWSvCn6BVDGSRv?=
 =?us-ascii?Q?YajtpOGcP8pJNCFLcBJzaCUiHa7UFmwwMDYLXG3HEts9nDTCF4V836S8lMHE?=
 =?us-ascii?Q?Vk7xa/DSgq5hyhEykjvkAsGcsSXH+iubEdnc4Wp+iCByUMfjl9tw1OyVkX5m?=
 =?us-ascii?Q?mD3rSdnbjnHaZyhBcqO/eOWj0Tjx1WNJwsTEyKBnGyA8PaFJqBChdxdS+pwc?=
 =?us-ascii?Q?dA4CSen1y5YIx/jETZec3H08GsFbfHQaIE/5HUMwaZ4qbR3UeHqq0xkfcyjy?=
 =?us-ascii?Q?s+h6hBc9wRmJD3YBF/OwO8NqQh2JXtTJpGnq3vJPLW/P1oAy9ZJmR4qdj5WN?=
 =?us-ascii?Q?pYZmzS7lyYl4xCFeSEwzIn4jb6y5tx4mvl3i/iKdSF4QlM4mIo5cbPOlzWPd?=
 =?us-ascii?Q?OiOsk7WcAFqA0kONuRC08uyA+OViqtVMzZKK1HUKsF4Uuld5BS0VOTLenMCj?=
 =?us-ascii?Q?if9gzWWyUugroQr2yLtNTY/SCJr9Yx/l4+h0YOIUIxZP3XYtz92fEFYfudtR?=
 =?us-ascii?Q?kFtJlf8oUi85dZlD9Jt5RE/M04ITcdR0VubqmvUNwW0HpBg+s/XJu1Cc2wmR?=
 =?us-ascii?Q?j6UQmszOPUA4roixxpc3bdekGoYMW+g6Hi7Zf+R9GksYPWB97gnTakWZ07Zm?=
 =?us-ascii?Q?v1CuT0JqJ2ix8pp9fftT8Uy1YIblpSbj3KxxLGa3AdM8BIXusZXhOtWYiCYL?=
 =?us-ascii?Q?cz4ROwicY6JTENQKm/S3RpDjNH7TVubAexyhPQU/whWCSRRxjaqwIcEMo4R5?=
 =?us-ascii?Q?EvQUv+iW+zsWQkohgrD1SjJZOcHLDrUWz8R2soBY/WBInXnqypud1lFIexIG?=
 =?us-ascii?Q?6kpklb8vHW6kEvh/Up9E+iP0tmZAMWi0vC/q0ydSTthnZ5JniWXmORmR84CK?=
 =?us-ascii?Q?nyTk6z1Nt81VDtlMcbhO9Ag/oeq5mb94foPwGwRP9qBTg3vvze4rNDhunWjk?=
 =?us-ascii?Q?rxBHBEdvQkTh5jIfi/IJG3T20cx8IDTEqNQJ4KW8t+23R6VpP0ZdDRdH99DA?=
 =?us-ascii?Q?KHIc+fisiPuvgl7wWT//43126JET+yKS/b48MxMTJ/XkgXgHQj+wzubl6g/w?=
 =?us-ascii?Q?p+FxkxMXcbNSczRiUG5yL4IwgxPJk8XDCtkDfphS7bYJdzvojZMwjXdX/jE2?=
 =?us-ascii?Q?XH+7d1bG/1G2ZH3urd5HH4HNneiwSuh/iciPCsuKO1WcFgLh8a6GeaIMXH2m?=
 =?us-ascii?Q?81kKl3wbYFI9AnSns9XN57fOXUJCj8F+SLLx5RiB/qfT5JOo4kHfFwq7CcrU?=
 =?us-ascii?Q?USq3fFxInjaMRdOfXe5ew6kIyj1EhTlhoY3B5gWYyloTDHbNDU+sxkdzC65b?=
 =?us-ascii?Q?pyOPdPgs10eK3orFrvk/5DkquH36UOY9P6TZcBXjWCcQnLFXoIHcfd1og1tO?=
 =?us-ascii?Q?lZOcgK34ngukTU2fIpDbLYADkKHoOO9QEV0i3dleAsQvPCegq6QFNpP44ZQ7?=
 =?us-ascii?Q?wE8ITRe5B/WSytRLLwAdBtbFXaI3CL/cOHZyGjl8NkTyvV/9QK6D/Ir5RN7r?=
 =?us-ascii?Q?0cBbtSlF4bDnYYypJgPpOicNEF6RxR0GC+R6hm0VYxENQgeqUmqPz7iCgVnA?=
 =?us-ascii?Q?Lkyd/0B/teQZ//ehog2Q6HJT9uJBHbHN+UkacYwX0nAblLImyG4P5g/K2dix?=
 =?us-ascii?Q?Zg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d890e6c5-0be9-4193-5355-08db009b0b89
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 19:16:51.8256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tqucZS1S1lpls6/jB7dCLiC5Es5xq/EsRFgyeesCtu5hgrTrW9Sf7rzR0dh2SZhKNX81NvGpt6aDYKDQ2eOO6we9CKhwhXPku+lO9n+t4kA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5895
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Alison Schofield wrote:
> On Thu, Jan 26, 2023 at 05:59:03PM -0800, Dan Williams wrote:
> > alison.schofield@ wrote:
> > > From: Alison Schofield <alison.schofield@intel.com>
> > > 
> > > Subject: [PATCH v5 0/5] CXL Poison List Retrieval & Tracing
> > > 
> > > Changes in v5:
> > > - Rebase on cxl/next 
> > > - Use struct_size() to calc mbox cmd payload .min_out
> > > - s/INTERNAL/INJECTED mocked poison record source
> > > - Added Jonathan Reviewed-by tag on Patch 3
> > > 
> > > Link to v4:
> > > https://lore.kernel.org/linux-cxl/cover.1671135967.git.alison.schofield@intel.com/
> > > 
> > > Add support for retrieving device poison lists and store the returned
> > > error records as kernel trace events.
> > > 
> > > The handling of the poison list is guided by the CXL 3.0 Specification
> > > Section 8.2.9.8.4.1. [1] 
> > > 
> > > Example, triggered by memdev:
> > > $ echo 1 > /sys/bus/cxl/devices/mem3/trigger_poison_list
> > > cxl_poison: memdev=mem3 pcidev=cxl_mem.3 region= region_uuid=00000000-0000-0000-0000-000000000000 dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> > 
> > I think the pcidev= field wants to be called something like "host" or
> > "parent", because there is no strict requirement that a 'struct
> > cxl_memdev' is related to a 'struct pci_dev'. In fact in that example
> > "cxl_mem.3" is a 'struct platform_device'. Now that I think about it, I
> > think all CXL device events should be emitting the PCIe serial number
> > for the memdev.
> ]
> 
> Will do, 'host' and add PCIe serial no.
> 
> > 
> > I will look in the implementation, but do region= and region_uuid= get
> > populated when mem3 is a member of the region?
> 
> Not always.
> In the case above, where the trigger was by memdev, no.
> Region= and region_uuid= (and in the follow-on patch, hpa=) only get
> populated if the poison was triggered by region, like the case below.
> 
> It could be looked up for the by memdev cases. Is that wanted?

Just trying to understand the semantics. However, I do think it makes sense
for a memdev trigger to lookup information on all impacted regions
across all of the device's DPA and the region trigger makes sense to
lookup all memdevs, but bounded by the DPA that contributes to that
region. I just want to avoid someone having to trigger the region to get
extra information that was readily available from a memdev listing.

> 
> Thanks for the reviews Dan!
> > 
> > > 
> > > Example, triggered by region:
> > > $ echo 1 > /sys/bus/cxl/devices/region5/trigger_poison_list
> > > cxl_poison: memdev=mem0 pcidev=cxl_mem.0 region=region5 region_uuid=bfcb7a29-890e-4a41-8236-fe22221fc75c dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> > > cxl_poison: memdev=mem1 pcidev=cxl_mem.1 region=region5 region_uuid=bfcb7a29-890e-4a41-8236-fe22221fc75c dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> > > 
> > > [1]: https://www.computeexpresslink.org/download-the-specification
> > > 
> > > Alison Schofield (5):
> > >   cxl/mbox: Add GET_POISON_LIST mailbox command
> > >   cxl/trace: Add TRACE support for CXL media-error records
> > >   cxl/memdev: Add trigger_poison_list sysfs attribute
> > >   cxl/region: Add trigger_poison_list sysfs attribute
> > >   tools/testing/cxl: Mock support for Get Poison List
> > > 
> > >  Documentation/ABI/testing/sysfs-bus-cxl | 28 +++++++++
> > >  drivers/cxl/core/mbox.c                 | 78 +++++++++++++++++++++++
> > >  drivers/cxl/core/memdev.c               | 45 ++++++++++++++
> > >  drivers/cxl/core/region.c               | 33 ++++++++++
> > >  drivers/cxl/core/trace.h                | 83 +++++++++++++++++++++++++
> > >  drivers/cxl/cxlmem.h                    | 69 +++++++++++++++++++-
> > >  drivers/cxl/pci.c                       |  4 ++
> > >  tools/testing/cxl/test/mem.c            | 42 +++++++++++++
> > >  8 files changed, 381 insertions(+), 1 deletion(-)
> > > 
> > > 
> > > base-commit: 589c3357370a596ef7c99c00baca8ac799fce531
> > > -- 
> > > 2.37.3
> > > 
> > 
> >