Message-ID: <91341053a892fa3ac5e7f5b719ad870a.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230126230319.3977109-8-dmitry.baryshkov@linaro.org>
References: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> <20230126230319.3977109-8-dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v5 7/7] clk: qcom: add the driver for the MSM8996 APCS clocks
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Taniya Das <quic_tdas@quicinc.com>
Date:   Fri, 27 Jan 2023 13:04:03 -0800
User-Agent: alot/0.10
Precedence: bulk

Quoting Dmitry Baryshkov (2023-01-26 15:03:19)
> diff --git a/drivers/clk/qcom/apcs-msm8996.c b/drivers/clk/qcom/apcs-msm8=
996.c
> new file mode 100644
> index 000000000000..48d22572b6ae
> --- /dev/null
> +++ b/drivers/clk/qcom/apcs-msm8996.c
> @@ -0,0 +1,88 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Qualcomm APCS clock controller driver
> + *
[...]
> +
> +       /*
> +        * This clock is used during CPU cluster setup while setting up C=
PU PLLs.
> +        * Add hardware mandated delay to make sure that the sys_apcs_aux=
 clock
> +        * is stable (after setting the divider) before continuing
> +        * bootstrapping to keep CPUs from ending up in a weird state.
> +        */
> +       udelay(5);
> +
> +       /*
> +        * As this clocks is a parent of the CPU cluster clocks and is ac=
tually
> +        * used as a parent during CPU clocks setup, we want for it to ge=
gister

s/gegister/register/

> +        * as early as possible, without letting fw_devlink to delay prob=
ing of
> +        * either of the drivers.

Ok, good to know fw_devlink is the problem in this case.

> +        *
> +        * The sys_apcs_aux is a child (divider) of gpll0, but we registe=
r it
> +        * as a fixed rate clock instead to ease bootstrapping procedure.=
 By
> +        * doing this we make sure that CPU cluster clocks are able to be=
 setup
> +        * early during the boot process (as it is recommended by Qualcom=
m).
> +        */
> +       hw =3D devm_clk_hw_register_fixed_rate(dev, "sys_apcs_aux", NULL,=
 0, 300000000);
> +       if (IS_ERR(hw))
> +               return PTR_ERR(hw);
> +