MIME-Version: 1.0
References: <20230124230254.295589-1-isaacmanjarres@google.com> <167485548359.726924.14589412750691974893.robh@kernel.org>
In-Reply-To: <167485548359.726924.14589412750691974893.robh@kernel.org>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Fri, 27 Jan 2023 15:40:03 -0600
Message-ID: <CAL_JsqKdHiZ0q8TkfjW6SUYg-_p4PxcGfA6SV0Q3Dif_dSY75Q@mail.gmail.com>
Subject: Re: [PATCH v1] Revert "mm: kmemleak: alloc gray object for reserved
 region with direct map"
To:     "Isaac J. Manjarres" <isaacmanjarres@google.com>
Cc:     Frank Rowand <frowand.list@gmail.com>, stable@vger.kernel.org,
        Saravana Kannan <saravanak@google.com>,
        devicetree@vger.kernel.org,
        Calvin Zhang <calvinzhang.cool@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        kernel-team@android.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 27, 2023 at 3:38 PM Rob Herring <robh@kernel.org> wrote:
>
>
> On Tue, 24 Jan 2023 15:02:54 -0800, Isaac J. Manjarres wrote:
> > This reverts commit 972fa3a7c17c9d60212e32ecc0205dc585b1e769.
> >
> > Kmemleak operates by periodically scanning memory regions for pointers
> > to allocated memory blocks to determine if they are leaked or not.
> > However, reserved memory regions can be used for DMA transactions
> > between a device and a CPU, and thus, wouldn't contain pointers to
> > allocated memory blocks, making them inappropriate for kmemleak to
> > scan. Thus, revert this commit.
> >
> > Cc: stable@vger.kernel.org # 5.17+
> > Cc: Calvin Zhang <calvinzhang.cool@gmail.com>
> > Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
> > ---
> >  drivers/of/fdt.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
>
> Applied, thanks!

Or not. Andrew already applied it.

Rob