Message-ID: <5e2a7c3e-b2cc-746f-81b1-13adfddf1c62@samsung.com>
Date:   Fri, 27 Jan 2023 23:01:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0)
        Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [RFT PATCH v3 1/4] ARM: dts: exynos: add unit address to DWC3
 node wrapper in Exynos5250
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     replicant@osuosl.org, phone-devel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht,
        =?UTF-8?Q?Martin_J=c3=bccker?= <martin.juecker@gmail.com>,
        Henrik Grimler <henrik@grimler.se>,
        Sam Protsenko <semen.protsenko@linaro.org>,
        Chanho Park <chanho61.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
From:   Marek Szyprowski <m.szyprowski@samsung.com>
In-Reply-To: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20230127212728eucas1p124a7a0cdd785cfc7edd53b7a6fe1a2d0@eucas1p1.samsung.com>
        <20230127212713.267014-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk

On 27.01.2023 22:27, Krzysztof Kozlowski wrote:
> Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
> which do not have unit address.  Therefore usethe address space
> of child device (actual DWC3 Controller) as the wrapper's address to
> fix:
>
>    exynos5250-smdk5250.dtb: soc: usb3: {'compatible': ['samsung,exynos5250-dwusb3'],
>      ... } should not be valid under {'type': 'object'}
>
>    exynos5250.dtsi:638.16-653.5: Warning (simple_bus_reg): /soc/usb3: missing or empty reg/ranges property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>
> Changes since v1:
> 1. Use ranges with values and drop reg from usb-wrapper node.
> 2. Keep "usb" as wrapper's node name.
> ---
>   arch/arm/boot/dts/exynos5250.dtsi | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 97e89859ba3d..a5db4ac213d5 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -635,17 +635,17 @@ i2s2: i2s@12d70000 {
>   			#sound-dai-cells = <1>;
>   		};
>   
> -		usbdrd: usb3 {
> +		usbdrd: usb@12000000 {
>   			compatible = "samsung,exynos5250-dwusb3";
>   			clocks = <&clock CLK_USB3>;
>   			clock-names = "usbdrd30";
>   			#address-cells = <1>;
>   			#size-cells = <1>;
> -			ranges;
> +			ranges = <0x0 0x12000000 0x10000>;
>   
> -			usbdrd_dwc3: usb@12000000 {
> +			usbdrd_dwc3: usb@0 {
>   				compatible = "snps,dwc3";
> -				reg = <0x12000000 0x10000>;
> +				reg = <0x0 0x10000>;
>   				interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
>   				phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>;
>   				phy-names = "usb2-phy", "usb3-phy";

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland