Message-ID: <c2094a98-1a99-14c6-40a6-0c671a6035db@samsung.com>
Date:   Fri, 27 Jan 2023 23:02:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0)
        Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [RFT PATCH v3 3/4] arm64: dts: exynos: add unit address to DWC3
 node wrapper in Exynos5433
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     replicant@osuosl.org, phone-devel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht,
        =?UTF-8?Q?Martin_J=c3=bccker?= <martin.juecker@gmail.com>,
        Henrik Grimler <henrik@grimler.se>,
        Sam Protsenko <semen.protsenko@linaro.org>,
        Chanho Park <chanho61.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
From:   Marek Szyprowski <m.szyprowski@samsung.com>
In-Reply-To: <20230127212713.267014-3-krzysztof.kozlowski@linaro.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org>
        <CGME20230127212730eucas1p1c7553326fe55355c303e2b79480f6a12@eucas1p1.samsung.com>
        <20230127212713.267014-3-krzysztof.kozlowski@linaro.org>
Precedence: bulk

On 27.01.2023 22:27, Krzysztof Kozlowski wrote:
> Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
> which do not have unit address.  Therefore usethe address space
> of child device (actual DWC3 Controller) as the wrapper's address to
> fix:
>
>    exynos5433-tm2e.dtb: soc@0: usbdrd: {'compatible': ['samsung,exynos5433-dwusb3'], ...
>      should not be valid under {'type': 'object'}
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>
> Changes since v2:
> 1. Fix typo/build error.
>
> Changes since v1:
> 1. New patch
> ---
>   arch/arm64/boot/dts/exynos/exynos5433.dtsi | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 9da24fe958a3..5519a80576c5 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1742,7 +1742,7 @@ hsi2c_11: i2c@14df0000 {
>   			status = "disabled";
>   		};
>   
> -		usbdrd30: usbdrd {
> +		usbdrd30: usb@15400000 {
>   			compatible = "samsung,exynos5433-dwusb3";
>   			clocks = <&cmu_fsys CLK_ACLK_USBDRD30>,
>   				<&cmu_fsys CLK_SCLK_USBDRD30>,
> @@ -1751,16 +1751,16 @@ usbdrd30: usbdrd {
>   			clock-names = "aclk", "susp_clk", "phyclk", "pipe_pclk";
>   			#address-cells = <1>;
>   			#size-cells = <1>;
> -			ranges;
> +			ranges = <0x0 0x15400000 0x10000>;
>   			status = "disabled";
>   
> -			usbdrd_dwc3: usb@15400000 {
> +			usbdrd_dwc3: usb@0 {
>   				compatible = "snps,dwc3";
>   				clocks = <&cmu_fsys CLK_SCLK_USBDRD30>,
>   					<&cmu_fsys CLK_ACLK_USBDRD30>,
>   					<&cmu_fsys CLK_SCLK_USBDRD30>;
>   				clock-names = "ref", "bus_early", "suspend";
> -				reg = <0x15400000 0x10000>;
> +				reg = <0x0 0x10000>;
>   				interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_HIGH>;
>   				phys = <&usbdrd30_phy 0>, <&usbdrd30_phy 1>;
>   				phy-names = "usb2-phy", "usb3-phy";
> @@ -1795,7 +1795,7 @@ usbhost30_phy: phy@15580000 {
>   			status = "disabled";
>   		};
>   
> -		usbhost30: usbhost {
> +		usbhost30: usb@15a00000 {
>   			compatible = "samsung,exynos5433-dwusb3";
>   			clocks = <&cmu_fsys CLK_ACLK_USBHOST30>,
>   				<&cmu_fsys CLK_SCLK_USBHOST30>,
> @@ -1804,16 +1804,16 @@ usbhost30: usbhost {
>   			clock-names = "aclk", "susp_clk", "phyclk", "pipe_pclk";
>   			#address-cells = <1>;
>   			#size-cells = <1>;
> -			ranges;
> +			ranges = <0x0 0x15a00000 0x10000>;
>   			status = "disabled";
>   
> -			usbhost_dwc3: usb@15a00000 {
> +			usbhost_dwc3: usb@0 {
>   				compatible = "snps,dwc3";
>   				clocks = <&cmu_fsys CLK_SCLK_USBHOST30>,
>   					<&cmu_fsys CLK_ACLK_USBHOST30>,
>   					<&cmu_fsys CLK_SCLK_USBHOST30>;
>   				clock-names = "ref", "bus_early", "suspend";
> -				reg = <0x15a00000 0x10000>;
> +				reg = <0x0 0x10000>;
>   				interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>;
>   				phys = <&usbhost30_phy 0>, <&usbhost30_phy 1>;
>   				phy-names = "usb2-phy", "usb3-phy";

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland