Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E087C61DA7 for ; Fri, 27 Jan 2023 22:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230516AbjA0Wxt (ORCPT ); Fri, 27 Jan 2023 17:53:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbjA0Wxq (ORCPT ); Fri, 27 Jan 2023 17:53:46 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C397448F for ; Fri, 27 Jan 2023 14:53:36 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id b10so5994047pjo.1 for ; Fri, 27 Jan 2023 14:53:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IV1QL6twj3JbhXkP12EpxrGpBWc/55NNcKUr7Mxc/IE=; b=bt7Qt8azkZwjE0NJyI8sPmgV4yiJByc5P86rPhjdkunG0MmxfGbStzBGdljJs2oU07 hn2hq+STrYhE0og7JZ2V327nYR1cJyX+8bzKYIljMTixoX9lGry2Dc2u/cUVZcMyPedR dQfDs8RdUsGByiUaFCeq6k5Wcg2d6qNOpU4BNqSPvcABnA0WyiibkmV3WZpaSIvPQ4G2 9rhj+b2osuwrYhkkC3t3I0l8bFYMpPhGxUydi81FwoQiwbmmGJfFqmionWukazpm9eX9 KwBnhk3MrCZ+QeByvDpHRJL6P43hK1vAcn1nBY+MynI+gPBJXdIykzSFoxb+BC5jkuh4 33Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IV1QL6twj3JbhXkP12EpxrGpBWc/55NNcKUr7Mxc/IE=; b=trVUrZKEds73cel9mTKy2NqelRESFJvoJR/VJR3eP8Z4pYXLZ4G84T0YWX8qw8tVM1 4jAVwzok6aASd0Bvr0VKYbatpEscTgLIZx9/Tcp4WHY/707pPmAO3S1bwtBdBdkfGq5T G0e+c1YEzQN//tpqy7kdtoEpjlrRJwHdCWZLjd+GKMhwEx5+XzepAVWKyGLb19UqEFJV aN1mq0QZshPQ7T7OtFe7VxazSXi1rfnoviqmvMPVVfpIx2n0r3uQuG4BvYPMKCjt5qms op9ZmmEcjvi9CmVjpRlEUCA05Q2Ja18PawG4I4IJRMemjx6iNaiesQzy55gcD3rqtGli cpzw== X-Gm-Message-State: AFqh2krf8FpEjLu+sfvEeXY+h5XQpAS9xrTo5IWFYIjhr9yax91YNhEr /9zjMK3/IDM5lNvleUjG0DIWxfj7YXdu7osZsCqL X-Google-Smtp-Source: AMrXdXufkx+kARXGM/WQldtmYWplok4guDRE8z7yAssUVY4SPs2oyYPKUpHQdS8QvQhpPla60vomTv3S+RkjSqPlqy4= X-Received: by 2002:a17:90a:5b0c:b0:223:fa07:7bfb with SMTP id o12-20020a17090a5b0c00b00223fa077bfbmr5377808pji.38.1674860016129; Fri, 27 Jan 2023 14:53:36 -0800 (PST) MIME-Version: 1.0 References: <24fbe6cb-ee80-f726-b260-09f394ead764@kernel.dk> In-Reply-To: From: Paul Moore Date: Fri, 27 Jan 2023 17:53:24 -0500 Message-ID: Subject: Re: [PATCH v1 0/2] two suggested iouring op audit updates To: Jens Axboe Cc: Richard Guy Briggs , Linux-Audit Mailing List , LKML , io-uring@vger.kernel.org, Eric Paris , Steve Grubb , Stefan Roesch , Christian Brauner , Pavel Begunkov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2023 at 5:46 PM Jens Axboe wrote: > On 1/27/23 3:38=E2=80=AFPM, Paul Moore wrote: > > On Fri, Jan 27, 2023 at 2:43 PM Jens Axboe wrote: > >> On 1/27/23 12:42=E2=80=AFPM, Paul Moore wrote: > >>> On Fri, Jan 27, 2023 at 12:40 PM Jens Axboe wrote: > >>>> On 1/27/23 10:23=E2=80=AFAM, Richard Guy Briggs wrote: > >>>>> A couple of updates to the iouring ops audit bypass selections sugg= ested in > >>>>> consultation with Steve Grubb. > >>>>> > >>>>> Richard Guy Briggs (2): > >>>>> io_uring,audit: audit IORING_OP_FADVISE but not IORING_OP_MADVISE > >>>>> io_uring,audit: do not log IORING_OP_*GETXATTR > >>>>> > >>>>> io_uring/opdef.c | 4 +++- > >>>>> 1 file changed, 3 insertions(+), 1 deletion(-) > >>>> > >>>> Look fine to me - we should probably add stable to both of them, jus= t > >>>> to keep things consistent across releases. I can queue them up for 6= .3. > >>> > >>> Please hold off until I've had a chance to look them over ... > >> > >> I haven't taken anything yet, for things like this I always let it > >> simmer until people have had a chance to do so. > > > > Thanks. FWIW, that sounds very reasonable to me, but I've seen lots > > of different behaviors across subsystems and wanted to make sure we > > were on the same page. > > Sounds fair. BTW, can we stop CC'ing closed lists on patch > submissions? Getting these: > > Your message to Linux-audit awaits moderator approval > > on every reply is really annoying. We kinda need audit related stuff on the linux-audit list, that's our mailing list for audit stuff. However, I agree that it is crap that the linux-audit list is moderated, but unfortunately that isn't something I control (I haven't worked for RH in years, and even then the list owner was really weird about managing the list). Occasionally I grumble about moving the kernel audit development to a linux-audit list on vger but haven't bothered yet, perhaps this is as good a reason as any. Richard, Steve - any chance of opening the linux-audit list? --=20 paul-moore.com