Date:   Fri, 27 Jan 2023 14:53:43 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Ira Weiny <ira.weiny@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
CC:     "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        <stable@vger.kernel.org>
Subject: Re: [PATCH] highmem: Round down the address passed to
 kunmap_flush_on_unmap()
Message-ID: <63d455f796cb0_7f63c294b3@iweiny-mobl.notmuch>
References: <20230126200727.1680362-1-willy@infradead.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230126200727.1680362-1-willy@infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2mXMNR8WGKa4SQuKZkVDKydWhFB1DihbshxfLgcj9GEXWND6d0gGM4FCBi4x?=
 =?us-ascii?Q?FSSfINsjECNckaYEPB6UoBiFbwcMiq+FTUapgvNNaHFYGJBY+vqOtmdUQOY2?=
 =?us-ascii?Q?uEA63BvwGVAnw3oFxM69iplAP66VTiDngdPyPaswkYRk/F4YIP4LHU+hc8Z2?=
 =?us-ascii?Q?wgEeGgT1a8DbbrIaD50dkCa/QLX+00RmICs+N6a/kBLeumEUfvS8AliBHrbv?=
 =?us-ascii?Q?xzr2UFGKKr/pUFmxXxb+ssGg0Q5ygNV4MZ+l0odraTVZQ4UxR6lk8QHqd8vo?=
 =?us-ascii?Q?LijmRe1yes0l4XvwsJXLLKXUNY1wyI0feoJZgRda0jBjbbmA684a2w1ClB02?=
 =?us-ascii?Q?QoS7pYvPfksRJcObusNcUgOUkLV9DGoDm/xLaw3AxmTPYS7M4iCWeyWPN2Dz?=
 =?us-ascii?Q?9zI0ao6ENyL4PuA6cC4c+agZK0Ywoq/Gxy5kc8mXnkmNaymdRkNJdHxSKLPi?=
 =?us-ascii?Q?qVCBO33m4egH/MTJsrRW/pLnnwkNHVAWAiRuZ33YB/g5iz0fOEO2fVKylE8u?=
 =?us-ascii?Q?OZ9VfSWNnSGoDnL6KVnBD5ROMv0ik18DqSlaLFRvGSFw4VkhGDB4GfqIo1t0?=
 =?us-ascii?Q?xeXqq/CI8L0SGec1fSFVcsUuHEkBWkHJODJk7P0o8NxrkOovbBx213PtAcGo?=
 =?us-ascii?Q?G1XolhVR9jNFWNC2TKQUa7aNItxR+2LNjqiNA5lAz568GAdzG3oAsbXesQ9/?=
 =?us-ascii?Q?gWI7IzLYZ+CscPk5874vHECntiPZ9lA05kgJbS222+mzYbb7NFKNGb4Ofq0N?=
 =?us-ascii?Q?9rPQ0CA14WW+bAdBobGiIn+dbiarChc5N/VxI2Grn/Heq8l/eGu60L1crPyt?=
 =?us-ascii?Q?+XeyIIAZ3HFj29zq/oRtHvdmggOM6v7OxLOuvP79Ekw8fCqJmRdStMthMxMf?=
 =?us-ascii?Q?/3E25Z0mEORtNZMkrKDD8Pv80ZO+iwRXKHkPbQKZvqBR8P5zMu4ddVYSyM5r?=
 =?us-ascii?Q?S6uGNtkd9e2NjGDHJKBJnNz9goIR8RDhxl3O/L9rrq+lNim5g45D0XElFN5G?=
 =?us-ascii?Q?I4gG5xH/18+leYES8tI9owjInPw+FdqSnI3PseuqXm91qRcAktNA8Zy1NrXJ?=
 =?us-ascii?Q?tiyi9+PQjClBcaMGOa0AT58oW/u+o5P/5B7BMRb2Vqw77vs+bmT3rxH9UjAH?=
 =?us-ascii?Q?OHqEY1E1k33vmGNaRIokX+De13kOULUo0g8shyBItOR0WGqBaaxK2p6OK9qy?=
 =?us-ascii?Q?g1JpE59OdIrgn2UGiww49lm28Bl+PyTdYlyiv5TGYMduNEOFeWg5TuZFSptX?=
 =?us-ascii?Q?/rBuzV/06M7IbJUKfOgw2MJAnxmxruda5aYaqlnxM07rcuHejo8nnFoR+34n?=
 =?us-ascii?Q?o8fIlwLl6spG6tvz/SdMq7c124UL8aIiDjDmYEvbFjIaGm6GVShkcTwWUPDl?=
 =?us-ascii?Q?PwY20hv1eHw21K0etC/QXhWjWmqcu3nmzkr5Fp1QaeJoaL1kBtTkejgh1x3z?=
 =?us-ascii?Q?pVZOAaELLk1DkE5eRJtd1UAFJcVKcx6jPFMX3iCqtuQA0LIOevj3GzWCadl8?=
 =?us-ascii?Q?mU7AXg8kZqPwdgEOKDvMmplquoOewien0ho5IIHFfEfdMKyqNwnG1WJ/rrX9?=
 =?us-ascii?Q?rsWxO1TDpw1Z1a9e56h4ORfJHhGJAy0XPDZ8u62i?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c98058f9-384b-4acc-9010-08db00b958a8
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 22:53:46.1948
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mAoVoiODn1K+Hs5FLPguvqnrjnWYZiKYSQGmIecn7/QOHxcW8Vzs93K3JhuuhVSo8EdBwm+YjLE3u9NG/AJk2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4764
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Matthew Wilcox (Oracle) wrote:
> We already round down the address in kunmap_local_indexed() which is
> the other implementation of __kunmap_local().  The only implementation
> of kunmap_flush_on_unmap() is PA-RISC which is expecting a page-aligned
> address.  This may be causing PA-RISC to be flushing the wrong addresses
> currently.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Fixes: 298fa1ad5571 ("highmem: Provide generic variant of kmap_atomic*")
> Cc: stable@vger.kernel.org
> ---
>  include/linux/highmem-internal.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/highmem-internal.h b/include/linux/highmem-internal.h
> index 034b1106d022..e098f38422af 100644
> --- a/include/linux/highmem-internal.h
> +++ b/include/linux/highmem-internal.h
> @@ -200,7 +200,7 @@ static inline void *kmap_local_pfn(unsigned long pfn)
>  static inline void __kunmap_local(const void *addr)
>  {
>  #ifdef ARCH_HAS_FLUSH_ON_KUNMAP
> -	kunmap_flush_on_unmap(addr);
> +	kunmap_flush_on_unmap(PTR_ALIGN_DOWN(addr, PAGE_SIZE));
>  #endif
>  }
>  
> @@ -227,7 +227,7 @@ static inline void *kmap_atomic_pfn(unsigned long pfn)
>  static inline void __kunmap_atomic(const void *addr)
>  {
>  #ifdef ARCH_HAS_FLUSH_ON_KUNMAP
> -	kunmap_flush_on_unmap(addr);
> +	kunmap_flush_on_unmap(PTR_ALIGN_DOWN(addr, PAGE_SIZE));
>  #endif
>  	pagefault_enable();
>  	if (IS_ENABLED(CONFIG_PREEMPT_RT))
> -- 
> 2.35.1
>