Date:   Fri, 27 Jan 2023 15:07:42 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Matthew Wilcox <willy@infradead.org>, Helge Deller <deller@gmx.de>
CC:     Ira Weiny <ira.weiny@intel.com>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Alexander Potapenko <glider@google.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Tony Luck <tony.luck@intel.com>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        David Sterba <dsterba@suse.com>,
        Kees Cook <keescook@chromium.org>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] mm/highmem: Align-down to page the address for
 kunmap_flush_on_unmap()
Message-ID: <63d4593ebc66a_7f63c2942b@iweiny-mobl.notmuch>
References: <20230126143346.12086-1-fmdefrancesco@gmail.com>
 <63d2d97bce4c7_63e3f29442@iweiny-mobl.notmuch>
 <804f9617-cdad-d3cb-f4c0-7d99d12f49d6@gmx.de>
 <Y9LnZ5wS9Sh3pwSH@casper.infradead.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y9LnZ5wS9Sh3pwSH@casper.infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Lc6Ti78J5e+aeZt1wxrWl6I4TflG6AsH+ia5Ebg6E4t9QjiEn4dDanvNF/rp?=
 =?us-ascii?Q?V3iOkws9BaZj5jI7f5Whcoh7OWqpp9glCFBkaXeFzaYDkl8Jb6NVY3JTmuyc?=
 =?us-ascii?Q?bbynJNvsLjBhLqHfYATVXxBv/g/xFsFlqjSEt5xcDaACqmIUMNBp9zS5Rl46?=
 =?us-ascii?Q?Zrpbqmk1m/w95WbQpyMoVV3tEsitb/GF+Yx/w8rUdbE+zUA4gHZAa7LwcK4G?=
 =?us-ascii?Q?Oypk3Qjo7NVX7wdq7+0kPNAK3C3Q2Bg2TiuzKK1r0zF2TQIBQacHAtx/Lbjt?=
 =?us-ascii?Q?F7f8JjObOOgzGWKmeeOdrwdrUIg6izCJzwhP2aABGfjJcsQ4mE0LYCtgrhB8?=
 =?us-ascii?Q?ASNI183AQ0SIkvxUrya2/hwvVzgJs7hV1mSRWAuAA18wyhJMH9IiD0IGL9UR?=
 =?us-ascii?Q?nq7lgq4XRaJHx1rFVrmMvZYm+WE92LcQT56Iq4KkU8H9m42S/VMDy8IBPqO/?=
 =?us-ascii?Q?KOpw/b7nu0JzZJ8T6k7MgWM6glBgRX317jFY9qqBM08DDPUeMKkhEi9+AeUi?=
 =?us-ascii?Q?ceFuxUOxk0ds0f53RhVzJox0ZDBZxX1PFHyNR/CACZgXL2GiSxgBkAtXPsPd?=
 =?us-ascii?Q?Q4PBIafhhR1L+sgoEsLyG4eu0LIfbH6VZwDRd4bs0Hdl1gNhUYw7Um7HF81O?=
 =?us-ascii?Q?XYVjiXOZueNGe2lRZ+taEU3pphIrurk8nqP2DAi2E+7rfiGY7/+mze8WLamJ?=
 =?us-ascii?Q?gfUxoeY2OgHgrpm+K/it35UVePeZeLqbJ/RtLrnzvVpagxbm2Wyb9QoRfbnW?=
 =?us-ascii?Q?+7myYvJ80vLCxGxyADScZ89rCw/ayqJ+IBAqxgzrfrMdDisc0OMgortvua9F?=
 =?us-ascii?Q?UXJeaMgoSiM/tGO0LAmGiKh/j5t+vc373yI7c+zsZ3zqN0IHAssaQGHGRlk/?=
 =?us-ascii?Q?9LgNUzuKOaMxA8YWJ0FvhIZfjvRrBUx0+YIXmvKoCzlBX1ywgja3Ysn0FUst?=
 =?us-ascii?Q?jBRFk8fcrkOI7IM7FntM6Xe8VOIoPbz2XI7J7kMwB15t9fbGd+ConGro4rIW?=
 =?us-ascii?Q?kWDlt6UeMHjtk65z52CqRhn5K/IJicbkYJyy8ON4Vjmdb2wx1+DgdSDtA/Pb?=
 =?us-ascii?Q?zIcg1ygwrBKWzB82XlsTb3lVf/CofdMx551c6b32HQx9i8jgfzzmJ77UAtwz?=
 =?us-ascii?Q?nv0dcxJhYwzmdYtTXps3sqKdn1sSEOsWxIzCgROAQzvcZyPbXsF9XKLx4fkA?=
 =?us-ascii?Q?vsRsLwAyNllqUnraXWeqGOhE47S0h7mqs5bL2ZIBe3bdQZiv7EhsYZc7OXtN?=
 =?us-ascii?Q?PTATLQzpbDA7ZoDgCjWynOCzSEwbHNpiQMakBSQAPI+3EeO3GquxpEjj3Vvx?=
 =?us-ascii?Q?RSLmvroRq+4pfBAf2XOevMJu4tkPCZT2KJ9mp3cNzRtNishP6zMqwRc3R+wu?=
 =?us-ascii?Q?BO9dJ8nc1SQtPcef9Rw4aVYDq5BNlWqcxFQRLhV0wXSE6GBvV6dS73WZD12c?=
 =?us-ascii?Q?/ATd5+7q5yq/k2f9eIMQeMQf/0xSP6LVo8aRYsVy1kE4Lhx2EBMgAGLV/mmA?=
 =?us-ascii?Q?eK+a6TARNS8fWwgPIU/tu+HYdJz2b3DomXtSRO0Qy0SlY4UQRafFeJsMggcR?=
 =?us-ascii?Q?X6hnv03zNLNv91oLlRX940/nk47cQww4cc5wgYod?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e21a81a-a215-43f1-82f8-08db00bb4d5d
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 23:07:46.1947
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CIpFEf7TpB7w1KApEtp/TM8tSTySodpous1jrRYd0r+PME3g3muV/CjCa6hLySUMlp9cuMQVfwj0RFuaB3970A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4728
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Matthew Wilcox wrote:
> On Thu, Jan 26, 2023 at 09:37:08PM +0100, Helge Deller wrote:
> > > This 'fixes' looks correct to me.  I don't know how many folks are running
> > > highmem with parisc but if they are I am sure they would appreciate the
> > > extra knowledge.
> > 
> > It seems nobody is running highmem on parisc, because it can't be enabled.
> > AFAICS, it's not in any parisc related Kconfig file.
> 
> But this isn't being used for highmem on parisc; it's being used for
> cache coherency.

<sigh> right!  I missed that.  Thanks to you and Al for setting me
straight.

> 
> > > I do wonder if this should be cc'ed to stable to ensure it gets
> > > backported?  Helge do you think there is a need for that?
> > 
> > For correctness I think it's nevertheless good to backport it.
> 
> I cc'd stable on my version of this patch, and included a Fixes tag
> to indicate how far back to backport it.

Thanks!

> 
> > That would be another possibility:
> > 
> > diff --git a/arch/parisc/include/asm/cacheflush.h b/arch/parisc/include/asm/cacheflush.h
> > index 0bdee6724132..ce5d1f8a23bd 100644
> > --- a/arch/parisc/include/asm/cacheflush.h
> > +++ b/arch/parisc/include/asm/cacheflush.h
> > @@ -77,6 +77,7 @@ void flush_anon_page(struct vm_area_struct *vma, struct page *page, unsigned lon
> >  #define ARCH_HAS_FLUSH_ON_KUNMAP
> >  static inline void kunmap_flush_on_unmap(const void *addr)
> >  {
> > +       addr = PTR_ALIGN_DOWN(addr, PAGE_SIZE);
> 
> I considered that, but thought it a shame to do it here when all the
> other users are passing in a page-aligned address.
> 

I think this also keeps the kunmap_local() API intact better.

Patch reviewed.

Thanks!
Ira