Message-ID: <1baacdfb-0b40-28be-3e46-049013d92bb4@kernel.dk>
Date:   Fri, 27 Jan 2023 16:10:38 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v1 0/2] two suggested iouring op audit updates
Content-Language: en-US
To:     Paul Moore <paul@paul-moore.com>
Cc:     Richard Guy Briggs <rgb@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, io-uring@vger.kernel.org,
        Eric Paris <eparis@parisplace.org>,
        Steve Grubb <sgrubb@redhat.com>, Stefan Roesch <shr@fb.com>,
        Christian Brauner <brauner@kernel.org>,
        Pavel Begunkov <asml.silence@gmail.com>
References: <cover.1674682056.git.rgb@redhat.com>
 <da695bf4-bd9b-a03d-3fbc-686724a7b602@kernel.dk>
 <CAHC9VhSRbay5bEUMJngpj+6Ss=WLeRoyJaNNMip+TyTkTJ6=Lg@mail.gmail.com>
 <24fbe6cb-ee80-f726-b260-09f394ead764@kernel.dk>
 <CAHC9VhRuvV9vjhmTM4eGJkWmpZmSkgVaoQ=L6g3cahej-F52tQ@mail.gmail.com>
 <d9da8035-ed81-fb28-bf3a-f98c8a1e044a@kernel.dk>
 <CAHC9VhRpu7WZDqWKcLDj18A0Z5FJdUU=eUL3wbJH1CnEBWB4GA@mail.gmail.com>
 <7904e869-f885-e406-9fe6-495a6e9790e4@kernel.dk>
 <CAHC9VhRipXMCiaGZ-9YLycKWaq1FnV0ybC2B7G8Dua56P7bHkw@mail.gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <CAHC9VhRipXMCiaGZ-9YLycKWaq1FnV0ybC2B7G8Dua56P7bHkw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 1/27/23 4:08 PM, Paul Moore wrote:
> On Fri, Jan 27, 2023 at 6:02 PM Jens Axboe <axboe@kernel.dk> wrote:
>> On 1/27/23 3:53 PM, Paul Moore wrote:
>>> On Fri, Jan 27, 2023 at 5:46 PM Jens Axboe <axboe@kernel.dk> wrote:
>>>> On 1/27/23 3:38 PM, Paul Moore wrote:
>>>>> On Fri, Jan 27, 2023 at 2:43 PM Jens Axboe <axboe@kernel.dk> wrote:
>>>>>> On 1/27/23 12:42 PM, Paul Moore wrote:
>>>>>>> On Fri, Jan 27, 2023 at 12:40 PM Jens Axboe <axboe@kernel.dk> wrote:
>>>>>>>> On 1/27/23 10:23 AM, Richard Guy Briggs wrote:
>>>>>>>>> A couple of updates to the iouring ops audit bypass selections suggested in
>>>>>>>>> consultation with Steve Grubb.
>>>>>>>>>
>>>>>>>>> Richard Guy Briggs (2):
>>>>>>>>>   io_uring,audit: audit IORING_OP_FADVISE but not IORING_OP_MADVISE
>>>>>>>>>   io_uring,audit: do not log IORING_OP_*GETXATTR
>>>>>>>>>
>>>>>>>>>  io_uring/opdef.c | 4 +++-
>>>>>>>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>>>>
>>>>>>>> Look fine to me - we should probably add stable to both of them, just
>>>>>>>> to keep things consistent across releases. I can queue them up for 6.3.
>>>>>>>
>>>>>>> Please hold off until I've had a chance to look them over ...
>>>>>>
>>>>>> I haven't taken anything yet, for things like this I always let it
>>>>>> simmer until people have had a chance to do so.
>>>>>
>>>>> Thanks.  FWIW, that sounds very reasonable to me, but I've seen lots
>>>>> of different behaviors across subsystems and wanted to make sure we
>>>>> were on the same page.
>>>>
>>>> Sounds fair. BTW, can we stop CC'ing closed lists on patch
>>>> submissions? Getting these:
>>>>
>>>> Your message to Linux-audit awaits moderator approval
>>>>
>>>> on every reply is really annoying.
>>>
>>> We kinda need audit related stuff on the linux-audit list, that's our
>>> mailing list for audit stuff.
>>
>> Sure, but then it should be open. Or do separate postings or something.
>> CC'ing a closed list with open lists and sending email to people that
>> are not on that closed list is bad form.
> 
> Agree, that's why I said in my reply that it was crap that the
> linux-audit list is moderated and asked Richard/Steve to open it up.

And thanks for that, I just skipped it in the reply as it wasn't for
me.

-- 
Jens Axboe