Date:   Fri, 27 Jan 2023 15:13:07 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Al Viro <viro@zeniv.linux.org.uk>,
        Matthew Wilcox <willy@infradead.org>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Ira Weiny <ira.weiny@intel.com>,
        "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
        Alexander Potapenko <glider@google.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Tony Luck <tony.luck@intel.com>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        David Sterba <dsterba@suse.com>,
        Kees Cook <keescook@chromium.org>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Helge Deller <deller@gmx.de>
Subject: Re: [PATCH] mm/highmem: Align-down to page the address for
 kunmap_flush_on_unmap()
Message-ID: <63d45a837b15b_7f63c294a2@iweiny-mobl.notmuch>
References: <20230126143346.12086-1-fmdefrancesco@gmail.com>
 <20230126123858.42d9377ad6e352a58c81668b@linux-foundation.org>
 <Y9LnAzUP2K/cmqa5@casper.infradead.org>
 <Y9LqwvXy+gpFBerE@ZenIV>
 <Y9L291ySSSRHD3uB@casper.infradead.org>
 <Y9L7/b/33mXvRsyX@ZenIV>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y9L7/b/33mXvRsyX@ZenIV>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DD0CuH/WbZEU6bdXA7zSH8AeqYaiJiJuJUXObamQYDOmlJSUJiDijNQxclul?=
 =?us-ascii?Q?tu915LKDKeT/Q0r9Z3WNNPm2148nXaCqA+zj73yMO+W1pnMd4IEpBBK+pCRB?=
 =?us-ascii?Q?em/WCSTZZRQETaAzFPS/mkAhS47TwpRAj2a6AKLNL2yZq//3ZrhFtFlFtnCv?=
 =?us-ascii?Q?ooflA1Yyn9gufc7TYH63EAdcLcPpoeoP7Ueao2wE5I+eyceLAAu8zNeeOw40?=
 =?us-ascii?Q?H0XpK2IBPYnCwh/smW1AgcyrywWeQSu1MVhYhp7VX11/W3z+lHcVWp7bUp4J?=
 =?us-ascii?Q?6oaqI+TWSC8vzrKTXXBz9pDHaWrdhcJPEmzn+iXmiKMCCQtm7Z3znpl9g3CB?=
 =?us-ascii?Q?6pPRkN8mA5QP9mj85OY/KHitGcmPUoeUF4TelyxmrokMwxJopY5uXCwZXewO?=
 =?us-ascii?Q?ZI5ZLrl+qy6NLllmASArroZWaPRpzjr2NLnM8Un6IrRhGfVmaYHkrgkvMDhz?=
 =?us-ascii?Q?2cNpugQ25iDcKuELst9UiUHJjSSDJG36BciaYD1ID/yNi/dOvUAs0BdL4zek?=
 =?us-ascii?Q?d2278nOkvFIDliO8Uytrfz/mvvJ2u1bxq2afQbk8MmNGu1ayyAFQ56oDKYaQ?=
 =?us-ascii?Q?mebkQRxt4YXBDCgKBXu7mplyKu+WmIwnoEOpfyhOYH+cQPlaZOW2Umv8AkLi?=
 =?us-ascii?Q?ZtA4AUwkcUsSY5kpvaKgYwOgej/5/dl7B0Vfyjhhs9Mjp0E9YkRdhlSnCRDX?=
 =?us-ascii?Q?hfOCYckZTQNF2A2HaBf8LvtoKAZNdH1AMBvOXVGHmNOE1B5ZnPHAHjLUSko9?=
 =?us-ascii?Q?Oj3g/Lik1uaa1QmkPAty+Ii1pkaj4AZjtUwzoWDna8YnV3YPyOL68frpwF7s?=
 =?us-ascii?Q?noomn/B7N+5wn2PXexxPTB4blKsjARB7V3RU9w2jEOoRd6PC1eaQNAgzzyj5?=
 =?us-ascii?Q?PmHAgvTHrYeozzH3/mcqChLO1JhN8Wo87c7V7+WHx1RMIfkMc1tXQ0EhwVBV?=
 =?us-ascii?Q?En/DVfY0sbWQDDMsPJouvY84CIHg6qryzRob6nh5lLnMkWNjTUwMoXrs745R?=
 =?us-ascii?Q?5Pme0ax8edxWdEvmN6YIvd9b4vo94JM4Q7SrRjUaLHXfJh3DXssaSIDxhHvX?=
 =?us-ascii?Q?izcPOOyVY+EkfIq4DtuDs3FrWSAfuPLFK4FnzsuO7rMbx4M2DrlW8vc/ljr3?=
 =?us-ascii?Q?Z8HniOnRYgc2hxXOAhnTXiCcS9BsFiMt+3SFoM/jfyW58TQ+p2f7pRVxoTUR?=
 =?us-ascii?Q?2xyMGFJNYkOQQTUtmtwp196higc7kDWmvD5xst0H5eUu86m971RGBs+h3ZN+?=
 =?us-ascii?Q?FvkpAgN8HqUPmBC/gRgsnQFyceBTKasQQr8h7jTlYTxc98zZd9GTg8xyF+cv?=
 =?us-ascii?Q?XNLbt+/zRRL903ozT0g8LtD96ToG/T/9dRVsb4zfSbNqnik5DinbuEjKUCfA?=
 =?us-ascii?Q?fsTAK2rwcfF8x+QSpzaAzT7qCUU8ZiAVRAwh8vEB/osLO93M355JdCQTCZpf?=
 =?us-ascii?Q?5Ci6hZJwcN6hwkXFx/GFfZtJFQLepoj2OZMaOboRQdUsGoeZU7kCp13rYIVp?=
 =?us-ascii?Q?Q/dIogUx2M2UpVL3cNAU3sfLCxYq6O0En0JrYm7KFbPvvrTrTrDrBf09IymD?=
 =?us-ascii?Q?Ko9LJjokV84MU/rEbnJtZJVdNVHYJYBnAO2VIaaF?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 18e59d7c-ab69-4d39-4b61-08db00bc0f48
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 23:13:11.5022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZJS+0tLkOqydhoQGuBe2kal/4/kPhke/ZI/BQ103ITarUiIVqI2hB4XHfYaCqKihk7CkZfEiSsf6Jz8nlUhOEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5644
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Al Viro wrote:
> On Thu, Jan 26, 2023 at 09:56:07PM +0000, Matthew Wilcox wrote:
> > On Thu, Jan 26, 2023 at 09:04:02PM +0000, Al Viro wrote:
> > > On Thu, Jan 26, 2023 at 08:48:03PM +0000, Matthew Wilcox wrote:
> > > > On Thu, Jan 26, 2023 at 12:38:58PM -0800, Andrew Morton wrote:
> > > > > On Thu, 26 Jan 2023 15:33:46 +0100 "Fabio M. De Francesco" <fmdefrancesco@gmail.com> wrote:
> > > > > 
> > > > > > If ARCH_HAS_FLUSH_ON_KUNMAP is defined (PA-RISC case), __kunmap_local()
> > > > > > calls kunmap_flush_on_unmap(). The latter currently flushes the wrong
> > > > > > address (as confirmed by Matthew Wilcox and Helge Deller). Al Viro
> > > > > > proposed to call kunmap_flush_on_unmap() on an aligned-down to page
> > > > > > address in order to fix this issue. Consensus has been reached on this
> > > > > > solution.
> > > > > 
> > > > > What are the user-visible runtime effects of this flaw?
> > > > 
> > > > The version of this patch I sent out includes this information,
> > > > as well as the missed alignment for kunmap_atomic().
> > > 
> > > One point: AFAICS, the situation right now is
> > > 	* all callers of kunmap_local() pass page-aligned pointers
> > 
> > Ah, no.  kmap_local_folio() accepts a byte offset within the folio
> > and returns a pointer to that byte.  I hadn't noticed the parisc
> > case and thought it was already allowed to pass a misaligned pointer
> > to kunmap_local() since it is allowed for the highmem case.  It
> > simplified the callers, so it looked like a good tradeoff.
> > 
> > See, eg 338f379cf7c2:
> > 
> > -               src_addr = kmap_atomic(src_page);
> > -               dest_addr = kmap_atomic(dest_page);
> > +               src_addr = kmap_local_folio(src_folio,
> > +                                       offset_in_folio(src_folio, srcoff));
> > +               dst_addr = kmap_local_folio(dst_folio,
> > +                                       offset_in_folio(dst_folio, dstoff));
> > 
> > -               if (memcmp(src_addr + src_poff, dest_addr + dest_poff, cmp_len))
> > +               if (memcmp(src_addr, dst_addr, cmp_len))
> > 
> > -               kunmap_atomic(dest_addr);
> > -               kunmap_atomic(src_addr);
> > +               kunmap_local(dst_addr);
> > +               kunmap_local(src_addr);
> 
> Argh...  Missed that.
> 
> OK, then Fixes: on the patch makes a lot of sense.  And it still
> needs a chunk in D/m/highmem.rst...
> 

I believe this is taken care of because the kdocs for
kunmap_{local,atomic}() are included there.  And those kdocs indicate the
ability to use any address in the page.

Thanks for setting me straight on the parisc/highmem thing I missed that.

Ira