MIME-Version: 1.0
References: <20230127224101.never.746-kees@kernel.org>
In-Reply-To: <20230127224101.never.746-kees@kernel.org>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Fri, 27 Jan 2023 17:44:13 -0600
Message-ID: <CAL_JsqKVp57NtR11JV-eXktMU9_dQ+8sF8YSPe7KyazrvJB-eQ@mail.gmail.com>
Subject: Re: [PATCH] scripts/dtc: Replace 0-length arrays with flexible arrays
To:     Kees Cook <keescook@chromium.org>
Cc:     Frank Rowand <frowand.list@gmail.com>, devicetree@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 27, 2023 at 4:41 PM Kees Cook <keescook@chromium.org> wrote:
>
> Replace the 0-length array with a C99 flexible array. Seen with GCC 13
> under -fstrict-flex-arrays:
>
> In file included from ../lib/fdt_ro.c:2:
> ../lib/../scripts/dtc/libfdt/fdt_ro.c: In function 'fdt_get_name':
> ../lib/../scripts/dtc/libfdt/fdt_ro.c:319:24: warning: 'strrchr' reading 1 or more bytes from a region of size 0 [-Wstringop-overread]
>   319 |                 leaf = strrchr(nameptr, '/');
>       |                        ^~~~~~~~~~~~~~~~~~~~~
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  scripts/dtc/libfdt/fdt.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Changes to dtc/libfdt go to upstream dtc first and then we sync them back.

Rob