Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932496AbXH3P4q (ORCPT ); Thu, 30 Aug 2007 11:56:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757624AbXH3P4i (ORCPT ); Thu, 30 Aug 2007 11:56:38 -0400 Received: from mx1.redhat.com ([66.187.233.31]:34672 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757000AbXH3P4h (ORCPT ); Thu, 30 Aug 2007 11:56:37 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <200708301701.36533.agruen@suse.de> References: <200708301701.36533.agruen@suse.de> <20070808171622.632749741@suse.de> <20070810143846.930027497@suse.de> <20070829190823.GB28028@infradead.org> To: akpm@osdl.org Cc: dhowells@redhat.com, Christoph Hellwig , linux-kernel@vger.kernel.org, Andreas Gruenbacher Subject: Re: [FIX] mntput called before dput in afs X-Mailer: MH-E 8.0.3; nmh 1.2-20070115cvs; GNU Emacs 22.1.50 Date: Thu, 30 Aug 2007 16:56:24 +0100 Message-ID: <21419.1188489384@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 30 From: Andreas Gruenbacher dput must be called before mntput here. Please consider for 2.6.24 and stable. Signed-off-by: Andreas Gruenbacher Acked-By: David Howells --- fs/afs/mntpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/afs/mntpt.c +++ b/fs/afs/mntpt.c @@ -235,8 +235,8 @@ static void *afs_mntpt_follow_link(struc err = do_add_mount(newmnt, nd, MNT_SHRINKABLE, &afs_vfsmounts); switch (err) { case 0: - mntput(nd->mnt); dput(nd->dentry); + mntput(nd->mnt); nd->mnt = newmnt; nd->dentry = dget(newmnt->mnt_root); schedule_delayed_work(&afs_mntpt_expiry_timer, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/