Date:   Fri, 27 Jan 2023 21:26:46 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Yunsheng Lin <linyunsheng@huawei.com>
Cc:     Alexander Duyck <alexander.duyck@gmail.com>, <nbd@nbd.name>,
        <davem@davemloft.net>, <edumazet@google.com>, <hawk@kernel.org>,
        <ilias.apalodimas@linaro.org>, <linux-kernel@vger.kernel.org>,
        <lorenzo@kernel.org>, <netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [net PATCH] skb: Do mix page pool and page referenced frags in
 GRO
Message-ID: <20230127212646.4cfeb475@kernel.org>
In-Reply-To: <cde24ed8-1852-ce93-69f3-ff378731f52c@huawei.com>
References: <04e27096-9ace-07eb-aa51-1663714a586d@nbd.name>
        <167475990764.1934330.11960904198087757911.stgit@localhost.localdomain>
        <cde24ed8-1852-ce93-69f3-ff378731f52c@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 28 Jan 2023 10:37:47 +0800 Yunsheng Lin wrote:
> If we are not allowing gro for the above case, setting NAPI_GRO_CB(p)->flush
> to 1 in gro_list_prepare() seems to be making more sense so that the above
> case has the same handling as skb_has_frag_list() handling?
> https://elixir.bootlin.com/linux/v6.2-rc4/source/net/core/gro.c#L503
> 
> As it seems to avoid some unnecessary operation according to comment
> in tcp4_gro_receive():
> https://elixir.bootlin.com/linux/v6.2-rc4/source/net/ipv4/tcp_offload.c#L322

The frag_list case can be determined with just the input skb.
For pp_recycle we need to compare input skb's pp_recycle with
the pp_recycle of the skb already held by GRO.

I'll hold off with applying a bit longer tho, in case Eric
wants to chime in with an ack or opinion.