From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        "'Rob Herring'" <robh+dt@kernel.org>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc:     "'Sam Protsenko'" <semen.protsenko@linaro.org>,
        "'Chanho Park'" <chanho61.park@samsung.com>
In-Reply-To: <20230120173116.341270-1-krzysztof.kozlowski@linaro.org>
Subject: RE: [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on
 Exynos7 Espresso
Date:   Sat, 28 Jan 2023 12:19:00 +0530
Message-ID: <001001d932e4$9ca8f0f0$d5fad2d0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQMdAgS5dZRQAkVO6hc3mtnWMtV85gHe9LN3rBzNBwA=
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20230120173124epcas5p319f4f913d455734edb1b63eec2120e77@epcas5p3.samsung.com>
        <20230120173116.341270-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 11:01 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Sam Protsenko <semen.protsenko@linaro.org>; Chanho Park
> <chanho61.park@samsung.com>; Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on
> Exynos7 Espresso
> 
> The Panfrost GPU drivers require clock but such was not provided in
> Exynos7 DTSI.  The CMU_G3D clock controller was not upstreamed, thus
> consider GPU as non-working and simply disable it to silence warnings
> like:
> 
>   exynos7-espresso.dtb: gpu@14ac0000: 'clocks' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

> 
> This patchset fixes remaining Exynos/Tesla ARMv8 dtbs_check warnings. No
> more excuses for not running dtbs_check on new patches.

Thanks Krzysztof for cleaning it up.

> ---
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index b846c0be90e3..829657c9c7ca 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -61,7 +61,6 @@ &fin_pll {
> 
>  &gpu {
>  	mali-supply = <&buck6_reg>;
> -	status = "okay";
>  };
> 
>  &serial_2 {
> --
> 2.34.1