Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F776C27C76 for ; Sat, 28 Jan 2023 07:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232227AbjA1HT2 (ORCPT ); Sat, 28 Jan 2023 02:19:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231612AbjA1HT0 (ORCPT ); Sat, 28 Jan 2023 02:19:26 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 762FD7E6CC for ; Fri, 27 Jan 2023 23:19:24 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id jl3so7046785plb.8 for ; Fri, 27 Jan 2023 23:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=laXAH5vCj60E4SKPB0EaS+rzszoEwgFmO/AUUT4c6EE=; b=tmPZMbcJdI07kMJbg//bhDUNZ5KDVVZ2XAzmy8ooz8DAs/87eQ8xaIW9TMmlo7p11e hdSVHBR5OJilXJnd6grGS0h68h34HGg+wmw02fuRE3b8brDJ4Rpk3tb6YfnqMUaMNhjM fgye91Hf232OS8bCCEAmgY2kHzH7TvDc87sBHl+WPLXCSalMe5BWf/ze5NEMJrUa7o2O Jcy1lTTkJcImUcG+o7lTL+/xh3ChzFeROE8zm199gWvoBKR4rdbbAdKNH/EVHjkrThIl Bz8K7V429/gShD3wOSxSSFR7OYsgY82uRYwvBvSbV+BGLHO84mkzYjIcLyNuodj9mkX3 YaOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=laXAH5vCj60E4SKPB0EaS+rzszoEwgFmO/AUUT4c6EE=; b=rf3C0QOE9fopcvYOp4409JwwDK99vS7pn9lWp1uco5tVQ27p1UKBx427E85DQ2n67E dzWIaDkmmZ3AmKOSqsZXvNnrrtFK1D/Kj9cAg5TROLTignklmpq9gwf8ak8AKy/pszN6 RvcdUG61isCyj+kP4C6+f3I/kRyounaQs7wOMkomb0kIpqCf6qnmxkFqFDPjiRmjaJJ0 wIoCmdnHz8mnORADW0tdeibcSXP1O+jQQ6gpkSPbnsp7PHwFQDt52h8AGpoYM28/PS7h dt3PGPZaP7nFp0C6JjllDF5kpCKvt2fw8JBBJRGuUDskO5pVxwHZwvWtJrhDb58G4sm4 1+gA== X-Gm-Message-State: AO0yUKX20QaaQ1EpwLjdlz8Z0yln5ZxfiYPWruMQKaOuRVldPlekxlIP YFazLEwx8Hux945Q3SASBdv6IAfJxP0So+zzst50bw== X-Google-Smtp-Source: AK7set9Mr0byHbMSV0I8NA2aqwV2H7BFCi7M8aNlkggIrU6lOiPUWBoUK5Tegh3Ooimmvu26mnAavaDANvOV+V848Ys= X-Received: by 2002:a17:90a:64c5:b0:22b:ef05:ea5b with SMTP id i5-20020a17090a64c500b0022bef05ea5bmr2691642pjm.50.1674890363672; Fri, 27 Jan 2023 23:19:23 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Fri, 27 Jan 2023 23:18:46 -0800 Message-ID: Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2023 at 12:11 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Fri, Jan 27, 2023 at 1:11 AM Saravana Kannan wrote: > > The OF_POPULATED flag was set to let fw_devlink know that the device > > tree node will not have a struct device created for it. This information > > is used by fw_devlink to avoid deferring the probe of consumers of this > > device tree node. > > > > Let's use fwnode_dev_initialized() instead because it achieves the same > > effect without using OF specific flags. This allows more generic code to > > be written in driver core. > > > > Signed-off-by: Saravana Kannan > > Thanks for your patch! > > > --- a/drivers/soc/renesas/rcar-sysc.c > > +++ b/drivers/soc/renesas/rcar-sysc.c > > @@ -437,7 +437,7 @@ static int __init rcar_sysc_pd_init(void) > > > > error = of_genpd_add_provider_onecell(np, &domains->onecell_data); > > if (!error) > > - of_node_set_flag(np, OF_POPULATED); > > + fwnode_dev_initialized(&np->fwnode, true); > > As drivers/soc/renesas/rmobile-sysc.c is already using this method, > it should work fine. > > Reviewed-by: Geert Uytterhoeven > i.e. will queue in renesas-devel for v6.4. Thanks! Does that mean I should drop this from this series? If two maintainers pick the same patch up, will it cause problems? I'm eventually expecting this series to be picked up by Greg into driver-core-next. -Saravana > > > > > out_put: > > of_node_put(np); > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds