From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        "'Rob Herring'" <robh+dt@kernel.org>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc:     <replicant@osuosl.org>, <phone-devel@vger.kernel.org>,
        <~postmarketos/upstreaming@lists.sr.ht>,
        =?utf-8?Q?'Martin_J=C3=BCcker'?= <martin.juecker@gmail.com>,
        "'Henrik Grimler'" <henrik@grimler.se>,
        "'Sam Protsenko'" <semen.protsenko@linaro.org>,
        "'Chanho Park'" <chanho61.park@samsung.com>,
        "'Marek Szyprowski'" <m.szyprowski@samsung.com>,
        "'Chanwoo Choi'" <cw00.choi@samsung.com>
In-Reply-To: <20230127212713.267014-4-krzysztof.kozlowski@linaro.org>
Subject: RE: [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3
 node wrapper in Exynos7
Date:   Sat, 28 Jan 2023 13:36:01 +0530
Message-ID: <001201d932ef$5e74dd70$1b5e9850$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQFzvEVwWLN0sEUdJm8gcJkigxsA0gKyTjLNAakoc06vW4NzgA==
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org>
        <CGME20230127212733epcas5p24868be035c0f2c3190b8cfe4a6310ccd@epcas5p2.samsung.com>
        <20230127212713.267014-4-krzysztof.kozlowski@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> Sent: Saturday, January 28, 2023 2:57 AM
> To: Rob Herring <robh+dt=40kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt=40linaro.org>; Alim Akhtar
> <alim.akhtar=40samsung.com>; devicetree=40vger.kernel.org; linux-arm-
> kernel=40lists.infradead.org; linux-samsung-soc=40vger.kernel.org; linux-
> kernel=40vger.kernel.org
> Cc: replicant=40osuosl.org; phone-devel=40vger.kernel.org;
> =7Epostmarketos/upstreaming=40lists.sr.ht; Martin J=C3=BCcker=0D=0A>=20<m=
artin.juecker=40gmail.com>;=20Henrik=20Grimler=20<henrik=40grimler.se>;=20S=
am=0D=0A>=20Protsenko=20<semen.protsenko=40linaro.org>;=20Chanho=20Park=0D=
=0A>=20<chanho61.park=40samsung.com>;=20Marek=20Szyprowski=0D=0A>=20<m.szyp=
rowski=40samsung.com>;=20Chanwoo=20Choi=0D=0A>=20<cw00.choi=40samsung.com>;=
=20Krzysztof=20Kozlowski=0D=0A>=20<krzysztof.kozlowski=40linaro.org>=0D=0A>=
=20Subject:=20=5BRFT=20PATCH=20v3=204/4=5D=20arm64:=20dts:=20exynos:=20add=
=20unit=20address=20to=20DWC3=0D=0A>=20node=20wrapper=20in=20Exynos7=0D=0A>=
=20=0D=0A>=20Neither=20simple-bus=20bindings=20nor=20dtc=20W=3D1=20accept=
=20device=20nodes=20in=20soc=40=20node=0D=0A>=20which=20do=20not=20have=20u=
nit=20address.=20=20Therefore=20usethe=20address=20space=20of=20child=0D=0A=
>=20device=20(actual=20DWC3=20Controller)=20as=20the=20wrapper's=20address=
=20to=0D=0A>=20fix:=0D=0A>=20=0D=0A>=20=20=20exynos7-espresso.dtb:=20soc=40=
0:=20usb:=20=7B'compatible':=20=5B'samsung,exynos7-=0D=0A>=20dwusb3'=5D,=20=
...=0D=0A>=20=20=20=20=20should=20not=20be=20valid=20under=20=7B'type':=20'=
object'=7D=0D=0A>=20=0D=0A>=20Signed-off-by:=20Krzysztof=20Kozlowski=20<krz=
ysztof.kozlowski=40linaro.org>=0D=0A>=20=0D=0A>=20---=0D=0AReviewed-by:=20A=
lim=20Akhtar=20<alim.akhtar=40samsung.com>=0D=0A=0D=0ATested=20on=20exynos7=
-espresso=20and=20xHCI=20driver=20still=20gets=20probed,=20so=20=0D=0A=0D=
=0ATested-by:=20Alim=20Akhtar=20<alim.akhtar=40samsung.com>=0D=0A=0D=0A=0D=
=0A>=20=0D=0A>=20Changes=20since=20v1:=0D=0A>=201.=20New=20patch=0D=0A>=20-=
--=0D=0A>=20=20arch/arm64/boot/dts/exynos/exynos7.dtsi=20=7C=208=20++++----=
=0D=0A>=20=201=20file=20changed,=204=20insertions(+),=204=20deletions(-)=0D=
=0A>=20=0D=0A>=20diff=20--git=20a/arch/arm64/boot/dts/exynos/exynos7.dtsi=
=0D=0A>=20b/arch/arm64/boot/dts/exynos/exynos7.dtsi=0D=0A>=20index=2082fee1=
b7caab..b1fa68835b09=20100644=0D=0A>=20---=20a/arch/arm64/boot/dts/exynos/e=
xynos7.dtsi=0D=0A>=20+++=20b/arch/arm64/boot/dts/exynos/exynos7.dtsi=0D=0A>=
=20=40=40=20-690,7=20+690,7=20=40=40=20usbdrd_phy:=20phy=4015500000=20=7B=
=0D=0A>=20=20=09=09=09=23phy-cells=20=3D=20<1>;=0D=0A>=20=20=09=09=7D;=0D=
=0A>=20=0D=0A>=20-=09=09usbdrd:=20usb=20=7B=0D=0A>=20+=09=09usbdrd:=20usb=
=4015400000=20=7B=0D=0A>=20=20=09=09=09compatible=20=3D=20=22samsung,exynos=
7-dwusb3=22;=0D=0A>=20=20=09=09=09clocks=20=3D=20<&clock_fsys0=20ACLK_USBDR=
D300>,=0D=0A>=20=20=09=09=09=20=20=20=20=20=20=20<&clock_fsys0=20SCLK_USBDR=
D300_SUSPENDCLK>,=0D=0A>=20=40=40=20-699,11=20+699,11=20=40=40=20usbdrd:=20=
usb=20=7B=0D=0A>=20=20=09=09=09=09=22usbdrd30_axius_clk=22;=0D=0A>=20=20=09=
=09=09=23address-cells=20=3D=20<1>;=0D=0A>=20=20=09=09=09=23size-cells=20=
=3D=20<1>;=0D=0A>=20-=09=09=09ranges;=0D=0A>=20+=09=09=09ranges=20=3D=20<0x=
0=200x15400000=200x10000>;=0D=0A>=20=0D=0A>=20-=09=09=09usb=4015400000=20=
=7B=0D=0A>=20+=09=09=09usb=400=20=7B=0D=0A>=20=20=09=09=09=09compatible=20=
=3D=20=22snps,dwc3=22;=0D=0A>=20-=09=09=09=09reg=20=3D=20<0x15400000=200x10=
000>;=0D=0A>=20+=09=09=09=09reg=20=3D=20<0x0=200x10000>;=0D=0A>=20=20=09=09=
=09=09interrupts=20=3D=20<GIC_SPI=20223=0D=0A>=20IRQ_TYPE_LEVEL_HIGH>;=0D=
=0A>=20=20=09=09=09=09phys=20=3D=20<&usbdrd_phy=200>,=20<&usbdrd_phy=201>;=
=0D=0A>=20=20=09=09=09=09phy-names=20=3D=20=22usb2-phy=22,=20=22usb3-phy=22=
;=0D=0A>=20--=0D=0A>=202.34.1=0D=0A=0D=0A=0D=0A