Message-ID: <8dba267b-62b4-1085-c307-3d2608ae5857@linaro.org>
Date:   Sat, 28 Jan 2023 11:13:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p
 compatible
Content-Language: en-US
To:     Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230127192139.299228-1-brgl@bgdev.pl>
 <52508584-47c5-2497-68c8-2c0044911aca@linaro.org>
 <CACMJSevqcaqjLQJ6_5Xn=hMbrsjdxGVM=9RYwYQ8hW_Uy-tRzA@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <CACMJSevqcaqjLQJ6_5Xn=hMbrsjdxGVM=9RYwYQ8hW_Uy-tRzA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/01/2023 22:22, Bartosz Golaszewski wrote:
> On Fri, 27 Jan 2023 at 20:56, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 27/01/2023 20:21, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>
>>> Add a compatible for the sa8775p platform's Secure Channel Manager
>>> firmware interface.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>> ---
>>>  Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> If you send bindings separately from DTS (which is fine), please provide
>> the link to the user - either DTS or driver for this compatible. Driver
>> does not use it, thus to the DTS.
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
> 
> Can you specify what kind of link you're expecting? I'm looking at
> previous commits for this file and not seeing anything. There's no
> upstream user of this compatible in any DTS yet.


I expect lore link to the patchset you sent using this binding, so we
can verify whether you used it correctly or not. If people were testing
their DTS against bindings they write, this would not be needed.
Unfortunately people do not do that...

Best regards,
Krzysztof