Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Sat, 28 Jan 2023 12:13:10 +0100
Message-Id: <CQ3S1YW1TFJ0.KGRDY0XZGSL4@vincent>
Subject: Re: [PATCH 4/5] rust: types: implement `ForeignOwnable` for the
 unit type
From:   "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To:     "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
        "Gary Guo" <gary@garyguo.net>
Cc:     "Wedson Almeida Filho" <wedsonaf@gmail.com>,
        <rust-for-linux@vger.kernel.org>,
        "Miguel Ojeda" <ojeda@kernel.org>,
        "Alex Gaynor" <alex.gaynor@gmail.com>,
        "Boqun Feng" <boqun.feng@gmail.com>,
        =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        <linux-kernel@vger.kernel.org>
References: <20230119174036.64046-1-wedsonaf@gmail.com>
 <20230119174036.64046-4-wedsonaf@gmail.com>
 <20230127140319.22af6060.gary@garyguo.net>
 <CANiq72kXNvQ-GY-uw24s_1NmQ5G12Cu+JfYKFQ0rC-4Fnm8o8Q@mail.gmail.com>
In-Reply-To: <CANiq72kXNvQ-GY-uw24s_1NmQ5G12Cu+JfYKFQ0rC-4Fnm8o8Q@mail.gmail.com>
Precedence: bulk

On Fri Jan 27, 2023 at 3:11 PM CET, Miguel Ojeda wrote:
> On Fri, Jan 27, 2023 at 3:03 PM Gary Guo <gary@garyguo.net> wrote:
> >
> > this should really be `core::ptr::invalid(1)`. That's currently
> > unstable, but can be equivalently written as
> > `NonNull::<()>::dangling().as_ptr()`.
> >
> > This has a different semantic meaning from `as` since it explicitly
> > suggests an invalid provenance and thus will not alias with other
> > pointers. (Although I don't think compiler currently can take advantage
> > of this fact yet)
>
> We talked about starting to use `strict_provenance` when it came out
> -- what is the latest status? i.e. do you know if it is expected that
> it will pass FCP etc.? (my understanding originally was that it was an
> experiment).
From what I remember the feeling was positing into hace `strict_provenance`

Here is the last meeting  that was back in August =20
https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/Stabiliz=
ing.20strict.20provenance.20APIs.3F

I guess, we could just put a fix me around the actual code, I feel that the=
 Gary change deserve a=20
own patch with the own description.

Cheers!

Vincent.