Message-ID: <560a0204-5f4e-07af-61be-26e949fe6f20@intel.com>
Date:   Sat, 28 Jan 2023 21:20:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH mm-unstable v2 1/6] mm: Add folio_estimated_mapcount()
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        Vishal Moola <vishal.moola@gmail.com>
CC:     <linux-mm@kvack.org>, <akpm@linux-foundation.org>,
        <linux-kernel@vger.kernel.org>
References: <20230124012210.13963-1-vishal.moola@gmail.com>
 <20230124012210.13963-2-vishal.moola@gmail.com>
 <477bbc1e-a60a-cfce-d31e-0b4bdd5f6429@redhat.com>
 <526e5156-6c4b-9f2c-1637-2f83c1dfea1e@redhat.com>
 <53d86764-d155-8d97-1a4d-7e701848c950@redhat.com>
 <CAOzc2pyV9-wq04NRKVE1vRj7PnRF7g+jSFFj-oKYuZk-t9smBA@mail.gmail.com>
 <52af321f-175b-9fa9-10f0-ac2bba04c677@redhat.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <52af321f-175b-9fa9-10f0-ac2bba04c677@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1I5WlJ6WUhwZWJmVE1iWXNDN29CVnBzaEpnd29KNEMySXBxc01rUnFOSkFO?=
 =?utf-8?B?MGcrTmtaUkVQMTJkaTB3dFkyUW9QYXN5dkdoNHN5akY0YXVOU29vQlovRlZV?=
 =?utf-8?B?MTZSL1owOGh1b3RFTTBOajd0VjNNZDNUWXZCRmpiNWY2KytDSnZsQk9BWVMv?=
 =?utf-8?B?UG9BbHNjRjhYdkhBbysvWlhWL1BwTFkxYmRHSXZsZmc5UjZncUJMaDc0RUl2?=
 =?utf-8?B?YWhPYnQvSGJnbHhndjRGZVJ4MFdackNnTlhrL1V1aDd4MFhoeVhhUjlxSkoy?=
 =?utf-8?B?TzI2YitXcGFucExUMzh0eHBqMWhDdi9VajZ5M0lhazU1WTMxS3IwQmU2RGhh?=
 =?utf-8?B?UVFmM2dHM2kyVTluK0J6bmZ3SFhlRTZ3RWt5OUc1MjJGSXRtanhyTnR0SzE2?=
 =?utf-8?B?anMvOUdnZ3h0VWFJTmFoTlgzcVpjSWNyTitNT3pkK3JGRE9hdlg1aVhaS2Zo?=
 =?utf-8?B?Qks4MExnSWVodDlJc3dsTGU2RWdWaW91ZUpsV3J0Wnlpc1ZOUnF3UlhEcnNV?=
 =?utf-8?B?dCt5YjVJVktSQzZrR3RNOXZzYkNLS0tObGE3UFRabmMxcWRtWGRzUzdob0ZZ?=
 =?utf-8?B?RmNqNGNLdWlUVlZybmE5NVNXeGxyRU00Ull4S2RpSXVkTUZvcFUzai9paFQ2?=
 =?utf-8?B?RVh4TUZRR3VleThRR2IveXdITTV4cGF1ZkNEb3UzK3hOdnRjL2k2bnZlLy84?=
 =?utf-8?B?eVhnZDJMWXdmNnBEbFBxa1cxVkhFdjBqS293YXNjN21qcDZjVk5LaHhQZGVX?=
 =?utf-8?B?NWdtbTRkdUYrYVhWbE95cm44TkFlT2xSMFp6bXdVbC91YzJ6QXNkYmZRbk9R?=
 =?utf-8?B?YlF3LzFQSGhmZElBWWdTZExReE9xYkNmdVA3U0Q0QUtWUEZTbzJCWGtHdFQz?=
 =?utf-8?B?bFc4WkNnbWJPY0JwcDhlZ244V01xRDVuSE0xVHJKQTB6bVpzRUszUGRVRXlU?=
 =?utf-8?B?SWUrZEhBSzN2WXlvcFhUcXVCM0RuaEpjSmVMNFB3blRFaEpqNFQrSWJlOThX?=
 =?utf-8?B?dWZqMitZb2w5VSttV1dpOUw1d1UxYzVoZEZHMXlEVzNIb091aTQwY1pwOEZT?=
 =?utf-8?B?SjFJQlpZQnZuZkx5cHY2WGJOcVdRV0xmdEp1MSttcTREbUh3c2RickV5Umd5?=
 =?utf-8?B?TVJrM2p6ZGNveko4ZUVBVWVuOUk4eU9sQmtvTHlqbmU4dnB6UlEwdDduNkpv?=
 =?utf-8?B?ZWFRNnB6Y2VGMVZKWm5xemVKejNkOFdDQjEvWUNsWVFjVHZmT1NGSm42bDd5?=
 =?utf-8?B?LzV6TUhwdCs4VU14Qy9kWjVpUmlWNHM4MDFmZ0VRVjRlS2ZnYjRvMU9saDJB?=
 =?utf-8?B?ZEhlamtTYUwycGlXcXhhVVcyYzlaZkFhb0ord0l1WkswYWtJUTFZd1Z0RE80?=
 =?utf-8?B?RFdQS2QzSlA0SWRlcjlZMHc4bTJSSjduL25EdlpmTnhveDhkdllydWpNSEVv?=
 =?utf-8?B?RWpkN3FzTUdkdFFKeGM1ZkZGZmdBeW5SamM1My9oWEc5TGh1ejBOV2RMQ2c0?=
 =?utf-8?B?RjZwKzVMaVdKOWdYa1JHeTRyUlloWmY2M1UzWlFVeEowakE3dDB0OEVoV1M5?=
 =?utf-8?B?cFF1T1RMM3RXZlN5QVVWYm9JTGNNK3hHbUh5cjI0NHJoVFU3dG1qRjdWMlcz?=
 =?utf-8?B?NjBReC9iSGFTZW5JZURoN3JaVW42ZDBEbWtrNnk1R0FWa0JDYjBUeHdvaEI3?=
 =?utf-8?B?anFuUlZjUStsaUNlYW5oeXVwaVVpWXRzQmwwYXppbnNOZi9VVTU1c0lSNGNj?=
 =?utf-8?B?MmVPMTNKbWRpOVpFS0wyU25BQWIrcVNaZkR1VTZEeTN0YjNDZng2N2pmNnVo?=
 =?utf-8?B?RkZMLzFTK2l5Nks0Ni84cUlvRm15RDhxRGFRbDJ1WUtOUkxmYk9NRitRSmkz?=
 =?utf-8?B?TzFKR0QxcGZqZUlEanp0cUx2TjdFVU8zaUtiY2VGV0gzSlR0anJpL1JSaEtp?=
 =?utf-8?B?VTNiNmlFRXd5ZlFvQjVKWHhIS3JuN2xob0grbzAySWRKUGQvMXlWZHFheHRK?=
 =?utf-8?B?YmlzYWo0RnBzZi84NEJNTC9HNlh4MTVOMnY1cG0vOXBud1dRWmc3UVVpNVQ2?=
 =?utf-8?B?djMvOTFwQ2U0RHNDOTF6VCtjYUdlVzdCeWt5WktwQy9QVEo0NlNCdEhHR3lY?=
 =?utf-8?Q?QDR7cQWcjaz6cvUZNmbivGUSB?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 540c1f03-2e28-4bf3-36d4-08db013269d4
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2023 13:20:24.2470
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GtQSmAtkTG+7BxRaMsPERR8lmgUamaM90Itm0QOMvrcqZ+KJaXdAaQIgwbWgwtXSW/oxpbyRshAyVlfjdb5yCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5207
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/26/2023 4:37 PM, David Hildenbrand wrote:
> Thinking about it, I guess "folio_estimated_sharers()" might be what we actually want to name it. Then you can comment how we estimate sharers by looking at into how many page tables the first subpage is currently mapped, and assume the same holds true for the other subpages. 
Vote for 'folio_estimated_sharers()'. If better method
other than checking mapcount is found in the future, it's
easy to update the implementation without change the API
name.


Regards
Yin, Fengwei