Date:   Sat, 28 Jan 2023 14:44:54 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
        Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_conn: Refactor hci_bind_bis() since it
 always succeeds
Message-ID: <Y9Um1h/2V9mxDrIC@corigine.com>
References: <20230128005150.never.909-kees@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230128005150.never.909-kees@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6KLc2LFhD7HIJA+tSqatk0bck4OZxL12/00RO88V4VBP13s/Of3zi5BMfR4y?=
 =?us-ascii?Q?fWSfOYAk9xcYh3wmon19dq6DiDe7yd5JOWcM3TH6saxueuMHmI0qwrVjsxsG?=
 =?us-ascii?Q?YGwuerTWPNci77wOd+eXMyykhYQA/Rkf32gn1xUzTDYbiWGXfsbkU7o2T/1c?=
 =?us-ascii?Q?lT/+juaX6vYmr8KWP9/esl8UoPbxKLbgVq6kCxQ2lLDcgNvmmveBW80qjJfn?=
 =?us-ascii?Q?/vLaThH/l2dS6jgLVTpPp4mifnpf9gfKDsiAGeqb6r2ly2YVgLZKyjSRqyNm?=
 =?us-ascii?Q?fFN/3OafwhZMgPxYmHNmQ4clLwEm6uj2Og49gFIzHlE26W080nFzeRbfxGJH?=
 =?us-ascii?Q?2G/ODnwLewrzNYKuAnYjZwgW30SHQcF5vOvyhCjXLseohzxaidNYsBkSP0BX?=
 =?us-ascii?Q?hUWjVWE1TG2kUXq14y68ugjIZsazXdkGi30xYz73I/14tg0bMvLpQw1tbIV/?=
 =?us-ascii?Q?+LcKl3vGUt5Tl6SU2zUDDYUbnX67SmdXuRR1nImlCFws0YHJONv9TAd88Qdt?=
 =?us-ascii?Q?+f12T6ZO/QLKBO88dnG3k8zPDg4PvledUJ8JGiZn7KbtSahKl1CYFPxKAxWj?=
 =?us-ascii?Q?Bp4p81kzUfNVIiVNcb9t5LMW+xWvetMK4CsBiWyGtsFcrweGdH1bICD4yv4c?=
 =?us-ascii?Q?2GCat5M24YxeOklkZkTLfdH/rdl0+KX1XDhFpEIgciAsBDe0vC7CiFBRJ3+W?=
 =?us-ascii?Q?KCiejY44UgBaZjTsx+skfezdBWYczUrYV/K6yL3asKpABuChjpkVDk7fUOg2?=
 =?us-ascii?Q?HBekX/6un7C38NUM9G0NGn+dlOEq+PVohKhimO0UuAEpFwFbgdr4waJvl+Lq?=
 =?us-ascii?Q?sT2niEfAiSbtevg6XITw3Bq/UloLVz7vyUsEgpRo8FEZdVHxaBTbEiz+EEK5?=
 =?us-ascii?Q?8QU9qC2HSFNZF/9DOPOsZUsu7FYx7Bv6oANZ6ofkqTD2uxZ0Jcich0QdpOL7?=
 =?us-ascii?Q?f4ruDZB0ZOkyKqSf9NaV+AK8lE4L3p3uFnf5r8U6/ab/2P+CHBjFRvooQPZb?=
 =?us-ascii?Q?4moXVAZvROHJoIQ1ITLgTT/3jp4vbqdM4k+BBvUsTjSVKr9XGX4BKF3Ae++h?=
 =?us-ascii?Q?/pCdiEBBzS73E/35adevMrh/t9c2FGtxIJwxuNogClt/XcXYDZPSbWGcr/Pa?=
 =?us-ascii?Q?aOuJkmc1WxSdI9CQplgOXwJAXxlvmecMNuLC7R1ayym/gtW0oNVtGhH/spO+?=
 =?us-ascii?Q?Y2VGyknCH1FT427k/ukeyph3l5kgqg2YGJu8uNWkCs7qGwU5upjTf0j/JWmq?=
 =?us-ascii?Q?BfFa0yayhJdVXBAcymhm44EdwowS4xlO5rAPrgWsd0Tg7bhBM8CUyh9jGpxD?=
 =?us-ascii?Q?AuFU6f+svwqIZnUT8lrAWmiVdqzTy7QjaWihCo8Nf+ns8X6+yIkpTs30ODiM?=
 =?us-ascii?Q?oDFDiWfcivV0leOnkfMDLKBDz2C2lz/qIyKxo5MXckKP3Rfb/SzZbYvee+jy?=
 =?us-ascii?Q?UR/tAllLrC6h7L5kEBb2kWMEZR0AciNdcI9Jn4jncfaKfyi04PkYlv+OPxF0?=
 =?us-ascii?Q?Dbm0WvPCbABvHGmJno27zxy7GxORwjGYQSM1mRYXaRlA/xWuI7jjk4Q7gVru?=
 =?us-ascii?Q?9m5AF1EGXFH1MvBwZw/7FONHDdEA30nH1EEV0D7iPTVjWSbj72scKZI48VL+?=
 =?us-ascii?Q?pLlnqX1sM1SZpeVAZscCMnen9eDK79oBNcoe14YwOnifWN0/uSudsNpk1gS8?=
 =?us-ascii?Q?DBgEQA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 399e902e-7d74-4a74-280f-08db0135da7d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2023 13:45:01.5305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EseaYuyN9Mk4ZymVwhmVAEbGHixmc6H4KzqORkdL3rq/VOZt680N9Xx6/R7aHSIjlKYjTQLa9gMFf2Klm5IJ+vaQ0SUm4AZGOose4atUXUY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5444
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 27, 2023 at 04:51:54PM -0800, Kees Cook wrote:
> The compiler thinks "conn" might be NULL after a call to hci_bind_bis(),
> which cannot happen. Avoid any confusion by just making it not return a
> value since it cannot fail. Fixes the warnings seen with GCC 13:
> 
> In function 'arch_atomic_dec_and_test',
>     inlined from 'atomic_dec_and_test' at ../include/linux/atomic/atomic-instrumented.h:576:9,
>     inlined from 'hci_conn_drop' at ../include/net/bluetooth/hci_core.h:1391:6,
>     inlined from 'hci_connect_bis' at ../net/bluetooth/hci_conn.c:2124:3:
> ../arch/x86/include/asm/rmwcc.h:37:9: warning: array subscript 0 is outside array bounds of 'atomic_t[0]' [-Warray-bounds=]
>    37 |         asm volatile (fullop CC_SET(cc) \
>       |         ^~~
> ...
> In function 'hci_connect_bis':
> cc1: note: source object is likely at address zero
> 
> Fixes: eca0ae4aea66 ("Bluetooth: Add initial implementation of BIS connections")
...
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  net/bluetooth/hci_conn.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)

Is this really a 'fix' ?

In any case, the change looks good to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>