Date:   Sat, 28 Jan 2023 17:22:47 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     michael.chan@broadcom.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] net: b44: Remove the unused function __b44_cam_read()
Message-ID: <Y9VL19GH23h7WRF2@corigine.com>
References: <20230128090413.79824-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230128090413.79824-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yeejl0GQ73/D/zpnca3PJrO6IVd2pvllzXXTXHlkRn8nhJmDe2cq5FLMHHbk?=
 =?us-ascii?Q?TXShqmUTHjvRwmtzgUiU6us1GTCnpRynYCvsiIMmyFfFmELyGKDaSuoRbz9X?=
 =?us-ascii?Q?wKQinro3DjAd4qKhLDdpda4K0CAdlFfgw7qOugmebJ1Hzb8K6XhcIkFOl42E?=
 =?us-ascii?Q?1NRiHkxgGCG+ENt7T5CggfUwNB1rpuYgiMppjX93EyVyY7cTe8sCrqNTCcrt?=
 =?us-ascii?Q?MuXmfUsilpLI/T6aHErKlnkVL21yCq0D0pO1Muo9OA1/W/Gka+nkFOfvlDKF?=
 =?us-ascii?Q?+OmtEtKxabUJeLaCxR8gpj8yMMWqvKKapqzwZfWmNeogCIc0+1QKrqlO01UL?=
 =?us-ascii?Q?R7YVkmdl1zVpsuG3HIeun0g7Z+oQAMkvFPoAsQQRm0TWVNh66mY5J4GC7vwB?=
 =?us-ascii?Q?hIo/g4k7Txvy2znfSTK1qtLMVcqeCB4ByUJ/Zu4t+0WRyB8KoZKo5zInagii?=
 =?us-ascii?Q?6xYVhl65J4EOAU6KF8g+IMU0o8QSVP4++eh2ZaVedJeB20I/eu/+pZCY56uN?=
 =?us-ascii?Q?4YAP0F6XePwEl2seZqUFNzyvAvsYKo/zH77qaMt+M2k7H8LKUGdtLsxDWrC0?=
 =?us-ascii?Q?2KG5y7Y5Vf3V2rnEu4Qaiht0oeScEUiv4wb6d0QPdqF+LysAwEYAXpG1qAbw?=
 =?us-ascii?Q?BEJ65paEh9KsOYABV56Zu6ucieSeH/LGBw2t1IsnVkENFRJHOwRwL2F9ax7i?=
 =?us-ascii?Q?xb4BxZ1RDLBXaVGkQEU//D1SltZRz7hL6mU7BIF8bUrPLYQe2Bke+LgT40kh?=
 =?us-ascii?Q?ACR/3IEcLO0P5dVwEJ9SEHg3GzV+5hTz14LKkk4rST0tDP/LkbJN0Gh2wq9w?=
 =?us-ascii?Q?UVbqtaR8HY7wb9x7Tpsrgs/Adn8LpX3vHDId4MwY8QgFPoJZX7UtFbLv35yk?=
 =?us-ascii?Q?yYyYj+iJniazJJ9qLv/oiUvSq0BnpeSTOdpAWUZb1NNTmrpx4wP6+oH8Ma4Q?=
 =?us-ascii?Q?2qvyl2BU5fAxSFgCn0R5FJjPRocCgMg8Mx2ZYdEccd9fncUBj7hVVjGqIudI?=
 =?us-ascii?Q?2akmimxJqnu8AUw1cCKLIH1s6E9cIBAWAO+7Nxo+RgUNNsGMcvvImDOynZX/?=
 =?us-ascii?Q?GH9eftebYGBaPbpOviMtHNUW5Iov2svWzohQbee6LDoH6BwE2VgoFrKUOy2N?=
 =?us-ascii?Q?FnoDCu9WC7wylZOIvwMD3u4wP4J+hx+f0cm6EZLuCpDcwTa16l4MkR9lTbBl?=
 =?us-ascii?Q?05euhuL55mRN3Q6Va5t0BIZGIE2wAs2ajpvVGk94FMCgetyBzG6+hkY+24U7?=
 =?us-ascii?Q?xJOGBxWizzqT0mDSxRVUnuB9iGwGAQ98ZMRwteuGRQQHceExHLDmtmKS0aZE?=
 =?us-ascii?Q?5+h9S5uMJuQVD0+IpquNLu2IGFplb1alJKs4oiDL84gdVl27XWI9INmVHn7G?=
 =?us-ascii?Q?WL9nvevK9K+L9gX1+tQ0VaFUVcUJXzEP7VeDFktjrqv+L6/8nIiyaW6jfJjb?=
 =?us-ascii?Q?e6kGAResguNZWx8wVccwOm3pJE3y+1D1oZhK8J5hq69gASNfBpVhm8teu5Im?=
 =?us-ascii?Q?CK7x2AuN+/63BoX6HvInFWWyPWO6vyIKxvFUaTdMsu0VISnxLqnoZ29qa6VZ?=
 =?us-ascii?Q?O9I3S7QSz322h2Dn+rLinWglz8B7dFY3Fu4K/DqDiZRphksmAj5+43r6MtSl?=
 =?us-ascii?Q?4TPMcH8bSFzABBoFVgy19KB+5VujHw/Ji04njY66l4as3p4XmMeYDL90UAin?=
 =?us-ascii?Q?A8sgzw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 266ce44f-e2c3-42ec-1e29-08db014bec63
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2023 16:23:00.4713
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d4gKWSD7xi9mI40xEbZIKLS6PbYMhmK8m68rtlKYo5qOP4m//eIsDvcCuL3Sl9VqVpERkKMMOaKlEH0TlPxGwb5nEzFe/qFqpgDFjEqnIEw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5988
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 28, 2023 at 05:04:13PM +0800, Jiapeng Chong wrote:
> The function __b44_cam_read() is defined in the b44.c file, but not called
> elsewhere, so remove this unused function.
> 
> drivers/net/ethernet/broadcom/b44.c:199:20: warning: unused function '__b44_cam_read'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3858
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Thanks,

This seems to have been the case since '__b44_cam_read' was
created via some refactoring in 2007 by

753f492093da ("[B44]: port to native ssb support")

But I'm not sure this warrants a fixes tag.

Reviewed-by: Simon Horman <simon.horman@corigine.com>