MIME-Version: 1.0
References: <20230128055214.33648-1-jamiemdouglass@gmail.com> <f8590655-3869-d905-ebad-347b8c9ae8dd@linaro.org>
In-Reply-To: <f8590655-3869-d905-ebad-347b8c9ae8dd@linaro.org>
From:   Jamie Douglass <jamiemdouglass@gmail.com>
Date:   Sun, 29 Jan 2023 09:30:57 +1100
Message-ID: <CAETzdaEjfCbaGj8UeBsAZGbZnvOHgMP9KTCyxsY46qL5MxUhzg@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory
 overlap with SMEM region
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        Petr Vorel <petr.vorel@gmail.com>,
        Dominik Kobinski <dominikkobinski314@gmail.com>,
        Konrad Dybico <konrad.dybico@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

My apologies, I completely forgot that I did that!

That change was necessary, because extending the reserved region
past 0x7000000 creates another memory overlap, this time with the
mpss_mem region:
               OF: reserved mem: OVERLAP DETECTED!
               reserved@6c00000 (0x0000000006c00000--0x0000000007200000)
               overlaps with memory@7000000
               (0x0000000007000000--0x000000000ca00000)

So my original patch is correct.

Thanks,
Jamie


On Sun, 29 Jan 2023 at 01:30, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 28.01.2023 06:52, Jamie Douglass wrote:
> > A previously committed reserved memory region was overlapping with the
> > SMEM memory region, causing an error message in dmesg:
> >       OF: reserved mem: OVERLAP DETECTED!
> >       reserved@5000000 (0x0000000005000000--0x0000000007200000)
> >       overlaps with smem_region@6a00000
> >       (0x0000000006a00000--0x0000000006c00000)
> > This patch splits the previous reserved memory region into two
> > reserved sections either side of the SMEM memory region.
> >
> > Signed-off-by: Jamie Douglass <jamiemdouglass@gmail.com>
> > ---
> >  arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> > index 79de9cc395c4..5e375ea73c79 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> > @@ -53,8 +53,13 @@ cont_splash_mem: memory@3400000 {
> >                       no-map;
> >               };
> >
> > -             removed_region: reserved@5000000 {
> > -                     reg = <0 0x05000000 0 0x2200000>;
> > +             reserved@5000000 {
> > +                     reg = <0x0 0x05000000 0x0 0x1a00000>;
> > +                     no-map;
> > +             };
> > +
> > +             reserved@6c00000 {
> > +                     reg = <0x0 0x06c00000 0x0 0x400000>;
> I think you made this 0x200000 too small, unless there
> is supposed to be functional change.
>
> Konrad
> >                       no-map;
> >               };
> >       };