MIME-Version: 1.0
References: <20230109123216.4974-1-fengqi706@gmail.com> <nycvar.YFH.7.76.2301201849090.1734@cbobk.fhfr.pm>
In-Reply-To: <nycvar.YFH.7.76.2301201849090.1734@cbobk.fhfr.pm>
From:   qi feng <fengqi706@gmail.com>
Date:   Sun, 29 Jan 2023 10:59:09 +0800
Message-ID: <CACOZ=ZWB3grJKn7wAZEZ0BDyN7KJF4VWUTNs-mPxeoW_oiR7=g@mail.gmail.com>
Subject: Re: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID
To:     Jiri Kosina <jikos@kernel.org>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        fengqi <fengqi@xiaomi.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,
Our Bluetooth Handle needs the focus function, which is missing in the
current map
If our setting is unreasonable, do you have other suggested values

thanks

Jiri Kosina <jikos@kernel.org> =E4=BA=8E2023=E5=B9=B41=E6=9C=8821=E6=97=A5=
=E5=91=A8=E5=85=AD 01:51=E5=86=99=E9=81=93=EF=BC=9A
>
> On Mon, 9 Jan 2023, Qi Feng wrote:
>
> > From: fengqi <fengqi@xiaomi.com>
> >
> > Our HID device need KEY_CAMERA_FOCUS event to control camera, but this
> > event is non-existent in current HID driver. So we add this event in
> > hid-input.c
> >
> > Signed-off-by: fengqi <fengqi@xiaomi.com>
> > ---
> >  drivers/hid/hid-input.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index 9b59e436df0a..22cca3406b5c 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -1105,6 +1105,7 @@ static void hidinput_configure_usage(struct hid_i=
nput *hidinput, struct hid_fiel
> >               case 0x0e5: map_key_clear(KEY_BASSBOOST);       break;
> >               case 0x0e9: map_key_clear(KEY_VOLUMEUP);        break;
> >               case 0x0ea: map_key_clear(KEY_VOLUMEDOWN);      break;
> > +             case 0x0ee: map_key_clear(KEY_CAMERA_FOCUS);    break;
> >               case 0x0f5: map_key_clear(KEY_SLOW);            break;
> >
> >               case 0x181: map_key_clear(KEY_BUTTONCONFIG);    break;
>
> [ CCing Benjamin ]
>
> Hi,
>
> so according to HUT 1.3.0, 0xeb-0xef are Reserved for now, so I'd be a
> little bit hesitatnt to but this into the generic mapping, as later HUT
> revision might define this in a different way.
>
> Which devices are known to be producing this?
>
> --
> Jiri Kosina
> SUSE Labs
>