Date:   Sun, 29 Jan 2023 17:17:56 +0800
From:   Ming Lei <ming.lei@redhat.com>
To:     Zhong Jinghua <zhongjinghua@huawei.com>
Cc:     axboe@kernel.dk, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
        yukuai3@huawei.com
Subject: Re: [PATCH-next v3] blk-mq: cleanup unused methods:
 blk_mq_hw_sysfs_store
Message-ID: <Y9Y5xDuUU28axCs5@T590>
References: <20230128030419.2780298-1-zhongjinghua@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230128030419.2780298-1-zhongjinghua@huawei.com>
Precedence: bulk

On Sat, Jan 28, 2023 at 11:04:19AM +0800, Zhong Jinghua wrote:
> We found that the blk_mq_hw_sysfs_store interface has no place to use.
> The object default_hw_ctx_attrs using blk_mq_hw_sysfs_ops only uses
> the show method and does not use the store method.
> 
> Since this patch:
> 4a46f05ebf99 ("blk-mq: move hctx and ctx counters from sysfs to debugfs")
> moved the store method to debugfs, the store method is not used anymore.
> 
> So let me do some tiny work to clean up unused code.
> 
> Signed-off-by: Zhong Jinghua <zhongjinghua@huawei.com>

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming