From:   =?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     linux-kernel@vger.kernel.org
Cc:     =?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Andy Whitcroft <apw@canonical.com>,
        Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH] checkpatch.pl: Relax commit ID check to allow more than 12 chars
Date:   Sun, 29 Jan 2023 13:34:31 +0100
Message-Id: <20230129123431.1282427-1-j.neuschaefer@gmx.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Y8aGokvwFWc=;kCLUfMKfd2LdofXYZe7mqHXvUga
 QJi5uKVtbXRUMmtsqDWJIdRfTkz+KrHFbMt8aigVlWkAvPwvEhwsIRH1LGDM9YFB5fDSGO/Yg
 PZ8R3eaT4agmYz+spbIPlGLrQBmwL1Yw6Jm7jWrhUECL0+mycgd4+j3EJpZWzvCWTS7Kp+Xye
 cSVJ0uA9RCTIF1q/upBId6PUvpJxVF2YF8s+mJHDUywSVTwNyBNC8KgDyoEXHsKGD5Ry35SDX
 o1Q47g8gcXwzO5EitHiyzZlDiMFsPXWJMLrXPWE6aA0cKnSNZEm8+ZbdPJR+9NK3R2sTHC0T6
 uvoByI7d988cJmv9d4pNLTVi0fChdgKA7WTsthT3T3z4cu4iX9KMlPBEQa9wNIrijLM2I5dpj
 7gk+ge+xtAbR1jczRJG3L0LSM1jP54da1r/OoH+he4/1k1awIdrauwsf+KH6yAAA3JN/6AQhn
 cGFBKW/EriloXIMOKFBFt844knPm1cCLJfbmCYiIvKQqQP+Z1jWebux1FT5pnxxL8eSGwFrdl
 KAzZq3N7BzN9IcX8a+sIh5W+qt+psNJzsJlADv9LoUwM53eq8CbekmdqTHorckQ3kwzUZPg8h
 DUVP9nDjLHIOQ/wsV/mxA7BD86J6Ox1GZgbrpaajlEKh74tOLBKO6ABpqWnu6m7Af++0BCWCx
 UN/uv6iNiEZ5St7Ma+RmT5ra7aP8iNCIGvCOm1A+YWudRwzSNywTqEYD6bVyrprUhvN/Qx1QB
 gRt7hnXQsj+p4Y0nKs12uJGKYkF5r2TVMifQmsyF8jlteup07sy8vyqWC9zp/BkKlRFufvhdQ
 1pyt89R9G7f+lXl2tcFC/DKiZDtIkKWNgD02jerZzjLg1KeT5XW6roouhalvfWdblY0Md5DfJ
 R2CLHFWJKs1QnBwNXP5r7LBPPeMr/J2jzb9WX9AtFHodqKzdK6W7FlTZ9JF49v30f3PYwkCXz
 OsPPf7xnyFuC+R9ndPPpa6XGbmg=
Precedence: bulk

By now, `git log --pretty=3D%h` (on my copy of linux.git) prints commit
hashes with 13 digits, because of the number of objects.

Relax the rule in checkpatch.pl to allow a few more digits (up to 16).

Signed-off-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>
=2D--
 scripts/checkpatch.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 78cc595b98ce1..3a2c8b5426191 100755
=2D-- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3177,7 +3177,7 @@ sub process {
 				$tag_case =3D 0 if $tag eq "Fixes:";
 				$tag_space =3D 0 if ($line =3D~ /^fixes:? [0-9a-f]{5,} ($balanced_par=
ens)/i);

-				$id_length =3D 0 if ($orig_commit =3D~ /^[0-9a-f]{12}$/i);
+				$id_length =3D 0 if ($orig_commit =3D~ /^[0-9a-f]{12,16}$/i);
 				$id_case =3D 0 if ($orig_commit !~ /[A-F]/);

 				# Always strip leading/trailing parens then double quotes if existing
@@ -3194,7 +3194,7 @@ sub process {
 			if ($ctitle ne $title || $tag_case || $tag_space ||
 			    $id_length || $id_case || !$title_has_quotes) {
 				if (WARN("BAD_FIXES_TAG",
-				     "Please use correct Fixes: style 'Fixes: <12 chars of sha1> (\"<=
title line>\")' - ie: 'Fixes: $cid (\"$ctitle\")'\n" . $herecurr) &&
+				     "Please use correct Fixes: style 'Fixes: <12-16 chars of sha1> (=
\"<title line>\")' - ie: 'Fixes: $cid (\"$ctitle\")'\n" . $herecurr) &&
 				    $fix) {
 					$fixed[$fixlinenr] =3D "Fixes: $cid (\"$ctitle\")";
 				}
=2D-
2.39.0