Message-ID: <1b466057ed2e91b05388afbb5791639eb8abdd59.camel@linux.ibm.com>
Subject: Re: [PATCH-next v2 2/2] scsi: fix iscsi rescan fails to create
 block device
From:   James Bottomley <jejb@linux.ibm.com>
Reply-To: jejb@linux.ibm.com
To:     Zhong Jinghua <zhongjinghua@huawei.com>,
        gregkh@linuxfoundation.org, martin.petersen@oracle.com,
        hare@suse.de, bvanassche@acm.org, emilne@redhat.com
Cc:     linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        yi.zhang@huawei.com, yukuai3@huawei.com
Date:   Sun, 29 Jan 2023 12:30:30 -0500
In-Reply-To: <20230128094146.205858-3-zhongjinghua@huawei.com>
References: <20230128094146.205858-1-zhongjinghua@huawei.com>
         <20230128094146.205858-3-zhongjinghua@huawei.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 2023-01-28 at 17:41 +0800, Zhong Jinghua wrote:
> This error will cause a warning:
> kobject_add_internal failed for block (error: -2 parent: 1:0:0:1).
> In the lower version (such as 5.10), there is no corresponding error
> handling, continuing
> to go down will trigger a kernel panic, so cc stable.

Is this is important point and what you're saying is that this only
panics on kernels before 5.10 or so because after that it's correctly
failed by block device error handling so there's nothing to fix in
later kernels?

In that case, isn't the correct fix to look at backporting the block
device error handling:

commit 83cbce9574462c6b4eed6797bdaf18fae6859ab3
Author: Luis Chamberlain <mcgrof@kernel.org>
Date:   Wed Aug 18 16:45:40 2021 +0200

    block: add error handling for device_add_disk / add_disk

?

James