Message-ID: <a4f4392f-cc15-86e0-9b63-12678b65d58f@kernel.org>
Date:   Sun, 29 Jan 2023 11:14:34 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH v4 1/2] ip/ip6_gre: Fix changing addr gen mode not
 generating IPv6 link local address
Content-Language: en-US
To:     Thomas Winter <Thomas.Winter@alliedtelesis.co.nz>,
        davem@davemloft.net, yoshfuji@linux-ipv6.org, pabeni@redhat.com,
        edumazet@google.com, kuba@kernel.org, a@unstable.cc,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230127025941.2813766-1-Thomas.Winter@alliedtelesis.co.nz>
 <20230127025941.2813766-2-Thomas.Winter@alliedtelesis.co.nz>
From:   David Ahern <dsahern@kernel.org>
In-Reply-To: <20230127025941.2813766-2-Thomas.Winter@alliedtelesis.co.nz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

A couple of nits.

On 1/26/23 7:59 PM, Thomas Winter wrote:
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index f7a84a4acffc..0065b38fc85b 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3355,7 +3355,7 @@ static void addrconf_addr_gen(struct inet6_dev *idev, bool prefix_route)
>  	}
>  }
>  
> -static void addrconf_dev_config(struct net_device *dev)
> +static void addrconf_eth_config(struct net_device *dev)

why the rename of this function? It does more than ethernet config.


>  {
>  	struct inet6_dev *idev;
>  
> @@ -3447,6 +3447,30 @@ static void addrconf_gre_config(struct net_device *dev)
>  }
>  #endif
>  
> +static void addrconfig_init_auto_addrs(struct net_device *dev)

this one should be 'addrconf_' to be consistent with related function names.