Date:   Sun, 29 Jan 2023 19:35:15 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-parisc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: tulip: Fix a typo ("defualt")
Message-ID: <Y9a8Y7BZ7wIIZFbm@corigine.com>
References: <20230129154005.1567160-1-j.neuschaefer@gmx.net>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230129154005.1567160-1-j.neuschaefer@gmx.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckxKaGNERUtsSVdEZXMzYllBOG0wbHlyQWYrbm1wRWtKbmROWHRyMUpOYW9k?=
 =?utf-8?B?dldqVzlXT2FYdDNPcjZnalVlR2lVWnRnTUhYRGpIT3JvdmxaeFIwOGFwckhX?=
 =?utf-8?B?QnNEQzVZOFZRQTNTZGxya2RaU3B6UmtyV0dabmRJa1htNVJqOGpEd3l6eWZB?=
 =?utf-8?B?THJ3akgzT1Y3Y2ZrZWdSM2Z6dVBhZVlVSTVFOEdkREFJMGdDSFVOS3IzcnRs?=
 =?utf-8?B?Mks2bXU3L2VBZFpOWEVIS2NLQmxUajdCcmhJR0RSSnJwc0g3K1pNTm1KZEQv?=
 =?utf-8?B?cmVMcVQwN2NrNFkrMFlmejd0T2MzZFVSRDJYWDczbWVxNlNpRklSMlYzaWp1?=
 =?utf-8?B?YkFyRmg4Q0tpZW1obnJnSHNOODR4N2Z1aFpTc0lvTkZkcHlTZ25HM084QnVM?=
 =?utf-8?B?Ui9xaWZ5aVcwSUZTNVJLL2tGZ294VStadVV6VWpQMHZDMXBlaVNqazdPU2N1?=
 =?utf-8?B?OStKdzZSeG9taHAwdXBZTzVxM0lRNTZERmFoMnNsMWdmbEVGYi94ZGtBTi9l?=
 =?utf-8?B?M3czUFZlUDZZQWNYVUhpNXJVK2hNVzcvbHFJaThYR3ZKQXNNdGdFYUlXZ1Ux?=
 =?utf-8?B?WkFTVldwUUdzeGtEemE0a2lmYmNQczBxNDhUVWRMWkVQQU1DUHMvOVlOQzd4?=
 =?utf-8?B?UU9EWWVUb1VKcWN2eU9CMTlmbEFEM3B0eGhPdGZuZ2d5VXZzZFBuR2tGWTZO?=
 =?utf-8?B?RUVVK2JHWkFwTGRjWiticXlsd25pQisveW5OU3lBbGdkblBmalJqSkdxdFMw?=
 =?utf-8?B?K2ViZ3VSNmpwNGhwL2RjK05RN0VmbnBZTHRSRWlEbUZva1o4dkhVUjFRTnNR?=
 =?utf-8?B?bUd4dUtLZXU2UzYxbXpTSmdYcWE1eVRVemZuNXBTcUZiTzQvZ25COHpMMDVF?=
 =?utf-8?B?YXVtdTNjVTN5RGJQVWhoK0lDMEprTDNQU1kreDk5R1FuL2UrWGZDRkN4MkZZ?=
 =?utf-8?B?ZnlqUGZWSHhLU1h6NXJLT3FyaWtBYldJYmg1K2VxU1lOeUdKUCtBcUJmN3F5?=
 =?utf-8?B?Q3plMGFvMTF4STJvNXNmRXhMT1hvRHpER1BCeWVXQ3pLeUpOaDE5a1dZcTgr?=
 =?utf-8?B?eVQ5OWRUNzBBdHhVMjVHNzdNK1dQOThBY3dzYjJSb0I2a0tzMVhaU2swa28x?=
 =?utf-8?B?YmN4ZXhRMktScE9PM2R3WElBaVJBNkRWOWZhQnFxTE1RNUFaSnlvMURaaWpp?=
 =?utf-8?B?c2Nxa08zckVmSEV6S0FpS0hZeGZBa3BqRk80QUxVRnFHUElTaVEwMTJBVXVx?=
 =?utf-8?B?dlBSSUhjbHB3c0NCa2xQYTJJRmU0UURKdGVsNWVzRUkzL2ord3NaaWlJZ3hM?=
 =?utf-8?B?TTJzM0RlWWtHT3cyNEVJYkNhZUtqOS9QVUVKclpKZWRGRmFTb25HNWtaVWJS?=
 =?utf-8?B?d3JMT0R5QnZEbldXZGZ4aEZoOUJ3Mjc5blJZYUZsK1lXVFFDSjdENUFPdDZ3?=
 =?utf-8?B?M201NjBIWnVNaWtMRExab1ord1RMQmFzZkFxd1ZlNHBJZ1F4aXVORnd0dUtU?=
 =?utf-8?B?cDBIdkFmRDdKSFZGQjNBcHAvemtTZlFhQTVONVJReHpxQUpSa05pVkZwVE9Q?=
 =?utf-8?B?WHZPU0pSNnc0RCs4bklmdEV5VGptTWhIa21QWDVHdm1OTDZ0YWVCMUFicmdD?=
 =?utf-8?B?Q1F1bDVia2loRmJKaWRwT2dTWVE2eVdzN3UvRnZ5bURmR05HZVdOeWNqdmJS?=
 =?utf-8?B?ZkJuNW95bk5hd1M4V3d2YjI5ZHhaU0ZBdS9aR2lpRSt4NnVoUE8wUkZDa0pm?=
 =?utf-8?B?WFVxb0VobkFzL2VhdnNqZnNjWGxwVnpvNWRZeU5rQlhPQnFDb1FocXc3bGRp?=
 =?utf-8?B?bk5rMVpqY25OWTd0bWlVM1ZZSlFNOEwrTURIdXNIVkJJYllMMzhCWmlJUGFl?=
 =?utf-8?B?YVpGdzdwb0h4RDhiK0tlbS9LcGsyZFE0L29tSml2Q1ljTVZaT0VXZUFPL01n?=
 =?utf-8?B?TC83N21zOXFpZ0d2YW9MaGIxS1U2SjJoSEZwVzZQWFdSR2Q4eVhaRFFnTHQz?=
 =?utf-8?B?SDBuOVV0cVdZbGJBeThQNEl5SXRzQXVUbk5mSkV0L3p1ZjZ6dExqaW5wK1Mw?=
 =?utf-8?B?NnRDZnNoRjR0NmVKZnFuMTJZOUI1N3JCcTY2Yzl0dWZSaVRsYWIwSFQ3aWd6?=
 =?utf-8?B?UnhDMTZKQmNaSHgyMy81Z1ZSR003YzJRaDdDdzdYOXVRcGxVbkVUTXd2d1po?=
 =?utf-8?B?UE15WjNTVGtmQWVrK0w5WTJhaUVsZ2hVRE5zd2lyNXo4NFJCUFl2NURZYmN6?=
 =?utf-8?B?cFhPRlNnZFovL3RQT3RGY3dOK0lnPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef972fc3-979f-4d12-bf75-08db022793e9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2023 18:35:21.5356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N5Uh5Qt/mdZIRmgS43FUnXE/LX2SSbud5lm9kg2w4eIs+CJF8noQu+mDMTRWUznmzilQ1mlaXVdQxaDj8hgLSYNCYI+gOIAtuetJNJ5skg4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4773
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 29, 2023 at 04:40:05PM +0100, Jonathan Neuschäfer wrote:
> Spell it as "default".
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Looks good :)

There also seems to be a misspelling of heartbeat (as hearbeat) on line 277.
Perhaps it would be good to fix that at the same time?

> ---
>  drivers/net/ethernet/dec/tulip/tulip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/dec/tulip/tulip.h b/drivers/net/ethernet/dec/tulip/tulip.h
> index 0ed598dc7569c..0aed3a1d8fe4b 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip.h
> +++ b/drivers/net/ethernet/dec/tulip/tulip.h
> @@ -250,7 +250,7 @@ enum t21143_csr6_bits {
>  	csr6_ttm = (1<<22),  /* Transmit Threshold Mode, set for 10baseT, 0 for 100BaseTX */
>  	csr6_sf = (1<<21),   /* Store and forward. If set ignores TR bits */
>  	csr6_hbd = (1<<19),  /* Heart beat disable. Disables SQE function in 10baseT */
> -	csr6_ps = (1<<18),   /* Port Select. 0 (defualt) = 10baseT, 1 = 100baseTX: can't be set */
> +	csr6_ps = (1<<18),   /* Port Select. 0 (default) = 10baseT, 1 = 100baseTX: can't be set */
>  	csr6_ca = (1<<17),   /* Collision Offset Enable. If set uses special algorithm in low collision situations */
>  	csr6_trh = (1<<15),  /* Transmit Threshold high bit */
>  	csr6_trl = (1<<14),  /* Transmit Threshold low bit */
> --
> 2.39.0
>