Date:   Sun, 29 Jan 2023 22:53:17 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Chris Healy <cphealy@gmail.com>
Cc:     hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        neil.armstrong@linaro.org, khilman@baylibre.com,
        netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        jeremy.wang@amlogic.com, Chris Healy <healych@amazon.com>
Subject: Re: [PATCH 1/1] net: phy: meson-gxl: Add generic dummy stubs for MMD
 register access
Message-ID: <Y9bqzZw4z6JWGeI6@lunn.ch>
References: <20230129022615.379711-1-cphealy@gmail.com>
 <Y9akLWJfigajMuQP@lunn.ch>
 <CAFXsbZppb5tDxR9tO7RN76=rt04MdAUU16HhyNizJBtAXtq+fg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFXsbZppb5tDxR9tO7RN76=rt04MdAUU16HhyNizJBtAXtq+fg@mail.gmail.com>
Precedence: bulk

> > Hi Chris
> >
> > This change in itself makes sense. But i wounder if we should also
> > change phy_init_eee(). It reads the EEE Ability register. The 2018
> > version of the standard indicates the top two bits are reserved and
> > should be zero. We also don't have any PHY which supports 100GBase-R
> > through to 100Base-TX. So a read of 0xffff suggests the PHY does not
> > support EEE and returning -EPROTONOSUPPORT would be good.
> >
> This seems like a good change to make in phy_init_eee().  I should be
> able to do this.  Can this be done in a subsequent patch or does this
> need to be present to land this meson specific PHY patch?

They are independent, submit them in whatever order you want. But
doing it first will make it easier to test it actually works.

      Andrew