Date:   Mon, 30 Jan 2023 10:37:07 +0800
From:   Oliver Sang <oliver.sang@intel.com>
To:     Shakeel Butt <shakeelb@google.com>
CC:     "Huang, Ying" <ying.huang@intel.com>,
        kernel test robot <yujie.liu@intel.com>,
        <oe-lkp@lists.linux.dev>, <lkp@intel.com>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <feng.tang@intel.com>,
        <zhengjun.xing@linux.intel.com>, <fengwei.yin@intel.com>
Subject: Re: [linux-next:master] [mm] f1a7941243: unixbench.score -5.1%
 regression
Message-ID: <Y9ctU3HtkAC7G05Q@xsang-OptiPlex-9020>
References: <202212051324.182a6363-yujie.liu@intel.com>
 <CALvZod4CD+O7-ynGAHU-6vxE6CbSmuQei1=SVJsx0zFfQdmV2g@mail.gmail.com>
 <875yepfe4j.fsf@yhuang6-desk2.ccr.corp.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <875yepfe4j.fsf@yhuang6-desk2.ccr.corp.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTJray9kYmlLeDNXaWpIM0tsU1lVNTVOQ21NbFp6UEdkY1F6cWZ1aEJaNjBU?=
 =?utf-8?B?cnBxdzNEbjhrZm5Kd1ZCQlk5VmhsUUQ1YUpzQ2VNQmdsaFE0UGQyS0JUUHAz?=
 =?utf-8?B?UHZJeUw0dHZhSFd2SjJhaFU1MEFFUS9xM2QvZEgyRUZXNnkyelp6c3c3MnZI?=
 =?utf-8?B?MUhwMFJIS0ZhWk44Ny9kbFh6TlJPUUVxbjVnTzdJRm1wK0Z0VlNzYjIrZmdr?=
 =?utf-8?B?UlBlZUpJWUhUeEdsaXM0WE92dHBBRUtnK2VmOU1wbUFGOVVReThBV2w3UXo1?=
 =?utf-8?B?M2NpeVVXbDhNM1FtMVN5bkNuVndVR1RoZTdRZXFaTW1yeEt0NHdMaUJjOTQ3?=
 =?utf-8?B?aVRuQzRycVVMZ1IzYlRNcm1lQjlYcG1JbTdUQmZsL1lKWm1FSTRLcG91NVRa?=
 =?utf-8?B?Z1hEbmJJY1ZFL0N0amNpZzF5Y2llbnNWTVprcUFzWjhGUHgxRTFmVmM5MkxU?=
 =?utf-8?B?eDUwOGNxTVZMOERiUEdsQkVQZHVDRlJ1d1N4bGltZ2xtYzJKZ1BkVXN6UGI0?=
 =?utf-8?B?MHBrT0VHM1poZ1ZQdTBXU1BiOEN0UlYvMWVuOWdweEJXRVV3eEJJdE5QNVVk?=
 =?utf-8?B?aURGOExkTkp6RG8zbVRqdUx6Y0R0dHVJSTR0MmtpaXcxL0JJZCtYV21Majho?=
 =?utf-8?B?aHAyNHNXUTBnTHhqRjhKQmgvb01HV2lrOE4vbU9RRkRlU2JQOHRaV04zb2Jj?=
 =?utf-8?B?T2tVTEZSQVdiUmZlRVFPQmhnaDhmbGx3eGdRR3gyMnMwZUVxZERvNnpIUGV0?=
 =?utf-8?B?eWZiRGVNWWlDMkZkcFlKeHhuRnV0ZEhLZXRid2JwQ2llT2hsSFpmdGY4cDlo?=
 =?utf-8?B?amgreHE1dEJuWVRmUFRRTEY4RWZZOHhxbVMxaFQwWTVKb3NmdG1WUEgvMDlV?=
 =?utf-8?B?ck80cGJpNDUySVlac2xabWl3anJPZXJYbmo3Y2pISTUwbjd2VTNkSHpJY2h3?=
 =?utf-8?B?WGJMOU9namVBVkdjMGdMSEMwSXB5R2dBUnRBS2VLMSs5a0MvRXlwSmdVNjBF?=
 =?utf-8?B?dHlsQVFEQmczRFVJbjVkTHhTYmZtQVF3RGM0RzRPZzBIU04yZ2xtTHJ1L0V2?=
 =?utf-8?B?QkVUV2VZYS9RWE5ET1IyS0lFeVM0cjluQnhtNmV0S0VHSGJIWGp5djdoalYr?=
 =?utf-8?B?S2ZLR1pYRDdKcDQ0dkdtUEk0WC9DbXFJOU16czNSS0hEY0MvbzZ3VUgxbWZI?=
 =?utf-8?B?dFVEb001WFZTcTdJWktRbmVYRlFQUjB6MWJObnF2Yk1Qc1pmRjdiandPS2Zk?=
 =?utf-8?B?RXd0UGFuZTY4bTljVHppZHpDOGFxUi9uVTZwWHlKZXR1SEhRblJPMU42cDVL?=
 =?utf-8?B?UHRIbVg3N3BJRDJjSWgxQUp0VDg0REVUTkFkYXlHQkpIRUJrRUdxc2J4YVJh?=
 =?utf-8?B?MTlYM3BJQmhzcXAySlZUZkVJNVhIbWJ5K3NzOG5vT2JHRlpOV0dTd2VRcnly?=
 =?utf-8?B?NVBGREYrVjAxLzhIc1JLZWwvWVFWU3Y2MUxyenZZNkYwMUJwcTlvZlVNQzU5?=
 =?utf-8?B?bzhuR09RQlJlT3ErU1NLaTdNWmkwYnN2Q1BjajVxUW5NZlE0aStkQUFWbi96?=
 =?utf-8?B?cmhVS01SSnZ6SnpIaTlCbjF2a3BBdSt5VURYQVhBVmhzN0VUMWNTUjMxbjNn?=
 =?utf-8?B?VWdSVWhKY1IrWS9PWmFkUlBlY3dzdVpraDZpdGRVOURDVG43NHE0V3NyeHJq?=
 =?utf-8?B?UGRPTklBNVYzb1VmbjZyeU1KSSs5TlpVRWx0OFlFeFpLRHI3WHBlbkl2RG16?=
 =?utf-8?B?YTVBZzhHVUYvSFd2dGZIYXRxcFJiODBZaW1iZktCYnM3c0lvcHVQTXVEb2ZU?=
 =?utf-8?B?ZU4xMW9lNlVCWXdnQlQrYmpYbk4yUmMzU2RrcHlERWQ2aEVyRGtOOGNxenZH?=
 =?utf-8?B?a09XRG1MTnJweG1XckUyQ2VKbE9iMjJRZjJOQ3pVcjhKODRhLzVxODVLbGhH?=
 =?utf-8?B?c1paTFN3R3o4cW5oQ2ZGZWNaZElJNFNoMUoxbERwM1YzdHNPYlhGK2M0QXlM?=
 =?utf-8?B?a3JrditUL2g0d2ZsdGVJR0VocUhwenZ4cTZadWtISWwrK1hySTRvSGJsQy9M?=
 =?utf-8?B?QXI2cERrOHB6OEl6Y2dBVmtpRmFVLzBGQU5UKzcxYlhqbm5nRjJ4NXo5VU96?=
 =?utf-8?B?ZGlkNWNzZWsyTHVNWXhBczlOekxiK3J0TEF5dld6Z3laSmEyaE95TUE2VXJj?=
 =?utf-8?B?WFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 383e486e-101d-409e-cc41-08db026ae822
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6779.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 02:37:18.9315
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iECXHKB9nXyHmeebOJNVcjhn0JwOEbyrw2M1xBG0+x6flHWF8hH6dq3qmZRdjnds/pk9YCeo1s7Y4o+bCdfHWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7115
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Shakeel Butt,

please be noted we noticed the regression is still existing after this commit
merged to mainline, we reported as
https://lore.kernel.org/all/202301301057.e55dad5b-oliver.sang@intel.com/

On Tue, Dec 06, 2022 at 10:41:00AM +0800, Huang, Ying wrote:
> Shakeel Butt <shakeelb@google.com> writes:
> 
> > On Sun, Dec 4, 2022 at 9:56 PM kernel test robot <yujie.liu@intel.com> wrote:
> >>
> >> Greeting,
> >>
> >> FYI, we noticed a -5.1% regression of unixbench.score due to commit:
> >>
> > [...]
> >> 9cd6ffa60256e931 f1a7941243c102a44e8847e3b94
> >> ---------------- ---------------------------
> >>          %stddev     %change         %stddev
> >>              \          |                \
> >>       7917            -5.1%       7509        unixbench.score
> >
> > What is unixbench.score?
> 
> Should be benchmark throughput.
> 
> >>      10485           -12.1%       9216        unixbench.time.maximum_resident_set_size
> 
> This should reflect accuracy change of per_cpu_counter.
> 
> >>   37236706            -5.1%   35324104        unixbench.time.minor_page_faults
> 
> The reduction is same as benchmark score.  So I think this reflect the
> nature of time-bound testing (instead of workload-bound).
> 
> > For above two, is negative change good or bad?
> >
> >>       0.98 ą 20%      +0.7        1.64 ą 38%  perf-profile.calltrace.cycles-pp.link_path_walk.path_openat.do_filp_open.do_sys_openat2.__x64_sys_openat
> >>       2.12 ą 19%      +0.8        2.96 ą 13%  perf-profile.calltrace.cycles-pp.handle_mm_fault.do_user_addr_fault.exc_page_fault.asm_exc_page_fault
> >>       2.35 ą 13%      +0.9        3.28 ą 13%  perf-profile.calltrace.cycles-pp.__handle_mm_fault.handle_mm_fault.do_user_addr_fault.exc_page_fault.asm_exc_page_fault
> >>       0.14 ą 74%      +0.4        0.55 ą 32%  perf-profile.children.cycles-pp.do_task_dead
> >>       0.04 ą223%      +0.4        0.47 ą 49%  perf-profile.children.cycles-pp.__mmdrop
> >
> > Also how should I interpret the above perf-profiles?
> 
> It appears that the changes of handle_mm_fault() and __mmdrop() are
> related to the code of the commit?  That is, for this specific workloads
> (not so unpractical), the operations become slower?
> 
> Best Regards,
> Huang, Ying
>