MIME-Version: 1.0
In-Reply-To: <CAH2r5msAxf7Wn2o298+P3zG6ChbuMhHYgVSUCCDCm0Cwh530HA@mail.gmail.com>
References: <CAH2r5muSiYCHbHg8zgF1jNiEyafXBhH_pcytudU-4_LQ6DyUmg@mail.gmail.com>
 <CAKYAXd-gKrZ4gZZjookTDSL9ATLtnapQrciJpFH=LzX_8-ZO9g@mail.gmail.com> <CAH2r5msAxf7Wn2o298+P3zG6ChbuMhHYgVSUCCDCm0Cwh530HA@mail.gmail.com>
From:   Namjae Jeon <linkinjeon@kernel.org>
Date:   Mon, 30 Jan 2023 13:08:51 +0900
Message-ID: <CAKYAXd_mamiP2bDT73OvvLXsS_haniD5MDiQDedQUhUv23JSbg@mail.gmail.com>
Subject: Re: [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support
To:     Steve French <smfrench@gmail.com>
Cc:     CIFS <linux-cifs@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

2023-01-30 12:15 GMT+09:00, Steve French <smfrench@gmail.com>:
> On Sun, Jan 29, 2023 at 7:57 PM Namjae Jeon <linkinjeon@kernel.org> wrote:
>>
>> 2023-01-30 9:01 GMT+09:00, Steve French <smfrench@gmail.com>:
>> Hi Steve,
>>
>> > Fix indentation of server config options, and also since
>> > support for very old, less secure, NTLM authentication was removed
>> > (and quite a while ago), remove the mention of that in Kconfig, but
>> > do note Kerberos (not just NTLMv2) which are supported and much
>> > more secure.
>> >
>> > Signed-off-by: Steve French <stfrench@microsoft.com>
>> > ---
>> >  fs/ksmbd/Kconfig | 5 +++--
>> >  1 file changed, 3 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/fs/ksmbd/Kconfig b/fs/ksmbd/Kconfig
>> > index e1fe17747ed6..4153e5491435 100644
>> > --- a/fs/ksmbd/Kconfig
>> > +++ b/fs/ksmbd/Kconfig
>> > @@ -33,17 +33,18 @@ config SMB_SERVER
>> >     in ksmbd-tools, available from
>> >     https://github.com/cifsd-team/ksmbd-tools.
>> >     More detail about how to run the ksmbd kernel server is
>> > -   available via README file
>> > +   available via the README file
>> >     (https://github.com/cifsd-team/ksmbd-tools/blob/master/README).
>> >
>> >     ksmbd kernel server includes support for auto-negotiation,
>> >     Secure negotiate, Pre-authentication integrity, oplock/lease,
>> >     compound requests, multi-credit, packet signing, RDMA(smbdirect),
>> >     smb3 encryption, copy-offload, secure per-user session
>> > -   establishment via NTLM or NTLMv2.
>> > +   establishment via Kerberos or NTLMv2.
>> >
>> >  config SMB_SERVER_SMBDIRECT
>> >   bool "Support for SMB Direct protocol"
>> > + depends on SMB_SERVER
>> I am wondering this change is needed in this patch ? There is no patch
>> description for this change...
>
> The "depends on SMB_SERVER" is needed to fix the indentation -
> otherwise it thinks that "config SMB_SERVER_DIRECT" is at the same
> level of indentation as its parent (ksmbd)
> See before and after screenshots attached.
Thanks for explanation:)
Acked-by: Namjae Jeon <linkinjeon@kernel.org>

>
>
>
> --
> Thanks,
>
> Steve
>