Message-ID: <bbf7a435-f391-7158-b9f4-3742dd140ccb@amd.com>
Date:   Mon, 30 Jan 2023 11:26:06 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 3/5] ASoC: amd: acp: Refactor i2s clocks programming
 sequence
Content-Language: en-US
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        broonie@kernel.org, alsa-devel@alsa-project.org
Cc:     Sunil-kumar.Dommati@amd.com, ssabakar@amd.com,
        Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
        open list <linux-kernel@vger.kernel.org>,
        Basavaraj.Hiregoudar@amd.com, Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jia-Ju Bai <baijiaju1990@gmail.com>,
        Akihiko Odaki <akihiko.odaki@gmail.com>,
        Vijendar.Mukunda@amd.com,
        V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>
References: <20230109132104.1259479-1-venkataprasad.potturu@amd.com>
 <20230109132104.1259479-4-venkataprasad.potturu@amd.com>
 <92052eef-3c61-7f3e-75c1-09b76cd38e24@linux.intel.com>
From:   Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
In-Reply-To: <92052eef-3c61-7f3e-75c1-09b76cd38e24@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVVGK1hNTHVxd0NiVlB2dUxHNXptWXpkYkZ6cFhNMjhtcGZWanlwWlhCdmQy?=
 =?utf-8?B?Um1zVzd4QW81b0I5RDFlVmZ2TGxjM2RSK1c1bCtGK3BxczJYWTAybDBqUlp1?=
 =?utf-8?B?RW83S1FscmN2M2Q3bUh6N1RYT2kzYmlEcVp4bjlzbUVKR3ZlVWZVdy9vQUlv?=
 =?utf-8?B?V2V1d1N4Nytvdi9JbE9yK1JJL29JVzNORU9WOEZ0aFd6Z1ZWYzErRVhZditj?=
 =?utf-8?B?dU1uaUNmeGVkTmxEUGJYUFVYZVBxZTRDc2ZXbW9GZWFoVEJaZkdKRGQ2OEVi?=
 =?utf-8?B?K2doZ0VZWCtzbHlJUjA5dW5iQzhxejhXNE1lWStxY1JRdVVJdDZ0QitNWCtp?=
 =?utf-8?B?VGl4THpBZWZpSDFybWpDNXljZkhNZjlvVFgxaXJnS3ZVMndvenQ2bFNqN3cz?=
 =?utf-8?B?RzdwTDJaeGdUUTdpOFRFZmZmcDZ1VmJ5MnBlRDloTXloT2cvOEhuRWs1NnFZ?=
 =?utf-8?B?OFBsSnhZNUt4a1N3YjFoemlQZXZBL00rU25CRDV1VXQ0ODRralAvajRWcGcw?=
 =?utf-8?B?Ym1hRS9aVm5CQWtQVkNNdlJzRGorZDUwLytDSE9qTmQrUnNwUzI3NEN1TVJy?=
 =?utf-8?B?TXlWSXpjOUExdS9HNUo0a2k1QW5KUU00cmU3eklzT2oxV2F1TkhldHZ1WFBk?=
 =?utf-8?B?NHlYU0tZbkJXUzlhMW51UENIYWhFdElOMnJDSWRDdk0wakdKTkVhUytTK084?=
 =?utf-8?B?eGZ6VGVRMHpEUlo1cXYxK2FUNVRFUzBKU0NKNms2WVV6M0MwRVRFb3FiaW9J?=
 =?utf-8?B?Y09XeWVqbnFuREVXTTBHRHZsWC95a1duVFozaHB5UmN1Q1dqbmhEUEZTblRv?=
 =?utf-8?B?TjBjbWVJRW8zTE1JeUdNSTVaUUZZNkdFNFlPenRkWHVEZW5FTHUrYjFRUkdI?=
 =?utf-8?B?eE8wcDFTTlFxNGFsTjFoeG9OWFY5K0NwVWhFRnFLcUxZZHhXZm1JZlpMclgv?=
 =?utf-8?B?eEFwZC9FMDNyVEk3L1VpdmNoSko5Sjg0RVJRYnNsMzBobXRuWlU1OXg3akxT?=
 =?utf-8?B?bTRXVUFQdEZFcjFLZC9Yb2wzdUcxWDJkUld6TmxWSzgxRXJaSFpxbWY3TmJl?=
 =?utf-8?B?c3AwL2pDV0d3c2xRSWZ1ME9ZVFkxbXREc1V0ZjRRMlpPQll6SEhnU0pIeUVz?=
 =?utf-8?B?Q1lzdlArVHBMb1p1Zy9Wek94Q0g1TFRUMVp6Zk02VjRibEZObFdDbEN1SDlP?=
 =?utf-8?B?Vm5aWCtDakVkVXBLTHFlTEZZTHQ0VEVGandxaTlEZ2x2dnZLcHA3elF0OEZx?=
 =?utf-8?B?MytlOVZlS3JvblBDbE80MkY5dXhOdEM5OWVjSTZoeENqT2RzK0xOOW1KZkRz?=
 =?utf-8?B?K0pDTDgreFVST3k5ZXhxVy9mcjBTa1FRM0pXa1daSTBjMFhGVE9ON1JjcnVk?=
 =?utf-8?B?c2J1R2dhTlhKSkZnamhWVS9qNW5rbXhydzJuZ3crbmR1OC8yYWl0T1ZHdGcz?=
 =?utf-8?B?NUdvaGpFSUxRVStReUZUS01lOURYWWNzczAxc3I2MTBDc2hjdDIyK1ZKUkp5?=
 =?utf-8?B?TmF2UUk4Rk01djRHSTRubmo0blBnM0g1dWdZZ3QyUUJiQW16S3BSWWtsVnJB?=
 =?utf-8?B?MExjQXpyRG45WlVRVXdaNlF5QitVT1pUTm91N3JPOVVXMHZwQ1EwTW1VQ0VG?=
 =?utf-8?B?Vm02WlhncWRTSzlmbnplajBxcnprYjZUZjZkUjB4N2R6ZldYY1pEY2c0bFF5?=
 =?utf-8?B?bkFYTGE4UXh1VWdzUmNJQmhzaXFiTEREQ3RpU0ZaanRoY1JRV0hYOFlFem1o?=
 =?utf-8?B?S1dsNVV6UGIvSXNHVkVFaEc4d0U1ZUVWRjF0d1dDMDQrTEdmeFdva0l1R1d4?=
 =?utf-8?B?MXp3Z0N0dUxTTWRTSjE5cHB6bE1rNG9namk4bWRvenJ2MG40azI3a2pGSTNQ?=
 =?utf-8?B?c3NnQnNNYXNJVjJuV05NdGxwL0lsVys3ckV6dzJadW9KVm83SWdOTnkvdHJZ?=
 =?utf-8?B?VWNwV3RrMk9wdUF6dVVHVDBIN3U5d2MyZG9QdTRoR0Q5L2N4Ni9GcVY2TjBC?=
 =?utf-8?B?c2pZbjg1MlFtWUdNd0ZqQ1phV2hxTWlHL21hOFRLd3h1eUliUFAzdHQ1dTZq?=
 =?utf-8?B?ZmZxdm43aFoyTlkrak1ZV2crYkhENjdnWjFaUUVEM1hOMTBSL2NCU2tKK1pE?=
 =?utf-8?Q?HuZyQ5Fx+JP2Adq540QKWtj09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33ac2efb-0112-4d6b-0c67-08db028621f0
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5951.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 05:52:12.3654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0V6c7AGG4nqurA7ML1a79Y2GpzOLEX+6CDTWItkCyrPb7TseKxdsXwvfBFwS6mHQn4ZEvO4WHLurF35Ce707pg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4453
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/25/23 22:45, Pierre-Louis Bossart wrote:
Thanks for your time Louis.
> This patch adds new Sparse warnings [1]:
>
> sound/soc/amd/acp/acp-mach-common.c:189:35: error: restricted
> snd_pcm_format_t degrades to integer
> sound/soc/amd/acp/acp-mach-common.c:333:35: error: restricted
> snd_pcm_format_t degrades to integer
> sound/soc/amd/acp/acp-mach-common.c:478:35: error: restricted
> snd_pcm_format_t degrades to integer
> sound/soc/amd/acp/acp-mach-common.c:619:35: error: restricted
> snd_pcm_format_t degrades to integer
>
>> @@ -193,7 +163,11 @@ static int acp_card_rt5682_hw_params(struct snd_pcm_substream *substream,
>>   	struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
>>   	struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
>>   	int ret;
>> -	unsigned int fmt;
>> +	unsigned int fmt, srate, ch, format;
>> +
>> +	srate = params_rate(params);
>> +	ch = params_channels(params);
>> +	format = 8 * params_format(params);
> This last line looks suspicious, no? format-to-physical-size conversions
> should be using existing macros.
>
> Should it be
>
> format = params_physical_width(params);
>
> ?

Yes, we will use params_physical_width(params) and update it in the next 
patch.

Thanks for the information.

>
>
>> +	/* Set tdm/i2s1 master bclk ratio */
>> +	ret = snd_soc_dai_set_bclk_ratio(codec_dai, ch * format);
>> +	if (ret < 0) {
>> +		dev_err(rtd->dev, "Failed to set rt5682 tdm bclk ratio: %d\n", ret);
>> +		return ret;
>> +	}
>> +
>> +	if (!drvdata->soc_mclk) {
>> +		ret = acp_clk_enable(drvdata, srate, ch * format);
>> +		if (ret < 0) {
>> +			dev_err(rtd->card->dev, "Failed to enable HS clk: %d\n", ret);
>> +			return ret;
>> +		}
> [1]
> https://github.com/thesofproject/linux/actions/runs/4005001249/jobs/6874834205