Message-ID: <c95487db-f304-2610-5e93-41d7b39934d7@huawei.com>
Date:   Mon, 30 Jan 2023 12:02:44 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH -next] evm: call dump_security_xattr() in all cases to
 remove code duplication
To:     Mimi Zohar <zohar@linux.ibm.com>, <dmitry.kasatkin@gmail.com>,
        <paul@paul-moore.com>, <jmorris@namei.org>, <serge@hallyn.com>
CC:     <linux-integrity@vger.kernel.org>,
        <linux-security-module@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230129004637.191106-1-xiujianfeng@huawei.com>
 <a7f1324e88023a86c3489d53268bde17069ece1f.camel@linux.ibm.com>
Content-Language: en-US
From:   xiujianfeng <xiujianfeng@huawei.com>
In-Reply-To: <a7f1324e88023a86c3489d53268bde17069ece1f.camel@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 2023/1/30 0:15, Mimi Zohar wrote:
>> @@ -254,15 +264,9 @@ static int evm_calc_hmac_or_hash(struct dentry *dentry,
>>  			if (is_ima)
>>  				ima_present = true;
>>  
>> -			if (req_xattr_value_len < 64)
>> -				pr_debug("%s: (%zu) [%*phN]\n", req_xattr_name,
>> -					 req_xattr_value_len,
>> -					 (int)req_xattr_value_len,
>> -					 req_xattr_value);
>> -			else
>> -				dump_security_xattr(req_xattr_name,
>> -						    req_xattr_value,
>> -						    req_xattr_value_len);
>> +			dump_security_xattr(req_xattr_name,
>> +					    req_xattr_value,
>> +					    req_xattr_value_len);
>>  			continue;
>>  		}
>>  		size = vfs_getxattr_alloc(&nop_mnt_idmap, dentry, xattr->name,
> 
> Hm, this patch doesn't apply properly.

I noticed that the patch fails to apply on linux master, however this
patch is meant for linux-next, would you please maybe have a look?

> 
> Mimi>
>