Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762594AbXH3WTH (ORCPT ); Thu, 30 Aug 2007 18:19:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762535AbXH3WSk (ORCPT ); Thu, 30 Aug 2007 18:18:40 -0400 Received: from wa-out-1112.google.com ([209.85.146.182]:61083 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762383AbXH3WSi (ORCPT ); Thu, 30 Aug 2007 18:18:38 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=TxI5fSVIhLul+mMS5QGPZ153BoaVCj+YYbPJZ+9O58F2q2MfM/F4T4FG3851YE9qKqQs1c+P0pP/b2Chn5uBS6bx1sAJALhA+fK2bM6YDiEQZECuJdTWxalsEPwY9ZLcFdS82PYP23kxx9yNvdt59lwPAvyfkIHHvUoxVTGV88Q= Message-ID: Date: Thu, 30 Aug 2007 15:18:37 -0700 From: "Bret Towe" To: "Trond Myklebust" Subject: Re: NFS woes again Cc: "Florin Iucha" , "Linux Kernel Mailing List" , "Michal Piotrowski" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070822132200.GO10422@iucha.net> <20070823125210.GQ10422@iucha.net> <20070823173637.GS10422@iucha.net> <1188220651.6701.32.camel@heimdal.trondhjem.org> <20070828013541.GA10422@iucha.net> <1188307723.6701.138.camel@heimdal.trondhjem.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2697 Lines: 75 On 8/28/07, Bret Towe wrote: > On 8/28/07, Trond Myklebust wrote: > > On Mon, 2007-08-27 at 20:35 -0500, Florin Iucha wrote: > > > On Mon, Aug 27, 2007 at 06:19:29PM -0700, Bret Towe wrote: > > > > On 8/27/07, Trond Myklebust wrote: > > > > > > > this sounds alot like the post i did yesterday titled 'nfs4 hang regression' > > > > > > > i tracked it down to commit 3d39c691ff486142dd9aaeac12f553f4476b7a6 > > > > > > > > > > > > Yes, it certainly does -- all the symptoms match! > > > > > > > > > > Could you and Bret please check if the attached patch fixes the hang? > > > > > > > > no good for me still hangs after ~30minutes > > > > > > I just booted into the new kernel > > > (3d39c691ff486142dd9aaeac12f553f4476b7a6 + Trond's patch) and it hangs > > > in 10-15 minutes. > > > > > > Process traces available at http://iucha.net/nfs/23-rc2-nfs-fix-1/kernel.log.gz > > > > > > Regards, > > > florin > > > > Doh! I see the problem: cancel_delayed_work_sync() shouldn't ever be > > called recursively. > > > > The following patch should be correct. Please just discard the previous > > one... > > > > Trond > > > > uptime of 3 hours and keyboard is still working fine > I'll hopefully get to test this on the mini tomorrow for at least 3 hours also got 45min on mini before I had to go elsewhere the amd64 shutdown fine and has been up for more than 3 hours I'd say the patch does it > > > > ---------- Forwarded message ---------- > > From: Trond Myklebust > > To: > > Date: Mon, 27 Aug 2007 09:14:56 -0400 > > Subject: No Subject > > Doh! We can't use cancel_delayed_work_sync because we may have been called > > from an unmount that was being performed by nfs_automount_task. > > > > Signed-off-by: Trond Myklebust > > --- > > > > fs/nfs/namespace.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/fs/nfs/namespace.c b/fs/nfs/namespace.c > > index aea76d0..acfc56f 100644 > > --- a/fs/nfs/namespace.c > > +++ b/fs/nfs/namespace.c > > @@ -176,7 +176,7 @@ static void nfs_expire_automounts(struct work_struct *work) > > void nfs_release_automount_timer(void) > > { > > if (list_empty(&nfs_automount_list)) > > - cancel_delayed_work_sync(&nfs_automount_task); > > + cancel_delayed_work(&nfs_automount_task); > > } > > > > /* > > > > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/